Browse Source

Case sensitive label matching

After upgrading Gerrit to 2.13 our gate stopped working. The reason
for this is that after a successful gate run zuul does something like
'gerrit review --label verified=2 --submit'. The verified label in
Gerrit by default is configured as 'Verified'. The newer version of
gerrit behaves different now. It accepts the +2 vote on verified but
doesn't submit the patch anymore if the casing is not correct. This
forces us to specify the label in the same casing as gerrit
expects. In that case the tolower() in canMerge prevents the patch
from entering the gate.

In order to avoid confusion and be consistent, avoid any case
conversions and use the labels exactly as defined in Gerrit.

Note that this patch requires changes to the pipelines such that the
labels are spelled exactly as defined in Gerrit.

Change-Id: I9713a075e07b268e4f2620c0862c128158283c7c
changes/46/469946/7
Tobias Henkel 4 years ago
committed by Tobias Henkel
parent
commit
ea98a194cc
  1. 10
      doc/source/user/config.rst
  2. 16
      etc/layout.yaml-sample
  3. 23
      tests/base.py
  4. 12
      tests/fixtures/config/ansible/git/common-config/zuul.yaml
  5. 4
      tests/fixtures/config/broken/git/common-config/zuul.yaml
  6. 4
      tests/fixtures/config/data-return/git/common-config/zuul.yaml
  7. 8
      tests/fixtures/config/dependency-graph/git/common-config/zuul.yaml
  8. 8
      tests/fixtures/config/duplicate-pipeline/git/common-config/zuul.yaml
  9. 4
      tests/fixtures/config/git-driver/git/common-config/zuul.yaml
  10. 4
      tests/fixtures/config/implicit-roles/git/common-config/zuul.yaml
  11. 20
      tests/fixtures/config/in-repo/git/common-config/zuul.yaml
  12. 4
      tests/fixtures/config/inventory/git/common-config/zuul.yaml
  13. 12
      tests/fixtures/config/merges/git/common-config/zuul.yaml
  14. 4
      tests/fixtures/config/multi-tenant-semaphore/git/common-config/zuul.yaml
  15. 4
      tests/fixtures/config/multi-tenant/git/common-config/zuul.yaml
  16. 8
      tests/fixtures/config/multi-tenant/git/tenant-one-config/zuul.yaml
  17. 8
      tests/fixtures/config/multi-tenant/git/tenant-two-config/zuul.yaml
  18. 12
      tests/fixtures/config/openstack/git/project-config/zuul.yaml
  19. 4
      tests/fixtures/config/pre-playbook/git/common-config/zuul.yaml
  20. 8
      tests/fixtures/config/requirements/email/git/common-config/zuul.yaml
  21. 8
      tests/fixtures/config/requirements/newer-than/git/common-config/zuul.yaml
  22. 8
      tests/fixtures/config/requirements/older-than/git/common-config/zuul.yaml
  23. 8
      tests/fixtures/config/requirements/reject-username/git/common-config/zuul.yaml
  24. 16
      tests/fixtures/config/requirements/reject/git/common-config/zuul.yaml
  25. 12
      tests/fixtures/config/requirements/state/git/common-config/zuul.yaml
  26. 8
      tests/fixtures/config/requirements/username/git/common-config/zuul.yaml
  27. 12
      tests/fixtures/config/requirements/vote1/git/common-config/zuul.yaml
  28. 12
      tests/fixtures/config/requirements/vote2/git/common-config/zuul.yaml
  29. 12
      tests/fixtures/config/roles/git/common-config/zuul.yaml
  30. 4
      tests/fixtures/config/semaphore/git/common-config/zuul.yaml
  31. 4
      tests/fixtures/config/semaphore/zuul-reconfiguration.yaml
  32. 4
      tests/fixtures/config/shadow/git/local-config/zuul.yaml
  33. 12
      tests/fixtures/config/single-tenant/git/common-config/zuul.yaml
  34. 4
      tests/fixtures/config/split-config/git/common-config/zuul.d/pipelines.yaml
  35. 4
      tests/fixtures/config/sql-driver/git/common-config/zuul.yaml
  36. 4
      tests/fixtures/config/streamer/git/common-config/zuul.yaml
  37. 4
      tests/fixtures/config/success-url/git/common-config/zuul.yaml
  38. 12
      tests/fixtures/config/templated-project/git/common-config/zuul.d/pipelines.yaml
  39. 4
      tests/fixtures/config/tenant-parser/git/common-config/zuul.yaml
  40. 16
      tests/fixtures/config/zuul-connections-multiple-gerrits/git/common-config/zuul.yaml
  41. 4
      tests/fixtures/config/zuul-connections-same-gerrit/git/common-config/zuul.yaml
  42. 16
      tests/fixtures/config/zuultrigger/parent-change-enqueued/git/common-config/zuul.yaml
  43. 14
      tests/fixtures/config/zuultrigger/project-change-merged/git/common-config/zuul.yaml
  44. 12
      tests/fixtures/layout-cloner.yaml
  45. 12
      tests/fixtures/layout-delayed-repo-init.yaml
  46. 4
      tests/fixtures/layout-disable-at.yaml
  47. 8
      tests/fixtures/layout-live-reconfiguration-functions.yaml
  48. 2
      tests/fixtures/layout-merge-queues.yaml
  49. 12
      tests/fixtures/layout-requirement-vote.yaml
  50. 4
      tests/fixtures/layout-smtp.yaml
  51. 30
      tests/fixtures/layout.yaml
  52. 4
      tests/fixtures/layouts/disable_at.yaml
  53. 8
      tests/fixtures/layouts/footer-message.yaml
  54. 4
      tests/fixtures/layouts/ignore-dependencies.yaml
  55. 4
      tests/fixtures/layouts/inheritance.yaml
  56. 4
      tests/fixtures/layouts/irrelevant-files.yaml
  57. 8
      tests/fixtures/layouts/live-reconfiguration-add-job.yaml
  58. 4
      tests/fixtures/layouts/live-reconfiguration-del-project.yaml
  59. 4
      tests/fixtures/layouts/live-reconfiguration-failed-job.yaml
  60. 12
      tests/fixtures/layouts/live-reconfiguration-shared-queue.yaml
  61. 14
      tests/fixtures/layouts/merge-failure.yaml
  62. 4
      tests/fixtures/layouts/no-jobs-project.yaml
  63. 12
      tests/fixtures/layouts/no-jobs.yaml
  64. 4
      tests/fixtures/layouts/no-timer.yaml
  65. 8
      tests/fixtures/layouts/nonvoting-job.yaml
  66. 8
      tests/fixtures/layouts/noop-job.yaml
  67. 12
      tests/fixtures/layouts/one-job-project.yaml
  68. 8
      tests/fixtures/layouts/rate-limit.yaml
  69. 12
      tests/fixtures/layouts/repo-checkout-four-project.yaml
  70. 12
      tests/fixtures/layouts/repo-checkout-six-project.yaml
  71. 12
      tests/fixtures/layouts/repo-checkout-two-project.yaml
  72. 12
      tests/fixtures/layouts/repo-deleted.yaml
  73. 12
      tests/fixtures/layouts/smtp.yaml
  74. 4
      tests/fixtures/layouts/tags.yaml
  75. 12
      tests/fixtures/layouts/three-projects.yaml
  76. 4
      tests/fixtures/layouts/timer.yaml
  77. 6
      tests/fixtures/layouts/unmanaged-project.yaml
  78. 4
      tests/unit/test_connection.py
  79. 2
      zuul/driver/gerrit/gerritconnection.py
  80. 11
      zuul/driver/gerrit/gerritmodel.py

10
doc/source/user/config.rst

@ -115,10 +115,10 @@ success, the pipeline reports back to Gerrit with a *Verified* vote of
- event: patchset-created
success:
my_gerrit:
verified: 1
Verified: 1
failure:
my_gerrit
verified: -1
Verified: -1
.. TODO: See TODO for more annotated examples of common pipeline configurations.
@ -255,9 +255,9 @@ optional unless otherwise specified):
to match. Same format as "older-than".
Any other field is interpreted as a review category and value
pair. For example ``verified: 1`` would require that the approval
pair. For example ``Verified: 1`` would require that the approval
be for a +1 vote in the "Verified" column. The value may either
be a single value or a list: ``verified: [1, 2]`` would match
be a single value or a list: ``Verified: [1, 2]`` would match
either a +1 or +2 vote.
**open**
@ -287,7 +287,7 @@ optional unless otherwise specified):
reject:
approval:
- code-review: [-1, -2]
- Code-Review: [-1, -2]
**dequeue-on-new-patchset**
Normally, if a new patchset is uploaded to a change that is in a

16
etc/layout.yaml-sample

@ -6,10 +6,10 @@ pipelines:
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- name: tests
manager: IndependentPipelineManager
@ -19,10 +19,10 @@ pipelines:
email_filter: ^.*@example.org$
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- name: post
manager: IndependentPipelineManager
@ -38,16 +38,16 @@ pipelines:
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
start:
gerrit:
verified: 0
Verified: 0
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
jobs:
- name: ^.*-merge$

23
tests/base.py

@ -133,9 +133,19 @@ class GerritChangeReference(git.Reference):
class FakeGerritChange(object):
categories = {'approved': ('Approved', -1, 1),
'code-review': ('Code-Review', -2, 2),
'verified': ('Verified', -2, 2)}
categories = {'Approved': ('Approved', -1, 1),
'Code-Review': ('Code-Review', -2, 2),
'Verified': ('Verified', -2, 2)}
# TODO(tobiash): This is used as a translation layer between the tests
# which use lower case labels. This can be removed if all
# tests are converted to use the correct casing.
categories_translation = {'approved': 'Approved',
'code-review': 'Code-Review',
'verified': 'Verified',
'Approved': 'Approved',
'Code-Review': 'Code-Review',
'Verified': 'Verified'}
def __init__(self, gerrit, number, project, branch, subject,
status='NEW', upstream_root=None, files={}):
@ -331,8 +341,8 @@ class FakeGerritChange(object):
if not granted_on:
granted_on = time.time()
approval = {
'description': self.categories[category][0],
'type': category,
'description': self.categories_translation[category],
'type': self.categories_translation[category],
'value': str(value),
'by': {
'username': username,
@ -341,7 +351,8 @@ class FakeGerritChange(object):
'grantedOn': int(granted_on)
}
for i, x in enumerate(self.patchsets[-1]['approvals'][:]):
if x['by']['username'] == username and x['type'] == category:
if x['by']['username'] == username and \
x['type'] == self.categories_translation[category]:
del self.patchsets[-1]['approvals'][i]
self.patchsets[-1]['approvals'].append(approval)
event = {'approvals': [approval],

12
tests/fixtures/config/ansible/git/common-config/zuul.yaml

@ -7,10 +7,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: gate
@ -20,17 +20,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- secret:

4
tests/fixtures/config/broken/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- project:
error: true

4
tests/fixtures/config/data-return/git/common-config/zuul.yaml

@ -7,10 +7,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: data-return

8
tests/fixtures/config/dependency-graph/git/common-config/zuul.yaml

@ -6,17 +6,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- job:

8
tests/fixtures/config/duplicate-pipeline/git/common-config/zuul.yaml

@ -7,10 +7,10 @@
- event: change-restored
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: dup2
@ -21,10 +21,10 @@
- event: change-restored
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project-test1

4
tests/fixtures/config/git-driver/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project-test1

4
tests/fixtures/config/implicit-roles/git/common-config/zuul.yaml

@ -6,7 +6,7 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1

20
tests/fixtures/config/in-repo/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: tenant-one-gate
@ -19,17 +19,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- pipeline:
@ -39,17 +39,17 @@
gerrit:
- event: comment-added
approval:
- code-review: 2
- Code-Review: 2
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- job:

4
tests/fixtures/config/inventory/git/common-config/zuul.yaml

@ -7,10 +7,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- nodeset:
name: nodeset1

12
tests/fixtures/config/merges/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: gate
@ -19,17 +19,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- job:

4
tests/fixtures/config/multi-tenant-semaphore/git/common-config/zuul.yaml

@ -6,7 +6,7 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1

4
tests/fixtures/config/multi-tenant/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: python27

8
tests/fixtures/config/multi-tenant/git/tenant-one-config/zuul.yaml

@ -6,17 +6,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- nodeset:

8
tests/fixtures/config/multi-tenant/git/tenant-two-config/zuul.yaml

@ -6,17 +6,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- nodeset:

12
tests/fixtures/config/openstack/git/project-config/zuul.yaml

@ -7,10 +7,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: gate
@ -20,17 +20,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- job:

4
tests/fixtures/config/pre-playbook/git/common-config/zuul.yaml

@ -7,10 +7,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: python27

8
tests/fixtures/config/requirements/email/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
require:
gerrit:
approval:
@ -25,10 +25,10 @@
- email: jenkins@example.com
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project1-job

8
tests/fixtures/config/requirements/newer-than/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
require:
gerrit:
approval:
@ -27,10 +27,10 @@
newer-than: 48h
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project1-job

8
tests/fixtures/config/requirements/older-than/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
require:
gerrit:
approval:
@ -27,10 +27,10 @@
older-than: 48h
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project1-job

8
tests/fixtures/config/requirements/reject-username/git/common-config/zuul.yaml

@ -10,10 +10,10 @@
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: trigger
@ -25,10 +25,10 @@
- username: jenkins
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project1-job

16
tests/fixtures/config/requirements/reject/git/common-config/zuul.yaml

@ -5,13 +5,13 @@
gerrit:
approval:
- username: jenkins
verified:
Verified:
- 1
- 2
reject:
gerrit:
approval:
- verified:
- Verified:
- -1
- -2
trigger:
@ -19,10 +19,10 @@
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: trigger
@ -32,19 +32,19 @@
- event: comment-added
require-approval:
- username: jenkins
verified:
Verified:
- 1
- 2
reject-approval:
- verified:
- Verified:
- -1
- -2
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project1-job

12
tests/fixtures/config/requirements/state/git/common-config/zuul.yaml

@ -10,10 +10,10 @@
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: open-check
@ -27,10 +27,10 @@
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: status-check
@ -44,10 +44,10 @@
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project-job

8
tests/fixtures/config/requirements/username/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
require:
gerrit:
approval:
@ -25,10 +25,10 @@
- username: jenkins
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project1-job

12
tests/fixtures/config/requirements/vote1/git/common-config/zuul.yaml

@ -5,16 +5,16 @@
gerrit:
approval:
- username: jenkins
verified: 1
Verified: 1
trigger:
gerrit:
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: trigger
@ -24,13 +24,13 @@
- event: comment-added
require-approval:
- username: jenkins
verified: 1
Verified: 1
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project1-job

12
tests/fixtures/config/requirements/vote2/git/common-config/zuul.yaml

@ -5,7 +5,7 @@
gerrit:
approval:
- username: jenkins
verified:
Verified:
- 1
- 2
trigger:
@ -13,10 +13,10 @@
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: trigger
@ -26,15 +26,15 @@
- event: comment-added
require-approval:
- username: jenkins
verified:
Verified:
- 1
- 2
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project1-job

12
tests/fixtures/config/roles/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: tenant-one-gate
@ -19,17 +19,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- job:

4
tests/fixtures/config/semaphore/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
# TODOv3(jeblair, tobiash): make semaphore definitions required, which
# will cause these tests to fail until we define test-semaphore

4
tests/fixtures/config/semaphore/zuul-reconfiguration.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project-test1

4
tests/fixtures/config/shadow/git/local-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: base

12
tests/fixtures/config/single-tenant/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: gate
@ -19,17 +19,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- pipeline:

4
tests/fixtures/config/split-config/git/common-config/zuul.d/pipelines.yaml

@ -6,7 +6,7 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1

4
tests/fixtures/config/sql-driver/git/common-config/zuul.yaml

@ -6,12 +6,12 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
resultsdb:
score: 1
failure:
gerrit:
verified: -1
Verified: -1
resultsdb:
score: -1
resultsdb_failures:

4
tests/fixtures/config/streamer/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: python27

4
tests/fixtures/config/success-url/git/common-config/zuul.yaml

@ -9,12 +9,12 @@
to: alternative_me@example.com
success:
gerrit:
verified: 1
Verified: 1
smtp:
to: alternative_me@example.com
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: docs-draft-test

12
tests/fixtures/config/templated-project/git/common-config/zuul.d/pipelines.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: gate
@ -19,17 +19,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- pipeline:

4
tests/fixtures/config/tenant-parser/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- job:
name: common-config-job

16
tests/fixtures/config/zuul-connections-multiple-gerrits/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
review_gerrit:
verified: 1
Verified: 1
failure:
review_gerrit:
verified: -1
Verified: -1
- pipeline:
name: another_check
@ -19,10 +19,10 @@
- event: patchset-created
success:
another_gerrit:
verified: 1
Verified: 1
failure:
another_gerrit:
verified: -1
Verified: -1
- pipeline:
name: common_check
@ -34,14 +34,14 @@
- event: patchset-created
success:
review_gerrit:
verified: 1
Verified: 1
another_gerrit:
verified: 1
Verified: 1
failure:
review_gerrit:
verified: -1
Verified: -1
another_gerrit:
verified: -1
Verified: -1
- job:
name: project-test1

4
tests/fixtures/config/zuul-connections-same-gerrit/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
review_gerrit:
verified: 1
Verified: 1
failure:
alt_voting_gerrit:
verified: -1
Verified: -1
- job:
name: project-test1

16
tests/fixtures/config/zuultrigger/parent-change-enqueued/git/common-config/zuul.yaml

@ -4,7 +4,7 @@
require:
gerrit:
approval:
- verified: -1
- Verified: -1
trigger:
gerrit:
- event: patchset-created
@ -13,10 +13,10 @@
pipeline: gate
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: gate
@ -24,25 +24,25 @@
require:
gerrit:
approval:
- verified: 1
- Verified: 1
trigger:
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
zuul:
- event: parent-change-enqueued
pipeline: gate
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- job:

14
tests/fixtures/config/zuultrigger/project-change-merged/git/common-config/zuul.yaml

@ -6,10 +6,10 @@
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- pipeline:
name: gate
@ -19,17 +19,17 @@
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
- pipeline:
@ -41,7 +41,7 @@
- event: project-change-merged
merge-failure:
gerrit:
verified: -1
Verified: -1
- job:
name: project-check

12
tests/fixtures/layout-cloner.yaml

@ -6,10 +6,10 @@ pipelines:
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- name: gate
manager: DependentPipelineManager
@ -18,17 +18,17 @@ pipelines:
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
start:
gerrit:
verified: 0
Verified: 0
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
- name: post
manager: IndependentPipelineManager

12
tests/fixtures/layout-delayed-repo-init.yaml

@ -6,10 +6,10 @@ pipelines:
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
- name: post
manager: IndependentPipelineManager
@ -25,17 +25,17 @@ pipelines:
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
projects:

4
tests/fixtures/layout-disable-at.yaml

@ -6,10 +6,10 @@ pipelines:
- event: patchset-created
success:
gerrit:
verified: 1
Verified: 1
failure:
gerrit:
verified: -1
Verified: -1
disabled:
smtp:
to: you@example.com

8
tests/fixtures/layout-live-reconfiguration-functions.yaml

@ -9,17 +9,17 @@ pipelines:
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
success:
gerrit:
verified: 2
Verified: 2
submit: true
failure:
gerrit:
verified: -2
Verified: -2
start:
gerrit:
verified: 0
Verified: 0
precedence: high
jobs:

2
tests/fixtures/layout-merge-queues.yaml

@ -6,7 +6,7 @@ pipelines:
gerrit:
- event: comment-added
approval:
- approved: 1
- Approved: 1
projects:
- name: projectA

12
tests/fixtures/layout-requirement-vote.yaml

@ -4,16 +4,16 @@ pipelines:
require:
approval:
- username: jenkins
verified: 1
Verified: 1
trigger:
gerrit:
- event: comment-added
success:
gerrit:
verified: 1
Verified: 1