zuul/zuul
Code Issues Proposed changes

Fix test_supercedent_github_circular_deps_closed race

Browse Source 
This test is subject to race conditions where if the initial
pipeline status is not created before the nologs check, the nologs
assertion will trip on it.  Force a pipeline run before the main
part of the test.

Change-Id: Ib1d8e33467b92cb974ff05bc20b47215d1d21f2c
This commit is contained in:
James E. Blair 2024-12-19 11:15:47 -08:00
parent 98eb43ea2a
commit ed000784f1
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit/test_supercedent.py
View File

@ -274,6 +274,12 @@ class TestSupercedentCircularDependencies(ZuulTestCase):
@simple_layout('layouts/supercedent-circular-github.yaml', driver='github')
def test_supercedent_github_circular_deps_closed(self):
# Run one change through the pipeline to force all the
# zkobjects to be created so that the nologs check below
# doesn't see the initial error message.
C = self.fake_github.openFakePullRequest("org/project1", "master", "C")
self.fake_github.emitEvent(C.getPullRequestClosedEvent())
self.waitUntilSettled("create pipeline objects")
# We leave testing pre-merge changes to the gerrit test above.
# In this test, we're testing post-merge change objects (not
# refs) via github since there is a reasonable post-merge