zuul/zuul
Code Issues Proposed changes

Fix issue with early failure and blocks

Browse Source 
Ansible tasks that fail within block tasks call the failure
callback, which means that they triggered Zuul early failure
detection even if they were later rescued.  To avoid this,
ignore block tasks for purposes of early failure detection.

Also make early failure detection "sticky".  This helps
uncover errors like this (the "remote" tests uncover this
particular failure if the result is made sticky), and also
ensures consistent behavior in dependent pipelines.

Change-Id: I505667678e7384386819b5389036e4fb4f108afd
This commit is contained in:
James E. Blair
2023-08-21 16:08:01 -07:00
parent df709af7f5
commit f04d80912e
3 changed files with 33 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
releasenotes/notes/early-failure-fix-386f079693e54f97.yaml Normal file
View File

@@ -0,0 +1,10 @@
---
fixes:
- |
Ansible task failures in block/rescue stanzas could cause Zuul to
erroneously trigger early-failure behavior for the build, which
could result in inconsistent behavior in a dependent pipeline.
Task failures in Ansible blocks are no longer considered for early
failure detection, and if a build encounters an early failure, it
will cause the build result to be reported as a failure in all
cases.