zuul
/
zuul
Code Issues Proposed changes

Cleanup unused connection.getWebController info param 

This info parameter to getWebController is unused (and redundant as the
zuul_web parameter has the info attribute attached to it). Clean it out
to avoid confusion.

Change-Id: I6ce12b535f56f8fa367a9a99d3e46bc26c2a50d8
This commit is contained in:
Clark Boylan 2018-06-01 15:52:53 -07:00
parent 57c0a67f89
commit f0c38b52e6
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
zuul/connection/__init__.py
View File

@ -75,14 +75,11 @@ class BaseConnection(object, metaclass=abc.ABCMeta):
still in use. Anything in our cache that isn't in the supplied
list should be safe to remove from the cache."""
def getWebController(self, zuul_web, info):
def getWebController(self, zuul_web):
"""Return a cherrypy web controller to register with zuul-web.
:param zuul.web.ZuulWeb zuul_web:
Zuul Web instance.
:param zuul.model.WebInfo info:
The WebInfo object for the Zuul Web instance. Can be used by
plugins to toggle API capabilities.
:returns: A `zuul.web.handler.BaseWebController` instance.
"""
return None

2
zuul/driver/github/githubconnection.py
View File

@ -1148,7 +1148,7 @@ class GithubConnection(BaseConnection):
return statuses
def getWebController(self, zuul_web, info):
def getWebController(self, zuul_web):
return GithubWebController(zuul_web, self)
def validateWebConfig(self, config, connections):

2
zuul/web/__init__.py
View File

@ -340,7 +340,7 @@ class ZuulWeb(object):
controller=api, action='builds')
for connection in connections.connections.values():
controller = connection.getWebController(self, self.info)
controller = connection.getWebController(self)
if controller:
cherrypy.tree.mount(
controller,