Browse Source

zuul.gerrit.Gerrit.isMerged should not return None

* zuul/trigger/gerrit.py(Gerrit.isMerged): Make sure to return False
if we fell through all the conditionals, rather than defaulting to
None. This should have no current impact since all comparisons to
the returned value elsewhere are boolean and not "is None" or
similar.

Change-Id: I05360833f1e5b35fbfb1894dadcb46e82ff78a11
changes/18/81418/1
Jeremy Stanley 8 years ago
parent
commit
f31175db78
  1. 1
      zuul/trigger/gerrit.py

1
zuul/trigger/gerrit.py

@ -238,6 +238,7 @@ class Gerrit(object):
self.log.debug("Change %s status: %s" % (change, status))
if status == 'MERGED':
return True
return False
def canMerge(self, change, allow_needs):
if not change.number:

Loading…
Cancel
Save