zuul
/
zuul
Code Issues Proposed changes

web: remove status page componentDidUpdate implementation 

It is not necessary to loadState when the timezone change as
this is already managed by react engine.
Moreover this method introduced a bug by shadowing the parent
Refreshable, which is in charge of fetching status page when
the tenant change.

Change-Id: I9fd35446c7fe98ce4bbb992983ec1ab56f3d32c5
This commit is contained in:
Tristan Cacqueray 2020-05-21 19:46:53 +00:00
parent 5350525e65
commit ff0e878865
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/pages/Status.jsx
View File

@ -113,12 +113,6 @@ class StatusPage extends Refreshable {
this.visibilityChangeEvent, this.visibilityListener)
}
componentDidUpdate (prevProps) {
if (this.props.timezone !== prevProps.timezo) {
this.loadState()
}
}
setFilter = (filter) => {
this.filter.value = filter
this.setState({filter: filter})