Currently manual enqueue of github pull requests to gate pipelines is
broken because the pull request number can be of type string instead
of int which breaks the graphql query.

To fix this centrally force the pull request number to int in
_getChange in order to prevent this and potential similar side effects
of str vs. int.

Change-Id: I0ad241e0308feb60b173182375f04313b008dce6

Expand on the note about cross-project dependencies between changes
which do not share a change queue, making it clear that depending
changes won't be automatically enqueued once their dependency
conditions are satisfied.

Change-Id: I5e0096b2390ee7e4101e3c0abf0a2402b45383ff

zk-ca.sh doesn't generate jks files, it generates pem files without
any password.

Change-Id: Idcd404787f0d47da363f47347d429e814a2c6d3b

The zk-ca.sh tool for generating certificates fails with
and error that ./tools/openssl.cnf cannot be opened if a
relative path is supplied on ubuntu-bionic. So expand the
path to an absolute path instead.

http://paste.openstack.org/show/794091/

Change-Id: Ib30e9754d4520b956e83cae014c1be181ae44631

Change-Id: I773332527f352c9c74a6bc55ba28a1ae54b4dd9e

This change documents how the kubectl was not working and it adds
a log statement to help debug future issue.

Change-Id: Iaf6ca030365d9e4e768bca716568cb2d4289665d

Change-Id: I8e83d8c40893a395dedb6afcbec3dc86f8be0ac9

Zuul is using a dateutil provided transitively. This change
makes the requirements explicit.

Change-Id: I672d409a1bb241e5d199c77acdd51a8260d99ee2

It is not necessary to loadState when the timezone change as
this is already managed by react engine.
Moreover this method introduced a bug by shadowing the parent
Refreshable, which is in charge of fetching status page when
the tenant change.

Change-Id: I9fd35446c7fe98ce4bbb992983ec1ab56f3d32c5

While trying to figure out why the ansi patch wouldn't
build it emerged that we're now 2 major releases behind
on create-react-app.

Update create-react-app to the latest 3.4.1. This also updates
react to 16.13, and updates eslint globals processing so that
we don't have to declare globals in headers when we've
declared them already in the eslint file.

Finally, although this doesn't do it, create-react-app 3
has support for typescript, so if we want we can start migrating
files to .ts or .tsx extensions and start doing typing in
them.

Pin nanoid to v2 until such a time as create-react-app can be
updated to 3.4.2 which is needed ot handle .cjs extensions
being used by nanoid.

Change-Id: Ibc69bef605a62e4fdd2ebba33d9d1b822e7dfeba

Zuul currently has a zuul/gated badge that can be linked e.g. in a
readme of a project. This is sufficient for many use cases. However if
a project has periodic jobs that do extended testing which is not
possible in check/gate this is not sufficient. For use cases like
those we can add support for dynamic badges in zuul itself.

Change-Id: I449fa9f38ca251522789b6075fbc876d21bd0200

- the default value keep UTC
 - the timezone is saved in cookie in zuul_timezone_string
 - the render format is YYYY-MM-DD HH:mm:ss

Change-Id: Ib4ac2af4194ac2722c5574577661f4ddda8cc398

This serialization is used by the REST API as well as configuration
change detection.  Including these variables allows API users to
see a more complete picture of the job as well as corrects a
malfunction in the job config change detection (a change to a job
with file matcher's host-vars, for example, would not trigger running
the job).

Change-Id: I27b5fd81fc0c90bd13ead6ecdef0a5d3dbcc2e57

v14 is the latest lts. Let's use it.

Also - rename the jobs to make it clear what they're doing, and
add a dashboard job that points at opendev's multi-tenat api too.

There are new jobs that default to latest node LTS and auto-detect
yarn vs npm. Update to use them.

Depends-On: https://review.opendev.org/728097
Depends-On: https://review.opendev.org/726547
Change-Id: I5717edea2cd09acc5bce673c38bbe7fa8057a376

Fix a trivial typo in the glossary of the
Zuul documentation.

Change-Id: I1f110ca5c17bc2b535029377cfd9d1933fe24a23

Align autohold's CORS policy with other endpoints.

Change-Id: I677daadfafd5903dc0db7d6aba5b57de933f8bc6

We lately saw increasing rates of failed tests in the remote
tests. Some of them are failing with timeout waiting zuul to
settle. Therefore increase the wait timeout for the zuul stream and
action modules tests.

Change-Id: Ia7b03405e8199aa6c3d2c737244ba26161986783

The commands are managed as entry-points so remove
ununecessary shebangs. Also lib/re2util.py does not
require a shebang as well.

zuul_return.py does not have a main and is not supposed
to be run directly.

Ununecessary shebangs for non executable script causes
rpmlint issues.

Change-Id: I6015daaa0fe35b6935fcbffca1907c01c9a26134

- set 'url' in order to avoid "'NoneType' object is not iterable"
  exception
- fix value of 'uris':
  - use a list of URLs, not a list of characters
  - remove scheme from the URL

Change-Id: Iaa0197eb290a9e21aa63eb65a1c8a677abf8298b

The change number is either a str (when 'zuul enqueue' is used) or
an int (when a Gitlab event is received).

Change-Id: Ib110716ecb0d364ab3624bc369aa428a600a3753

Change-Id: I1c66e3fae65f740866202e84fcfce34f5830f155

Use the --user to install bindep

Change-Id: I8a1c79a6d591c4e43416f4afc3dba87f78ef612e

Ansible 2.6 has been unmaintained since several months now so remove
support for it.

Change-Id: Ifb604eb5cb86fd0210c1dfd8418f069273e302b6

Ansible 2.9 is there since several months now and had numerous bugfix
releases. Thus we should default to it since it is the newest and best
maintained release.

Change-Id: If6687514a6237bb9816b54745aac5ec24383c8bf

This corrects an error
  Error in dynamic layout
  Traceback (most recent call last):
    File "/usr/local/lib/python3.8/site-packages/zuul/manager/__init__.py", line 625, in _loadDynamicLayout
      relevant_errors = self._findRelevantErrors(item,
    File "/usr/local/lib/python3.8/site-packages/zuul/manager/__init__.py", line 517, in _findRelevantErrors
      parent_layout.loading_errors.error_keys) or
  AttributeError: 'NoneType' object has no attribute 'loading_errors'

which can be caused when the following conditions are met:

* Tenant A is listed first.
* Tenant A holds projects A and B.
* Project B references a config object defined in project A.
* Tenant A loads without errors.
* Tenant B holds projects B and C.
* Tenant B has a standing configuration error due to the unknown
  reference to an object in project A from project B.
* Two or more changes to project C which cause dynamic
  configurations to be created are enqueued in a pipeline.
* The merge job for the second change finishes before the first.

This is because:

We cache configuration objects if they load without error in
their first tenant; that means that they can show up as errors in
later tenants, but as long as those other tenants aren't
proposing changes to that repo, it doesn't matter.  But it does
mean that every dynamic reconfiguration in this tenant will see
errors and will execute the code path that compares the new
dynamic configuration to the previous one to see if they are
relevant.

If a merge job for a dynamic config change arrives out of order,
we will compare it to the previous configuration to determine if
they are relevant, but since the previous layout had not been
calculated yet, the exception above was hit.

The solution is to indicate that the layout for the later change
is not ready until the layout for the previous change is.

Change-Id: Ibe1392a494d42b65080ab7e42f116db3869548ff

This patch provides the general functionality to allow reporting of
dequeued items and makes use of that in the Github checks API.
This reporting will only apply if the item wasn't a success or failure.

Change-Id: I1297da4d1708908c6b179110479fe0450e5550fe