Mocked issue search was broken in multiple ways:

- tokenize() was wrongly splitting search modifieres (e.g. type:pr)
  into tokens (e.g. [type, pr])
- code for removing search modifiers (type, is, in) from terms was
  never reached and also used set(...) in a wrong way
- set intersection of search terms and body doesn't make any sense since
  this will almost always have ANY overlap

Simply extracting the URLs from the query and checking for in PR body
should make the mock work for most of the tests.

Change-Id: I9f896af85e21770bba80857511aae8505f3e5b84

Otherwise messages from zuul and gerrit loggers are printed
twice: from the logger and from root logger.

Change-Id: I377758d4b70e250f8b2ba281cd0dabcf12555b62

Updates the environment variable processing to only affect variables
prefixed with ZUUL_.

Adds a test showing the os.environ with % in it.

This reverts commit b3929b5633.

Change-Id: Ic6c3dd0327ef70dc1375486827e4503a4cea9bfc

In prod for OpenDev we're seeing things like this:

http://paste.openstack.org/show/785704/

which lead us to believe this is somehow connected.

This reverts commit f2229705f3.

Change-Id: I0b73b71f72483e6c6e511411c3c59729761cec9b

An earlier change alters the autohold held node IDs from a list
to a dict structure. If someone upgrades to this change, but has
existing autoholds with the old format, we will break them. This
change handles both cases.

Change-Id: Ib6381e459a9694cae61ba3229d48ddfe8f55f392

When Pagure returns an API call error with EINVALIDTOK, this
patch implements a connector refresh to invalidate the
API project client cache and create a new client with the new
connector data.

This patch fixes a situation where only a Zuul restart or a token
expiration in the driver cache will force a connector (API token)
regeneration.

Change-Id: If92ea0c58ca36ab49a5c2ef251f93a3a86a5d174

This patch removes some unexpected time.sleep(1)
from the test suite.

Change-Id: I350dc083936fee708ea3cb6257f1d8ecff512e69

Since the hold request ID is the only argument, simplify things by
removing the need for using the --id option.

Change-Id: I0c176dca3cd7e3007348b5aafae812ebb55556d2

Instead of storing a flat list of nodes per hold request, this
change updates the request nodes attribute to become a list of
dictionary with the build uuid and the held node list.

Change-Id: I9e50e7ccadc58fb80d5e80d9f5aac70eb7501a36

This has been changed to "checks-api".  The feature is experimental
so a short deprecation period with no release note is okay.

Change-Id: I2b373bd589eb65996dd9bc3f343cfe31d5426b5f

If a reporter attempts to report via the checks api but ends up
using SSH instead of HTTP, log it for the benefit of the operator.

Change-Id: If9864a5aaf1e77734a7f23f2187880f5e7f42ba9

Mirror the GitHub reporter's "comment" option to allow for supressing
review messages when reporting to Gerrit.  This is needed for use with
the checks api since the purpose is to avoid leaving job results in
comments.  This removes the ability for 'comment' to be a review label,
which seems unlikely, but plausible, so a release note is added.

Rename the "checks_api" Gerrit reporter option to "checks-api" for
hyphen consistency with the rest of the configuration.  This is an
experimental feature and not generally useful yet, so no release note
is included.  This change supports both forms and updates the
documentation; a later change will remove "checks_api".

While adding documentation for the "comment" option, the description
of the Gerrit reporter is updated.

A small refactoring of the Gerrit reporter is undertaken to make
dealing with additional non-label options easier.

Change-Id: I44c0ba93601f3be3eb0f094bd782cecc4a0372f7

Missing labels should not require to be a proper subset of
the labels we set in the pipeline. The sets should also be able
to be equal.

Change-Id: If29a7f6a2730fa279c3405b24fc1d413bec456f0

Add the correct libre2 package name for Debian buster, and also
update the quickstart playbook and documentation to deal with
the change in default rsa key encoding format from newer
versions of ssh-keygen.

Change-Id: I6ada88cd896d844c1171f7bcaf4691dea023d51f

Change I1fe06d7a889dbccf86116a310701b2755e5fb385 updated the model
to handle the case where zuul_return is used to filter the child
jobs when those jobs have soft dependencies.  In short, a filtered
job should no longer be counted as a dependency when its child job
runs (as if the filtered job had not matched the change in the first
place) which makes the behavior consistent with soft dependencies
of jobs which don't match.

However, it also changed the behavior for when a job fails.  This
seems to be a simple oversight in applying the new "skip_soft"
pattern in too many places.  When a job actually fails, we do not
want its child jobs to run, regardless of whether they have a hard
or soft dependency on the failing parent.  In that case, we should
always set them to 'skipped'.  Otherwise they will never run and
the item will sit in the queue indefinitely.

Change-Id: Ic19a73d1b6e0fbe5510e71947930de4c46cc1280

When building the GitHub web url for a change, the sha of a tag was
treated like a commit sha, which leads in an invalid GitHub URL
(resulting in a 404).
To avoid this, we could use the tag information of the change and
build a tag url instead which points to the corresponding release/tag
page instead of the commit.

Change-Id: I4bf8aae0adcc6b14b43a8bbaa3fb9e891b511af4

Setting "auto" relies on nodepool change
I02a1a618c8806b150049e91b644ec3c0cb826ba4.

To avoid confusion we decided to hold-off on merging the nodepool
change so we could say "this requires zuul x.y.z".  Thus we should
hold-off on announcing it in Zuul release notes until the nodepool
side is released too.

Change-Id: Ia13d280706aa51eb44cd6177c731874bfe03b7b0

GitHub connector gives 404 HTTP error when listing branches on private
repositories using token authentication. It does not send
'Authorization: token ...' in the HTTP headers when communicating with
GitHub.

The github3.GitHub.login(token=api_token) method is only called on
self._github without any later reference on the object.

Change-Id: Ib0a56f450353e7e68b8a73b25d3905513cc2dcab

This will allow users to set environment variables with sensitive
strings like passwords, but keep a single config file. This comes
in handy when using Kubernetes in particular, as it wants to
handle sensitive data and templated config files in a very different
manner.

Change-Id: I38f6c4da82e1647ad197908f19ea6df23e04fc32

Running bindep doesn't rely on the zuul source or any of its
dependencies installed, so set usedevelop to False ensuring only
bindep and its dependencies are installed (which is much quicker and
less likely to raise unrelated dependency errors in the process).

Change-Id: I886857e22ed953efdaab5b6247d1e15039806f48

When constructing a git url for a project, urlquote the username
and password component, taking particular care to escape '/' which
is not quoted by default in urllib.parse.quote (it is the only
'safe' character by default, but it's not safe here).

Change-Id: Ia7515acc63e7258e327948bfa621cccd60491baa

Change-Id: Ie33b64b2887089b91989311dbd7ff23435a6bb4a

We're making a signficant change to how Zuul interacts with Gerrit.
No user intervention is required, but we should let folks know in
case their Gerrit configuration somehow prevents this or causes
problems.

Change-Id: I70f0b458ea2885c08db79e1a728bbeaf2192b93d

To improve user experience when fetch errors are encountered
due to expired sessions, an additional common solution proposal
is added here to the error message.

Change-Id: If7f8e905969acabd3e66710c519267d86367289d

We save the ansible version into an attribute of the AnsibleJob
class for easy reference by the cleanup playbook, however we do
so after the job has started executing (before playbooks run, but
still, it's executing).  If the job is aborted during that window,
we throw an attribute error.  This patch corrects that by saving
the value in the class initializer.

Change-Id: I0f0ebb17320a54142030e7fb18b72df34778a0ca

Always render the raw link as "(raw)" and reserve the file/dir name
for the internal link.  If there is no internal link, render it as
normal text.

This may help folks avoid inadvertently leaving the Zuul web ui and
ending up on the log server due to the subtle difference in the
links.

Change-Id: Ic161a6f9b2d3aa0c3c82198aa359c540f859d284

When getting additional change data from the Gerrit HTTP api we weren't
setting the scheme on the resulting change.url value. This resulted in
urls without a scheme which browsers would treat as relative path
components. Fix this by setting a scheme based on the connection
baseurl.

Change-Id: I9e907c79fa531d15c80e593ca7f7cebc5c516165

The quick start test assumes a compressed job output file but we don't
compress it by default anymore. Handle this new behavior change.

Change-Id: I9db270ae5ceaa98afcd078af0d99460d406295f3