Change I1fe06d7a889dbccf86116a310701b2755e5fb385 updated the model to handle the case where zuul_return is used to filter the child jobs when those jobs have soft dependencies. In short, a filtered job should no longer be counted as a dependency when its child job runs (as if the filtered job had not matched the change in the first place) which makes the behavior consistent with soft dependencies of jobs which don't match. However, it also changed the behavior for when a job fails. This seems to be a simple oversight in applying the new "skip_soft" pattern in too many places. When a job actually fails, we do not want its child jobs to run, regardless of whether they have a hard or soft dependency on the failing parent. In that case, we should always set them to 'skipped'. Otherwise they will never run and the item will sit in the queue indefinitely. Change-Id: Ic19a73d1b6e0fbe5510e71947930de4c46cc1280
4 lines
130 B
YAML
4 lines
130 B
YAML
fixes:
|
|
- Fixed a regression where changes with a failing job with soft
|
|
dependencies would remain in the queue indefinitely.
|