9c9a337a1e
When validating several ansible versions, the validate() method returns the output of the LAST `ansible --version` that has been executed. The reason is the 'result' variable was used both for the stdout and to keep track of a failure. I have found that due to my 2.7 ansible being broken somehow and validate was still happy since a later version was working all fine. Add a test to ensure validate() fails properly in such a case. Change-Id: Ib8bef996639e09f6355830c65f341d88f5cab8d8
50 lines
1.7 KiB
Python
50 lines
1.7 KiB
Python
# Copyright 2020 Antoine Musso
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import collections
|
|
import subprocess
|
|
from unittest import mock
|
|
|
|
from tests.base import BaseTestCase
|
|
from zuul.lib.ansible import AnsibleManager
|
|
|
|
|
|
class TestLibAnsibleManager(BaseTestCase):
|
|
|
|
@mock.patch('zuul.lib.ansible.AnsibleManager.load_ansible_config')
|
|
@mock.patch('zuul.lib.ansible.AnsibleManager.getAnsibleCommand')
|
|
def test_validate_remembers_failures(self, getAnsibleCommand, _):
|
|
|
|
okish = mock.Mock(
|
|
'subprocess.CompletedProcess',
|
|
returncode=0, stdout=b'Some valid ansible infos\n')
|
|
okish.returncode
|
|
|
|
am = AnsibleManager()
|
|
am._supported_versions = collections.OrderedDict([
|
|
('1.0', subprocess.CalledProcessError(1, 'fake failure')),
|
|
('2.8', okish),
|
|
])
|
|
|
|
with mock.patch('subprocess.run') as ansible:
|
|
ansible.side_effect = am._supported_versions.values()
|
|
self.assertFalse(
|
|
am.validate(),
|
|
'A valid ansible should not mask a previous failure')
|
|
self.assertEquals(
|
|
[mock.call('1.0', 'ansible'),
|
|
mock.call('2.8', 'ansible'),
|
|
],
|
|
getAnsibleCommand.mock_calls)
|