zuul/releasenotes/notes/change-cache-bugfix-bcf9cb5da3ec2392.yaml
James E. Blair e4f1b9b65e Fix infinite recursion in getRelatedChanges
It's possible to have a loop in change relationships (whether accidentally
or intentionally).  The current method of getting related changes in order
to prune the change cache does not handle that.

This reworks that method to be safe for recursion.

During development, it was observed that the set of relevant changes was
actually a mixture of cache keys (which are objects) and cache references
(which are string representations of the same).  This change also refactors
the collection of relevant cache keys into a method which can be tested on
its own to verify we get keys of a consistent type.

Change-Id: Ie76f9b19f10b053f5c72bdaf7be3efc445b53639
2021-10-13 10:42:07 -07:00

6 lines
141 B
YAML

---
fixes:
- |
A bug which prevented change cache cleanup (and therefore caused
ZooKeeper usage to grow without limits) was fixed.