zuul/web/src
Felix Edel c3e77b6d47
Use Modal to show config errors and fix scrolling
Since we introduced PF4 together with the Drawer component to show the
config errors, we are not able to scroll the page by using the keyboard.
So far, no workaround really did the trick and every one came with
another drawback in different areas.

So we decided to ditch the Drawer component and use a Modal as
replacement. This should still serve the use case as we have "something
popping up when clicking on the bell icon", but this something doesn't
break the layout and/or the scrolling behaviour.

Additionally this change removes the "height: 100%" CSS rule on the root
element. In combination with the removed drawer this should restore the
scrolling behaviour via keyboard without introducing any further
drawbacks like wrong tabbing or focus behaviour.

For additional background information on this topic, please refer to the
changes [1], [2] and [3]. There is also a PF4 issue on Github available
[4].

[1] https://review.opendev.org/#/c/743239/
[2] https://review.opendev.org/#/c/743917/
[3] https://review.opendev.org/#/c/742759/
[4] https://github.com/patternfly/patternfly-react/issues/4624

Change-Id: I45df9cabc96d2d7fb4ddebdf1c72d0dd8a3adfd2
2020-09-14 14:50:12 +02:00
..
actions Add user preferences dialog 2020-07-30 13:51:09 +01:00
containers Revert "Revert PF4 build page" 2020-09-14 14:47:49 +02:00
images PF4: Add new Zuul logo with text 2020-07-07 11:16:49 +02:00
pages Revert "Revert PF4 build page" 2020-09-14 14:47:49 +02:00
reducers Add user preferences dialog 2020-07-30 13:51:09 +01:00
App.jsx Use Modal to show config errors and fix scrolling 2020-09-14 14:50:12 +02:00
App.test.jsx Update to create-react-app 3.4.1 2020-05-21 10:55:29 -05:00
Misc.jsx PF4: Update buildset result page (new layout and styling) 2020-07-15 09:06:04 +02:00
api.js Update to create-react-app 3.4.1 2020-05-21 10:55:29 -05:00
index.css Use Modal to show config errors and fix scrolling 2020-09-14 14:50:12 +02:00
index.js Introduce Patternfly 4 2020-07-07 11:16:48 +02:00
pf4-migration.css Introduce Patternfly 4 2020-07-07 11:16:48 +02:00
registerServiceWorker.js Disable service workers by default 2019-02-05 17:23:24 +00:00
routes.js Revert "Revert PF4 build page" 2020-09-14 14:47:49 +02:00
store.js Return store object instead of a function 2019-06-17 16:26:12 +02:00