The Gatekeeper, or a project gating system
Go to file
James E. Blair da9df89591 Fix mutation while iterating over queues
When we process a pipeline, we iterate over every shared change
queue, then iterate over every item in each queue.  When the last
item in a queue is complete and removed from an independent
pipeline, the queue itself is also removed.  Since we iterate over
the list without making a copy first, we might then skip over the
next queue.  We didn't notice this because any time we change a
pipeline, we process it again immediately afterwords.  Nonetheless,
this could lead to starting jobs which we immediately cancel and
other inefficiencies.

What did make us take notice is that we accumulate the list of
changes in a pipeline and then use that to prune the change cache.
If we skip an item we would omit that change from the list of
relevant changes and delete it from the cache.  The timing for this
has to be just right on two schedulers, but it happened in OpenDev.

To correct this, make a copy of the queue before iterating.

It is not feasible to reasonably test this because of the fact that
we immediately run the pipeline again after changing it -- there is
no opportunity for the test framework to interrupt processing between
the two runs.

Change-Id: Iaf0bb998c069ad6e4f7c53ca5fb05bd9675410a0
2021-12-01 16:28:08 -08:00
doc Merge "Add `playbook_context` zuul variable" 2021-11-30 23:16:58 +00:00
etc Remove time database 2021-09-27 11:54:33 -07:00
playbooks Uncap concurrency in tests 2021-10-25 08:53:37 -07:00
releasenotes/notes Merge "Add `playbook_context` zuul variable" 2021-11-30 23:16:58 +00:00
tests Merge "Skip tests asserting on tenant reconfig results on multi scheduler" 2021-12-01 01:36:49 +00:00
tools Increase MySQL connection limit in tests 2021-11-24 13:30:28 -08:00
web web UI: Add a credentials renew modal 2021-11-23 12:43:17 +01:00
zuul Fix mutation while iterating over queues 2021-12-01 16:28:08 -08:00
.coveragerc Revert "Revert "Switch to stestr"" 2018-05-17 08:33:40 -07:00
.dockerignore Add web/node_modules to dockerignore 2019-01-27 11:23:45 +01:00
.gitignore Use ZooKeeper TLS in tests 2021-03-08 06:49:57 -08:00
.gitreview OpenDev Migration Patch 2019-04-19 19:25:28 +00:00
.mailmap Fix pep8 E127 violations 2012-09-26 14:23:10 +00:00
.stestr.conf Revert "Revert "Switch to stestr"" 2018-05-17 08:33:40 -07:00
.zuul.yaml Merge "Add nonvoting multischeduler job" 2021-12-01 02:49:04 +00:00
COPYING Update README and add GPL license 2018-03-19 09:25:52 -07:00
Dockerfile Rely on bullseye image for skopeo in container image 2021-10-27 14:39:45 -07:00
LICENSE Initial commit. 2012-05-29 14:49:32 -07:00
MANIFEST.in Optimize canMerge using graphql 2020-02-28 09:43:56 +01:00
README.rst Support nodes setting 'auto' python-path 2019-09-19 10:28:53 +10:00
TESTING.rst Docs: fix stestr run example 2020-01-21 10:36:07 +01:00
bindep.txt Drop ambient capabilities when running bwrap 2021-11-01 19:13:37 +01:00
reno.yaml Add reno configuration settings 2020-07-22 08:45:46 -07:00
requirements.txt Pin github3.py to <3.0.0 2021-11-03 16:43:12 +01:00
setup.cfg Merge "Include database requirements by default" 2021-03-09 23:24:34 +00:00
setup.py Partial sync with OpenStack requirements. 2013-09-25 15:30:37 -07:00
test-requirements.txt github: more complete mocking for app setup 2021-09-23 19:53:48 +10:00
tox.ini Allow running tests with multiple schedulers 2021-11-24 13:30:28 -08:00

README.rst

Zuul

Zuul is a project gating system.

The latest documentation for Zuul v3 is published at: https://zuul-ci.org/docs/zuul/

If you are looking for the Edge routing service named Zuul that is related to Netflix, it can be found here: https://github.com/Netflix/zuul

If you are looking for the Javascript testing tool named Zuul, it can be found here: https://github.com/defunctzombie/zuul

Getting Help

There are two Zuul-related mailing lists:

zuul-announce

A low-traffic announcement-only list to which every Zuul operator or power-user should subscribe.

zuul-discuss

General discussion about Zuul, including questions about how to use it, and future development.

You will also find Zuul developers in the #zuul channel on Freenode IRC.

Contributing

To browse the latest code, see: https://opendev.org/zuul/zuul To clone the latest code, use git clone https://opendev.org/zuul/zuul

Bugs are handled at: https://storyboard.openstack.org/#!/project/zuul/zuul

Suspected security vulnerabilities are most appreciated if first reported privately following any of the supported mechanisms described at https://zuul-ci.org/docs/zuul/user/vulnerabilities.html

Code reviews are handled by gerrit at https://review.opendev.org

After creating a Gerrit account, use git review to submit patches. Example:

# Do your commits
$ git review
# Enter your username if prompted

Join #zuul on Freenode to discuss development or usage.

License

Zuul is free software. Most of Zuul is licensed under the Apache License, version 2.0. Some parts of Zuul are licensed under the General Public License, version 3.0. Please see the license headers at the tops of individual source files.

Python Version Support

Zuul requires Python 3. It does not support Python 2.

Since Zuul uses Ansible to drive CI jobs, Zuul can run tests anywhere Ansible can, including Python 2 environments.