zuul/zuul/web/logutil.py
James E. Blair 482338f70c Identify cherrypy requests in logs
This adds a unique ID to every cherrypy request and adds it to the
all of the log lines in the web server.

Some requests produce multiple log entries, and this will allow us
to associate them with each other as well as the cherrpy access log
which is emitted at the end of the request.

To add this to cherrypy's request logging, we subclass the cherrypy
LogManager class and add accessor methods so that whenever the
superclass requests a logger, it gets our annotated logger.

See: https://github.com/cherrypy/cherrypy/blob/main/cherrypy/_cplogging.py

There is an underscore in that module name, but several parts of the
cherrpy documentation suggest importing underscore modules for the
purpose of extending cherrpy.

On the ZuulApi class, we add a similar accessor method for obtaining
the annotated logger for any request.

The two log streaming classes initialize their log attribute in the
constructor since their instances are dedicated to a single request.

The remaining classes retain the class-level logger since they operate
outside of the request context.

Change-Id: I66af717ab34fa4ad3492a01badb25e3865133104
2022-02-02 16:16:27 -08:00

48 lines
1.5 KiB
Python

# Copyright 2022 Acme Gating, LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
# implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import uuid
from zuul.lib.logutil import get_annotated_logger
import cherrypy
from cherrypy._cplogging import LogManager
class ZuulCherrypyLogManager(LogManager):
@property
def access_log(self):
request = cherrypy.serving.request
if not hasattr(request, 'zuul_request_id'):
request.zuul_request_id = uuid.uuid4().hex
return get_annotated_logger(self._access_log, None,
request=request.zuul_request_id)
@access_log.setter
def access_log(self, attr):
self._access_log = attr
@property
def error_log(self):
request = cherrypy.serving.request
if not hasattr(request, 'zuul_request_id'):
request.zuul_request_id = uuid.uuid4().hex
return get_annotated_logger(self._error_log, None,
request=request.zuul_request_id)
@error_log.setter
def error_log(self, attr):
self._error_log = attr