airship
/
airshipctl
Code Issues Proposed changes

Suppress the "go command not found" message 

When a make target is run, make will try to find the GOBIN using a go
command. If go isn't installed, the user sees the message:

  /bin/bash: go: command not found

This can be confusing, especially when a docker-image target is being
run. This change suppresses that message.

Change-Id: Ie27a4a82a3692db60445601febf3bd51f956d575
This commit is contained in:
Ian Howell 2021-01-20 09:38:31 -06:00
parent 41d353444f
commit edea4a2a36
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Makefile
View File

@ -6,10 +6,10 @@ GIT_MODULE ?= opendev.org/airship/airshipctl/pkg/version
GO_FLAGS := -ldflags '-extldflags "-static"' -tags=netgo -trimpath
GO_FLAGS += -ldflags "-X ${GIT_MODULE}.gitVersion=${GIT_VERSION}"
# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
ifeq (,$(shell go env GOBIN))
GOBIN = $(shell go env GOPATH)/bin
ifeq (,$(shell go env GOBIN 2> /dev/null))
GOBIN = $(shell go env GOPATH 2> /dev/null)/bin
else
GOBIN = $(shell go env GOBIN)
GOBIN = $(shell go env GOBIN 2> /dev/null)
endif
BINDIR := bin