Update golanci version, because we need to add asciicheck linter.
Because of update appears some gosec issues.
Closes: #312
Change-Id: I54759e7301f0fb9dcb60eb7d9a2d1e9cebfaf359
Issues raised after enabling golint as part of golangci-lint
* error var ToDiscoveryError should have name of the
form ErrFoo (golint)
* error strings should not be capitalized or end with punctuation
or a newline (golint)
Issues not raised by golint embedded within golangci-lint
* comment on exported function <funcname> should be
of the form "<funcname> ..."
So kept the golint standalone tool also in Makefile
Change-Id: I7f2ce66d1e757bc24c042fc212226cecea297f27
The `interfacer` linter has self-deprecated due to the following [0]:
A tool that suggests interfaces is prone to bad suggestions, so its
usefulness in real code is limited
This commit removes the deprecated linter.
[0]: https://github.com/mvdan/interfacer#interfacer
Change-Id: I076c8afb6495292769c041bf15b5294965a0bce9
* added license templates for go, bash & yaml in tools dir
* added a script that will add license information for all
missing files. Type: go, yaml, yml, sh
* skip adding license for all files within testdata
* Syntax:
> ./tools/add_license.sh
* Skip license for manifests folder
* Added one extra line after licene for yaml files
* Added License after Hashbang for bash.
* Add an extra line after hashbang and before license
* Updated the go template to use multiline comments
New Files:
1. tools/add_license.sh
2. tools/license_go.txt
3. tools/license_yaml.txt
4. tools/license_bash.txt
Change-Id: Ia4da5b261e7cd518d446896b72c810421877472a
Realtes-To:#147
This change causes the linter to be a bit more complainy. The hope is
that this will cut down on some of the more pedantic issues being caught
in code reviews, and thus reduce the overall time a change spends in the
review process.
This change includes various changes to the codebase to bring it up to
the new standards.
Change-Id: I570d304bca5554404354f972d8a2743279a0171b
This introduces two new interfaces to airshipctl:
* Bundle: represents a Kustomize rendered
collection of your documents that allows you to
iterate over or filter the documents in the bundle.
* Document: a thin wrapper around a rendered
document.
This commit also includes a proposal for a way to
represent YAML test fixtures as testdatafs.go
and a new testdata subfolder within the document
pkg.
Change-Id: I4282b27977617552c25c5ae2c3b7da44e67dd014
This adds the .golangci.example.yaml, allowing for more precise control
over how linting is done.
This configuration is highly opinionated and is subject to change.
Change-Id: Ida13bf0dca12e152b75427f5060ad4931e426c72