airship
/
armada
Code Issues Proposed changes

Add warnings for post upgrade actions 

Armada does not perform post upgrade actions. This change adds a warning
to the documentation, comments, and output.

Change-Id: I4d37406e13a44759861ea179d06b26831efe2ac8
This commit is contained in:
Drew Walters 2018-11-09 22:05:05 +00:00
parent 94df4daeb6
commit 4b76fda6b4
3 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
armada/handlers/chart_deploy.py
View File

@ -132,6 +132,8 @@ class ChartDeploy(object):
pre_actions = upgrade_pre pre_actions = upgrade_pre
if not self.disable_update_post and upgrade_post: if not self.disable_update_post and upgrade_post:
LOG.warning('Post upgrade actions are ignored by Armada'
'and will not affect deployment.')
post_actions = upgrade_post post_actions = upgrade_post
try: try:

2
armada/schemas/armada-chart-schema.yaml
View File

@ -146,6 +146,8 @@ data:
$ref: '#/definitions/hook_action' $ref: '#/definitions/hook_action'
create: create:
$ref: '#/definitions/hook_action' $ref: '#/definitions/hook_action'
# TODO(drewwalters96): Armada ignores post-update actions. Remove them
# in future schemas.
post: post:
type: object type: object
additionalProperties: false additionalProperties: false

19
doc/source/operations/guide-build-armada-yaml.rst
View File

@ -208,17 +208,14 @@ Test options to pass through directly to helm.
next upgrade. next upgrade.
Upgrade, Install - Pre or Post Upgrade - Pre
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^
+-------------+----------+---------------------------------------------------------------+ +-------------+----------+---------------------------------------------------------------+
| keyword | type | action | | keyword | type | action |
+=============+==========+===============================================================+ +=============+==========+===============================================================+
| pre | object | actions prior to updating/installing chart | | pre | object | actions performed prior to updating a release |
+-------------+----------+---------------------------------------------------------------+ +-------------+----------+---------------------------------------------------------------+
| post | object | actions post updating/installing chart |
+-------------+----------+---------------------------------------------------------------+
Upgrade - Actions Upgrade - Actions
^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
@ -226,17 +223,11 @@ Upgrade - Actions
+-------------+----------+---------------------------------------------------------------+ +-------------+----------+---------------------------------------------------------------+
| keyword | type | action | | keyword | type | action |
+=============+==========+===============================================================+ +=============+==========+===============================================================+
| update | object | updates daemonsets in pre update actions | | update | object | update daemonsets in pre-upgrade update actions |
+-------------+----------+---------------------------------------------------------------+ +-------------+----------+---------------------------------------------------------------+
| delete | sequence | delete jobs in pre delete actions and child pods | | delete | sequence | delete jobs and pods in pre-upgrade delete actions |
+-------------+----------+---------------------------------------------------------------+ +-------------+----------+---------------------------------------------------------------+
.. note::
Update actions are performed in the pre/post sections of upgrade
Upgrade - Actions - Update/Delete Upgrade - Actions - Update/Delete
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^