airship/specs
Code Issues Proposed changes

Update patch set 13

Browse Source 
Patch Set 13:

(4 comments)

Will continue to review and provide more comments and feedback

Patch-set: 13
Label: Verified=0
This commit is contained in:
Gerrit User 30260 2019-06-12 16:57:48 +00:00 committed by Gerrit Code Review
parent baf9b563e1
commit dfad7b5ced
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a Normal file
View File

@ -0,0 +1,90 @@
{
"comments": [
{
"key": {
"uuid": "9fb8cfa7_28d56744",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 47,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "it is not clear what will happen to Shipyard. will it be replaced by *airshipctl* as a plugin towards argo workflows or part of the native command structure? \nisn\u0027t Drydock impacted? Is it worth mentioning all impacted Airship 1.0 components or is it out of scope for the spec document?",
"range": {
"startLine": 47,
"startChar": 48,
"endLine": 47,
"endChar": 54
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_73d91020",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 135,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "lower case \u0027a\u0027",
"range": {
"startLine": 135,
"startChar": 1,
"endLine": 135,
"endChar": 2
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_d3f79c8a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 139,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "This statement is redundant to the one made in line 135 or should be merged to deliver a single message",
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_d3255c0a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 141,
"author": {
"id": 30260
},
"writtenOn": "2019-06-12T16:57:48Z",
"side": 1,
"message": "This statement makes sense after the explanation of how the flag is set.",
"range": {
"startLine": 141,
"startChar": 0,
"endLine": 141,
"endChar": 59
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}