airship/spyglass
Code Issues Proposed changes

Add tests into Zuul config and Makefile

Browse Source 
Spyglass recently had a change merged ([0]) that included tests. Now
that there are tests in Spyglass, gates can be enabled in Zuul and for
the Makefile.

Change-Id: I2da39f3601d4263aa674019205721d5f0ac5f227
This commit is contained in:
Ian Pittwood 2019-06-06 12:20:07 -05:00
parent fc88cc34ef
commit b8f4cbc3af
3 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.zuul.yaml
View File

@ -12,6 +12,9 @@
- project: - project:
templates: templates:
- docs-on-readthedocs - docs-on-readthedocs
- openstack-python36-jobs
- openstack-python37-jobs
- openstack-cover-jobs
vars: vars:
rtd_webhook_id: '86525' rtd_webhook_id: '86525'
rtd_project_name: 'airship-spyglass' rtd_project_name: 'airship-spyglass'

8
Makefile
View File

@ -45,11 +45,17 @@ run_images: run_spyglass
run_spyglass: build_spyglass run_spyglass: build_spyglass
tools/spyglass.sh --help tools/spyglass.sh --help
.PHONY: tests
tests: run_tests
.PHONY: security .PHONY: security
security: security:
tox -e bandit tox -e bandit
# TODO (alexanderhughes) add tox -e py36 tests once implemented in Spyglass # Run all unit tests under spyglass
.PHONY: run_tests
run_tests:
tox -e py36
# Perform Linting # Perform Linting
.PHONY: lint .PHONY: lint

3
tests/unit/validators/test_json_validator.py
View File

@ -56,7 +56,8 @@ def test_document_schema_matching():
for pair in validator.document_schema_pairs: for pair in validator.document_schema_pairs:
no_path_pairs.append( no_path_pairs.append(
(os.path.split(pair[0])[1], os.path.split(pair[1])[1])) (os.path.split(pair[0])[1], os.path.split(pair[1])[1]))
assert no_path_pairs == expected_pairs for pair in expected_pairs:
assert pair in no_path_pairs
def test_document_schema_matching_no_files(): def test_document_schema_matching_no_files():