Update patch set 1
Patch Set 1: Code-Review-1 (2 comments) I will give this patch a test. A few nits in the meantime: Patch-set: 1 Reviewer: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
eb267a830a
commit
2c55c0466d
44
7ef061f60f2ddb06d94eaf741f9526e4cdae31a9
Normal file
44
7ef061f60f2ddb06d94eaf741f9526e4cdae31a9
Normal file
@ -0,0 +1,44 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_a36c3d6c",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 11,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:17:06Z",
|
||||
"side": 1,
|
||||
"message": "We should not have any AT\u0026T specific URLs in upstream repositories.\n\nPlease swap them with generic replacements if you intend to provide an example.",
|
||||
"range": {
|
||||
"startLine": 10,
|
||||
"startChar": 0,
|
||||
"endLine": 11,
|
||||
"endChar": 67
|
||||
},
|
||||
"revId": "7ef061f60f2ddb06d94eaf741f9526e4cdae31a9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_238eed24",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 13,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:17:06Z",
|
||||
"side": 1,
|
||||
"message": "Why does this change depend on a change to the README file? It seems as though it could be submitted independently.\n\nAdditionally, if this change depends on other changes, it should have a\n\n Depends-On tag.",
|
||||
"revId": "7ef061f60f2ddb06d94eaf741f9526e4cdae31a9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user