opendev/base-jobs
Code Issues Proposed changes

Remove temporary workaround for virtualenv install behavior

Browse Source 
Virtualenv 20.0.0 introduced new installation behavior where common libs
to all virtualenvs were shared in the user's homedir. Unforatunately
this breaks if you make virtualenvs as root and expect other users to
use them because /root is not accessible to the regular user.

We worked around this with targeted chmodding, but thankfully upstream
virtualenv changed the behavior to do copies by default. You have to opt
into the other behavior explicitly. At this point our images should have
new enough virtualenv that this is a non issue for us.

This also has the added benefit of running less code prior to starting
the zuul console log daemon which will reduce instances of the annoying
"console log daemon not yet running" log messages.

Change-Id: I0c5d68b81de9d3d079739f13977e7237577024b9
This commit is contained in:
Clark Boylan 2020-03-02 11:45:04 -08:00
parent e88b96b5fe
commit 9b235be0c0
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
playbooks/base/pre.yaml
View File

@ -6,18 +6,6 @@
- hosts: all - hosts: all
pre_tasks: pre_tasks:
- name: Temporary fix for /root for virtualenv 20
command: chmod o+rx /root
become: yes
tags:
- skip_ansible_lint
failed_when: false
- name: Temporary fix for /root/local for virtualenv 20
command: chmod -R o+rX /root/.local
become: yes
tags:
- skip_ansible_lint
failed_when: false
# NOTE(pabelanger): Until we hit the validate-host role, we have a minimal # NOTE(pabelanger): Until we hit the validate-host role, we have a minimal
# set of ansible variables collected by zuul-executor. This doesn't include # set of ansible variables collected by zuul-executor. This doesn't include
# network variables (ansible_default_ipv4 / ansible_default_ipv6) so gather # network variables (ansible_default_ipv4 / ansible_default_ipv6) so gather