Simplify 1708704's query
The previous query for 1708704 was causing e-r to OOM and resulting in a lack of graph data. This is beacuse tripleo's logstash.txt file is not getting parsed properly and ends up with the entire file as the single event. Then e-r downloads all those file copies and fills its memory and breaks. We can work around this by only looking in job-output.txt files for this bug. Then when tripleo's fix has flushed the bad events out (10 days after fix merges) we can revert this change. Change-Id: Id619f90ffe84b3d4de334ea4b17026b9b3239d33
|3 weeks ago|
|doc||1 year ago|
|elastic_recheck||3 weeks ago|
|queries||3 weeks ago|
|tools||10 months ago|
|web||3 weeks ago|
|.coveragerc||4 years ago|
|.gitignore||3 years ago|
|.gitreview||10 months ago|
|.testr.conf||6 years ago|
|.zuul.yaml||1 year ago|
|CONTRIBUTING.rst||4 months ago|
|LICENSE||6 years ago|
|MANIFEST.in||6 years ago|
|README.rst||6 months ago|
|babel.cfg||6 years ago|
|bindep.txt||2 years ago|
|elasticRecheck.conf.sample||10 months ago|
|recheckwatchbot.yaml||3 years ago|
|requirements.txt||4 months ago|
|setup.cfg||6 months ago|
|setup.py||4 years ago|
|test-requirements.txt||1 year ago|
|tox.ini||4 months ago|
|web_server.py||1 year ago|
"Use ElasticSearch to classify OpenStack gate failures"
Identifying the specific bug that is causing a transient error in the gate is difficult. Just identifying which tempest test failed is not enough because a single tempest test can fail due to any number of underlying bugs. If we can find a fingerprint for a specific bug using logs, then we can use ElasticSearch to automatically detect any occurrences of the bug.
Using these fingerprints elastic-recheck can:
All queries are stored in separate yaml files in a queries directory at the top of the elastic-recheck code base. The format of these files is ######.yaml (where ###### is the launchpad bug number), the yaml should have a
query keyword which is the query text for elastic search.
Guidelines for good queries:
tags:"screen-n-net.txt") is typically better than a console one (
tags:"console"), as that's matching a deep failure versus a surface symptom.
tags:"screen-n-cpu.txt"will query in
tags:"console"filter is also used to query in
console.htmlas well as tempest and devstack logs.
Avoid the use of wildcards in queries since they can put an undue burden on the query engine. A common case where wildcards are used and shouldn't be are in querying against a specific set of
build_name fields, e.g.
gate-nova-python27. Rather than use
build_name:gate-nova-python*, list the jobs with an
OR. For example:
(build_name:"gate-nova-python26" OR build_name:"gate-nova-python27")
When adding queries you can optionally suppress the creation of graphs and notifications by adding
suppress-graph: true or
suppress-notification: true to the yaml file. These can be used to make sure expected failures don't show up on the unclassified page.
If the only signature available is overly broad and adding additional logging can't reasonably make a good signature, you can also filter the results of a query based on the test_ids that failed for the run being checked. This can be done by adding a
test_ids keyword to the query file and then a list of the test_ids to verify failed. The test_id also should exclude any attrs, this is the list of attrs appended to the test_id between ''. For example, 'smoke', 'slow', any service tags, etc. This is how subunit-trace prints the test ids by default if you're using it. If any of the listed test_ids match as failing for the run being checked with the query it will return a match. Since filtering leverages subunit2sql which only receives tempest test results from the gate pipeline, this technique will only work on tempest or grenade jobs in the gate queue. For more information about this refer to the infra subunit2sql documentation For example, if your query yaml file looked like:
query: >- message:"ExceptionA" test_ids: - tempest.api.compute.servers.test_servers.test_update_server_name - tempest.api.compute.servers.test_servers_negative.test_server_set_empty_name
this will only match the bug if the logstash query had a hit for the run and either test_update_server_name or test_server_set_empty name failed during the run.
In order to support rapidly added queries, it's considered socially acceptable to approve changes that only add 1 new bug query, and to even self approve those changes by core reviewers.
Most transient bugs seen in gate are not bugs in tempest associated with a specific tempest test failure, but rather some sort of issue further down the stack that can cause many tempest tests to fail.
Tag your commit with a
Related-Bug tag in the footer, or add a comment to the bug with the query you identified and a link to the logstash URL for that query search.
Putting the logstash query link in the bug report is also valuable in the case of rare failures that fall outside the window of how far back log results are stored. In such cases the bug might be marked as Incomplete and the e-r query could be removed, only for the failure to re-surface later. If a link to the query is in the bug report someone can easily track when it started showing up again.
elastic-recheck/queries/BUGNUMBER.yaml(All queries can be found on git.openstack.org) and push the patch up for review.
You can also help classify Unclassified failed jobs, which is an aggregation of all failed voting gate jobs that don't currently have elastic-recheck fingerprints.
Old queries which are no longer hitting in logstash and are associated with fixed or incomplete bugs are routinely deleted. This is to keep the load on the elastic-search engine as low as possible when checking a job failure. If a bug marked as Incomplete does show up again, the bug should be re-opened with a link to the failure and the e-r query should be restored.
Queries that have "suppress-graph: true" in them generally should not be removed since we basically want to keep those around, they are persistent infra issues and are not going away.
$ tox -e venv -- elastic-recheck-cleanup -h ... usage: elastic-recheck-cleanup [-h] [--bug <bug>] [--dry-run] [-v] Remove old queries where the affected projects list the bug status as one of: Fix Committed, Fix Released optional arguments: -h, --help show this help message and exit --bug <bug> Specific bug number/id to clean. Returns an exit code of 1 if no query is found for the bug. --dry-run Print out old queries that would be removed but do not actually remove them. -v Print verbose information during execution.
You may want to run with the
--dry-run option first and sanity check the removed queries before committing them.
Commit the changes and push them up for review:
$ git commit -a -m "Remove old queries: `date +%F`" $ git review -t rm-old-queries
Sometimes bugs are still New/Confirmed/Triaged/In Progress but have not had any hits in over 10 days. Those bugs should be re-assessed to see if they are now actually fixed or incomplete/invalid, marked as such and then remove the related query.
You can execute an individual query locally and analyze the search results:
$ elastic-recheck-query queries/1331274.yaml total hits: 133 build_status 100% FAILURE build_name 48% check-grenade-dsvm 15% check-grenade-dsvm-partial-ncpu 13% gate-grenade-dsvm 9% check-grenade-dsvm-icehouse 9% check-grenade-dsvm-partial-ncpu-icehouse build_branch 95% master 4% stable/icehouse