gerrit/polygerrit-ui/app/elements/diff/gr-diff-comment-thread/gr-diff-comment-thread_test.html

<!DOCTYPE html>
<!--
@license
Copyright (C) 2015 The Android Open Source Project

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->

<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
<title>gr-diff-comment-thread</title>

<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
<script src="../../../bower_components/web-component-tester/browser.js"></script>
<link rel="import" href="../../../test/common-test-setup.html"/>
<script src="../../../scripts/util.js"></script>

<link rel="import" href="gr-diff-comment-thread.html">

<script>void(0);</script>

<test-fixture id="basic">
  <template>
    <gr-diff-comment-thread></gr-diff-comment-thread>
  </template>
</test-fixture>

<test-fixture id="withComment">
  <template>
    <gr-diff-comment-thread></gr-diff-comment-thread>
  </template>
</test-fixture>

<script>
  suite('gr-diff-comment-thread tests', () => {
    let element;
    let sandbox;

    setup(() => {
      sandbox = sinon.sandbox.create();
      stub('gr-rest-api-interface', {
        getLoggedIn() { return Promise.resolve(false); },
      });
      sandbox = sinon.sandbox.create();
      element = fixture('basic');
    });

    teardown(() => {
      sandbox.restore();
    });

    test('comments are sorted correctly', () => {
      const comments = [
        {
          message: 'i like you, too',
          in_reply_to: 'sallys_confession',
          __date: new Date('2015-12-25'),
        }, {
          id: 'sallys_confession',
          message: 'i like you, jack',
          updated: '2015-12-24 15:00:20.396000000',
        }, {
          id: 'sally_to_dr_finklestein',
          message: 'i’m running away',
          updated: '2015-10-31 09:00:20.396000000',
        }, {
          id: 'sallys_defiance',
          in_reply_to: 'sally_to_dr_finklestein',
          message: 'i will poison you so i can get away',
          updated: '2015-10-31 15:00:20.396000000',
        }, {
          id: 'dr_finklesteins_response',
          in_reply_to: 'sally_to_dr_finklestein',
          message: 'no i will pull a thread and your arm will fall off',
          updated: '2015-10-31 11:00:20.396000000',
        }, {
          id: 'sallys_mission',
          message: 'i have to find santa',
          updated: '2015-12-24 15:00:20.396000000',
        },
      ];
      const results = element._sortedComments(comments);
      assert.deepEqual(results, [
        {
          id: 'sally_to_dr_finklestein',
          message: 'i’m running away',
          updated: '2015-10-31 09:00:20.396000000',
        }, {
          id: 'dr_finklesteins_response',
          in_reply_to: 'sally_to_dr_finklestein',
          message: 'no i will pull a thread and your arm will fall off',
          updated: '2015-10-31 11:00:20.396000000',
        }, {
          id: 'sallys_defiance',
          in_reply_to: 'sally_to_dr_finklestein',
          message: 'i will poison you so i can get away',
          updated: '2015-10-31 15:00:20.396000000',
        }, {
          id: 'sallys_confession',
          message: 'i like you, jack',
          updated: '2015-12-24 15:00:20.396000000',
        }, {
          id: 'sallys_mission',
          message: 'i have to find santa',
          updated: '2015-12-24 15:00:20.396000000',
        }, {
          message: 'i like you, too',
          in_reply_to: 'sallys_confession',
          __date: new Date('2015-12-25'),
        },
      ]);
    });

    test('addOrEditDraft w/ edit draft', () => {
      element.comments = [{
        id: 'jacks_reply',
        message: 'i like you, too',
        in_reply_to: 'sallys_confession',
        updated: '2015-12-25 15:00:20.396000000',
        __draft: true,
      }];
      const commentElStub = sandbox.stub(element, '_commentElWithDraftID',
          () => { return {}; });
      const addDraftStub = sandbox.stub(element, 'addDraft');

      element.addOrEditDraft(123);

      assert.isTrue(commentElStub.called);
      assert.isFalse(addDraftStub.called);
    });

    test('addOrEditDraft w/o edit draft', () => {
      element.comments = [];
      const commentElStub = sandbox.stub(element, '_commentElWithDraftID',
          () => { return {}; });
      const addDraftStub = sandbox.stub(element, 'addDraft');

      element.addOrEditDraft(123);

      assert.isFalse(commentElStub.called);
      assert.isTrue(addDraftStub.called);
    });

    test('_hideActions', () => {
      let showActions = true;
      const lastComment = {};
      assert.equal(element._hideActions(showActions, lastComment), false);
      showActions = false;
      assert.equal(element._hideActions(showActions, lastComment), true);
      showActions = true;
      lastComment.__draft = true;
      assert.equal(element._hideActions(showActions, lastComment), true);
    });

    test('setting project name loads the project config', done => {
      const projectName = 'foo/bar/baz';
      const getProjectStub = sandbox.stub(element.$.restAPI, 'getProjectConfig')
          .returns(Promise.resolve({}));
      element.projectName = projectName;
      flush(() => {
        assert.isTrue(getProjectStub.calledWithExactly(projectName));
        done();
      });
    });

    test('optionally show file path', () => {
      // Path info doesn't exist when showFilePath is false. Because it's in a
      // dom-if it is not yet in the dom.
      assert.isNotOk(element.$$('.pathInfo'));

      sandbox.stub(Gerrit.Nav, 'getUrlForDiffById');
      element.changeNum = 123;
      element.projectName = 'test project';
      element.path = 'path/to/file';
      element.patchNum = 3;
      element.lineNum = 5;
      element.showFilePath = true;
      flushAsynchronousOperations();
      assert.isOk(element.$$('.pathInfo'));
      assert.notEqual(getComputedStyle(element.$$('.pathInfo')).display,
          'none');
      assert.isTrue(Gerrit.Nav.getUrlForDiffById.lastCall.calledWithExactly(
          element.changeNum, element.projectName, element.path,
          element.patchNum, null, element.lineNum));
    });

    test('_computeDisplayPath', () => {
      const path = 'path/to/file';
      assert.equal(element._computeDisplayPath(path), 'path/to/file');

      element.lineNum = 5;
      assert.equal(element._computeDisplayPath(path), 'path/to/file#5');
    });
  });

  suite('comment action tests', () => {
    let element;
    let sandbox;

    setup(() => {
      sandbox = sinon.sandbox.create();
      stub('gr-rest-api-interface', {
        getLoggedIn() { return Promise.resolve(false); },
        saveDiffDraft() {
          return Promise.resolve({
            ok: true,
            text() {
              return Promise.resolve(')]}\'\n' +
                  JSON.stringify({
                    id: '7afa4931_de3d65bd',
                    path: '/path/to/file.txt',
                    line: 5,
                    in_reply_to: 'baf0414d_60047215',
                    updated: '2015-12-21 02:01:10.850000000',
                    message: 'Done',
                  }));
            },
          });
        },
        deleteDiffDraft() { return Promise.resolve({ok: true}); },
      });
      element = fixture('withComment');
      element.comments = [{
        author: {
          name: 'Mr. Peanutbutter',
          email: 'tenn1sballchaser@aol.com',
        },
        id: 'baf0414d_60047215',
        line: 5,
        message: 'is this a crossover episode!?',
        updated: '2015-12-08 19:48:33.843000000',
        path: '/path/to/file.txt',
      }];
      flushAsynchronousOperations();
    });

    teardown(() => {
      sandbox.restore();
    });

    test('reply', () => {
      const commentEl = element.$$('gr-diff-comment');
      const reportStub = sandbox.stub(element.$.reporting,
          'recordDraftInteraction');
      assert.ok(commentEl);

      const replyBtn = element.$.replyBtn;
      MockInteractions.tap(replyBtn);
      flushAsynchronousOperations();

      const drafts = element._orderedComments.filter(c => {
        return c.__draft == true;
      });
      assert.equal(drafts.length, 1);
      assert.notOk(drafts[0].message, 'message should be empty');
      assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
      assert.isTrue(reportStub.calledOnce);
    });

    test('quote reply', () => {
      const commentEl = element.$$('gr-diff-comment');
      const reportStub = sandbox.stub(element.$.reporting,
          'recordDraftInteraction');
      assert.ok(commentEl);

      const quoteBtn = element.$.quoteBtn;
      MockInteractions.tap(quoteBtn);
      flushAsynchronousOperations();

      const drafts = element._orderedComments.filter(c => {
        return c.__draft == true;
      });
      assert.equal(drafts.length, 1);
      assert.equal(drafts[0].message, '> is this a crossover episode!?\n\n');
      assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
      assert.isTrue(reportStub.calledOnce);
    });

    test('quote reply multiline', () => {
      const reportStub = sandbox.stub(element.$.reporting,
          'recordDraftInteraction');
      element.comments = [{
        author: {
          name: 'Mr. Peanutbutter',
          email: 'tenn1sballchaser@aol.com',
        },
        id: 'baf0414d_60047215',
        line: 5,
        message: 'is this a crossover episode!?\nIt might be!',
        updated: '2015-12-08 19:48:33.843000000',
      }];
      flushAsynchronousOperations();

      const commentEl = element.$$('gr-diff-comment');
      assert.ok(commentEl);

      const quoteBtn = element.$.quoteBtn;
      MockInteractions.tap(quoteBtn);
      flushAsynchronousOperations();

      const drafts = element._orderedComments.filter(c => {
        return c.__draft == true;
      });
      assert.equal(drafts.length, 1);
      assert.equal(drafts[0].message,
          '> is this a crossover episode!?\n> It might be!\n\n');
      assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
      assert.isTrue(reportStub.calledOnce);
    });

    test('ack', done => {
      const reportStub = sandbox.stub(element.$.reporting,
          'recordDraftInteraction');
      element.changeNum = '42';
      element.patchNum = '1';

      const commentEl = element.$$('gr-diff-comment');
      assert.ok(commentEl);

      const ackBtn = element.$.ackBtn;
      MockInteractions.tap(ackBtn);
      flush(() => {
        const drafts = element.comments.filter(c => {
          return c.__draft == true;
        });
        assert.equal(drafts.length, 1);
        assert.equal(drafts[0].message, 'Ack');
        assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
        assert.equal(drafts[0].unresolved, false);
        assert.isTrue(reportStub.calledOnce);
        done();
      });
    });

    test('done', done => {
      const reportStub = sandbox.stub(element.$.reporting,
          'recordDraftInteraction');
      element.changeNum = '42';
      element.patchNum = '1';
      const commentEl = element.$$('gr-diff-comment');
      assert.ok(commentEl);

      const doneBtn = element.$.doneBtn;
      MockInteractions.tap(doneBtn);
      flush(() => {
        const drafts = element.comments.filter(c => {
          return c.__draft == true;
        });
        assert.equal(drafts.length, 1);
        assert.equal(drafts[0].message, 'Done');
        assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
        assert.isFalse(drafts[0].unresolved);
        assert.isTrue(reportStub.calledOnce);
        done();
      });
    });

    test('save', done => {
      element.changeNum = '42';
      element.patchNum = '1';
      element.path = '/path/to/file.txt';
      const commentEl = element.$$('gr-diff-comment');
      assert.ok(commentEl);

      const saveOrDiscardStub = sandbox.stub();
      element.addEventListener('thread-changed', saveOrDiscardStub);
      element.$$('gr-diff-comment')._fireSave();

      flush(() => {
        assert.isTrue(saveOrDiscardStub.called);
        assert.equal(saveOrDiscardStub.lastCall.args[0].detail.rootId,
            'baf0414d_60047215');
        assert.equal(element.rootId, 'baf0414d_60047215');
        assert.equal(saveOrDiscardStub.lastCall.args[0].detail.path,
            '/path/to/file.txt');
        done();
      });
    });

    test('please fix', done => {
      element.changeNum = '42';
      element.patchNum = '1';
      const commentEl = element.$$('gr-diff-comment');
      assert.ok(commentEl);
      commentEl.addEventListener('create-fix-comment', () => {
        const drafts = element._orderedComments.filter(c => {
          return c.__draft == true;
        });
        assert.equal(drafts.length, 1);
        assert.equal(
            drafts[0].message, '> is this a crossover episode!?\n\nPlease Fix');
        assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
        assert.isTrue(drafts[0].unresolved);
        done();
      });
      commentEl.fire('create-fix-comment', {comment: commentEl.comment},
          {bubbles: false});
    });

    test('discard', done => {
      element.changeNum = '42';
      element.patchNum = '1';
      element.path = '/path/to/file.txt';
      element.push('comments', element._newReply(
          element.comments[0].id,
          element.comments[0].line,
          element.comments[0].path,
          'it’s pronouced jiff, not giff'));
      flushAsynchronousOperations();

      const saveOrDiscardStub = sandbox.stub();
      element.addEventListener('thread-changed', saveOrDiscardStub);
      const draftEl =
          Polymer.dom(element.root).querySelectorAll('gr-diff-comment')[1];
      assert.ok(draftEl);
      draftEl.addEventListener('comment-discard', () => {
        const drafts = element.comments.filter(c => {
          return c.__draft == true;
        });
        assert.equal(drafts.length, 0);
        assert.isTrue(saveOrDiscardStub.called);
        assert.equal(saveOrDiscardStub.lastCall.args[0].detail.rootId,
            element.rootId);
        assert.equal(saveOrDiscardStub.lastCall.args[0].detail.path,
            element.path);
        done();
      });
      draftEl.fire('comment-discard', {comment: draftEl.comment},
          {bubbles: false});
    });

    test('discard with a single comment still fires event with previous rootId',
        done => {
          element.changeNum = '42';
          element.patchNum = '1';
          element.path = '/path/to/file.txt';
          element.comments = [];
          element.addOrEditDraft('1');
          flushAsynchronousOperations();
          const rootId = element.rootId;
          assert.isOk(rootId);

          const saveOrDiscardStub = sandbox.stub();
          element.addEventListener('thread-changed', saveOrDiscardStub);
          const draftEl =
          Polymer.dom(element.root).querySelectorAll('gr-diff-comment')[0];
          assert.ok(draftEl);
          draftEl.addEventListener('comment-discard', () => {
            assert.equal(element.comments.length, 0);
            assert.isTrue(saveOrDiscardStub.called);
            assert.equal(saveOrDiscardStub.lastCall.args[0].detail.rootId,
                rootId);
            assert.equal(saveOrDiscardStub.lastCall.args[0].detail.path,
                element.path);
            done();
          });
          draftEl.fire('comment-discard', {comment: draftEl.comment},
          {bubbles: false});
        });

    test('first editing comment does not add __otherEditing attribute', () => {
      element.comments = [{
        author: {
          name: 'Mr. Peanutbutter',
          email: 'tenn1sballchaser@aol.com',
        },
        id: 'baf0414d_60047215',
        line: 5,
        message: 'is this a crossover episode!?',
        updated: '2015-12-08 19:48:33.843000000',
        __draft: true,
      }];

      const replyBtn = element.$.replyBtn;
      MockInteractions.tap(replyBtn);
      flushAsynchronousOperations();

      const editing = element._orderedComments.filter(c => {
        return c.__editing == true;
      });
      assert.equal(editing.length, 1);
      assert.equal(!!editing[0].__otherEditing, false);
    });

    test('When not editing other comments, local storage not set' +
        ' after discard', done => {
      element.changeNum = '42';
      element.patchNum = '1';
      element.comments = [{
        author: {
          name: 'Mr. Peanutbutter',
          email: 'tenn1sballchaser@aol.com',
        },
        id: 'baf0414d_60047215',
        line: 5,
        message: 'is this a crossover episode!?',
        updated: '2015-12-08 19:48:31.843000000',
      },
      {
        author: {
          name: 'Mr. Peanutbutter',
          email: 'tenn1sballchaser@aol.com',
        },
        __draftID: '1',
        in_reply_to: 'baf0414d_60047215',
        line: 5,
        message: 'yes',
        updated: '2015-12-08 19:48:32.843000000',
        __draft: true,
        __editing: true,
      },
      {
        author: {
          name: 'Mr. Peanutbutter',
          email: 'tenn1sballchaser@aol.com',
        },
        __draftID: '2',
        in_reply_to: 'baf0414d_60047215',
        line: 5,
        message: 'no',
        updated: '2015-12-08 19:48:33.843000000',
        __draft: true,
      }];
      const storageStub = sinon.stub(element.$.storage, 'setDraftComment');
      flushAsynchronousOperations();

      const draftEl =
      Polymer.dom(element.root).querySelectorAll('gr-diff-comment')[1];
      assert.ok(draftEl);
      draftEl.addEventListener('comment-discard', () => {
        assert.isFalse(storageStub.called);
        storageStub.restore();
        done();
      });
      draftEl.fire('comment-discard', {comment: draftEl.comment},
          {bubbles: false});
    });

    test('comment-update', () => {
      const commentEl = element.$$('gr-diff-comment');
      const updatedComment = {
        id: element.comments[0].id,
        foo: 'bar',
      };
      commentEl.fire('comment-update', {comment: updatedComment});
      assert.strictEqual(element.comments[0], updatedComment);
    });

    suite('jack and sally comment data test consolidation', () => {
      setup(() => {
        element.comments = [
          {
            id: 'jacks_reply',
            message: 'i like you, too',
            in_reply_to: 'sallys_confession',
            updated: '2015-12-25 15:00:20.396000000',
            unresolved: false,
          }, {
            id: 'sallys_confession',
            in_reply_to: 'nonexistent_comment',
            message: 'i like you, jack',
            updated: '2015-12-24 15:00:20.396000000',
          }, {
            id: 'sally_to_dr_finklestein',
            in_reply_to: 'nonexistent_comment',
            message: 'i’m running away',
            updated: '2015-10-31 09:00:20.396000000',
          }, {
            id: 'sallys_defiance',
            message: 'i will poison you so i can get away',
            updated: '2015-10-31 15:00:20.396000000',
          }];
      });

      test('orphan replies', () => {
        assert.equal(4, element._orderedComments.length);
      });

      test('keyboard shortcuts', () => {
        const expandCollapseStub =
            sinon.stub(element, '_expandCollapseComments');
        MockInteractions.pressAndReleaseKeyOn(element, 69, null, 'e');
        assert.isTrue(expandCollapseStub.lastCall.calledWith(false));

        MockInteractions.pressAndReleaseKeyOn(element, 69, 'shift', 'e');
        assert.isTrue(expandCollapseStub.lastCall.calledWith(true));
      });

      test('comment in_reply_to is either null or most recent comment', () => {
        element._createReplyComment(element.comments[3], 'dummy', true);
        flushAsynchronousOperations();
        assert.equal(element._orderedComments.length, 5);
        assert.equal(element._orderedComments[4].in_reply_to, 'jacks_reply');
      });

      test('resolvable comments', () => {
        assert.isFalse(element.unresolved);
        element._createReplyComment(element.comments[3], 'dummy', true, true);
        flushAsynchronousOperations();
        assert.isTrue(element.unresolved);
      });

      test('_setInitialExpandedState', () => {
        element.unresolved = true;
        element._setInitialExpandedState();
        for (let i = 0; i < element.comments.length; i++) {
          assert.isFalse(element.comments[i].collapsed);
        }
        element.unresolved = false;
        element._setInitialExpandedState();
        for (let i = 0; i < element.comments.length; i++) {
          assert.isTrue(element.comments[i].collapsed);
        }
        for (let i = 0; i < element.comments.length; i++) {
          element.comments[i].robot_id = 123;
        }
        element._setInitialExpandedState();
        for (let i = 0; i < element.comments.length; i++) {
          assert.isFalse(element.comments[i].collapsed);
        }
      });
    });

    test('_computeHostClass', () => {
      assert.equal(element._computeHostClass(true), 'unresolved');
      assert.equal(element._computeHostClass(false), '');
    });

    test('addDraft sets unresolved state correctly', () => {
      let unresolved = true;
      element.comments = [];
      element.addDraft(null, null, unresolved);
      assert.equal(element.comments[0].unresolved, true);

      unresolved = false; // comment should get added as actually resolved.
      element.comments = [];
      element.addDraft(null, null, unresolved);
      assert.equal(element.comments[0].unresolved, false);

      element.comments = [];
      element.addDraft();
      assert.equal(element.comments[0].unresolved, true);
    });

    test('_newDraft', () => {
      element.commentSide = 'left';
      element.patchNum = 3;
      const draft = element._newDraft();
      assert.equal(draft.__commentSide, 'left');
      assert.equal(draft.patchNum, 3);
    });

    test('new comment gets created', () => {
      element.comments = [];
      element.addOrEditDraft(1);
      assert.equal(element.comments.length, 1);
      // Mock a submitted comment.
      element.comments[0].id = element.comments[0].__draftID;
      element.comments[0].__draft = false;
      element.addOrEditDraft(1);
      assert.equal(element.comments.length, 2);
    });

    test('unresolved label', () => {
      element.unresolved = false;
      assert.isTrue(element.$.unresolvedLabel.hasAttribute('hidden'));
      element.unresolved = true;
      assert.isFalse(element.$.unresolvedLabel.hasAttribute('hidden'));
    });

    test('draft comments are at the end of orderedComments', () => {
      element.comments = [{
        author: {
          name: 'Mr. Peanutbutter',
          email: 'tenn1sballchaser@aol.com',
        },
        id: 2,
        line: 5,
        message: 'Earlier draft',
        updated: '2015-12-08 19:48:33.843000000',
        __draft: true,
      },
      {
        author: {
          name: 'Mr. Peanutbutter2',
          email: 'tenn1sballchaser@aol.com',
        },
        id: 1,
        line: 5,
        message: 'This comment was left last but is not a draft',
        updated: '2015-12-10 19:48:33.843000000',
      },
      {
        author: {
          name: 'Mr. Peanutbutter2',
          email: 'tenn1sballchaser@aol.com',
        },
        id: 3,
        line: 5,
        message: 'Later draft',
        updated: '2015-12-09 19:48:33.843000000',
        __draft: true,
      }];
      assert.equal(element._orderedComments[0].id, '1');
      assert.equal(element._orderedComments[1].id, '2');
      assert.equal(element._orderedComments[2].id, '3');
    });
  });
</script>
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								<!DOCTYPE html>
 								<!--
-												Add @license tags to PG HTML and JS assets

These tags are preserved by the Closure compiler and vulcanize in order
to serve the license notices embedded in the outputs. In a standalone
Gerrit server, these license are also covered in the LICENSES.txt served
with the documentation. When serving PG assets from a CDN, it's less
obvious what the corresponding LICENSES.txt file is, since the CDN is
not directly linked to a running Gerrit server. Safer to embed the
licenses in the assets themselves.

Change-Id: Id1add1451fad1baa7916882a6bda02c326ccc988

											
										
										
											2018-03-26 10:04:27 -04:00
+								@license
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								Copyright (C) 2015 The Android Open Source Project
 								Licensed under the Apache License, Version 2.0 (the "License");
 								you may not use this file except in compliance with the License.
 								You may obtain a copy of the License at
 								http://www.apache.org/licenses/LICENSE-2.0
 								Unless required by applicable law or agreed to in writing, software
 								distributed under the License is distributed on an "AS IS" BASIS,
 								WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 								See the License for the specific language governing permissions and
 								limitations under the License.
 								-->
 								<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
 								<title>gr-diff-comment-thread</title>
-												Refactor directory structure of components

There is no change in functionality. Only moving things around.

+ Separate html from the js.
+ Place the unit test for a component within the same folder.
+ Organize the components in subfolders.

Change-Id: I51fdc510db75fc1b33f040ca63decbbdfd4d5513

											
										
										
											2016-03-04 17:48:22 -05:00
+								<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
 								<script src="../../../bower_components/web-component-tester/browser.js"></script>
-												Add polygerrit-ui/app/test/common-test-setup.html

This is a partial roll-forward of c/106190

This replaces all loads of iron-test-helpers with a load of a file
that wraps it, and adds that file to test files that do not currently
load iron-test-helpers.

A future CL will also install polymer-resin via common-test-helpers.html.

I tested by running

$ WCT_ARGS="-l chrome" ./polygerrit-ui/app/run_test.sh

Change-Id: Ifb3cd2c8db13d724f57e56e7e78045470d103a43

											
										
										
											2017-06-02 13:08:19 -04:00
+								<link rel="import" href="../../../test/common-test-setup.html"/>
-												Refactor directory structure of components

There is no change in functionality. Only moving things around.

+ Separate html from the js.
+ Place the unit test for a component within the same folder.
+ Organize the components in subfolders.

Change-Id: I51fdc510db75fc1b33f040ca63decbbdfd4d5513

											
										
										
											2016-03-04 17:48:22 -05:00
+								<script src="../../../scripts/util.js"></script>
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
-												Refactor directory structure of components

There is no change in functionality. Only moving things around.

+ Separate html from the js.
+ Place the unit test for a component within the same folder.
+ Organize the components in subfolders.

Change-Id: I51fdc510db75fc1b33f040ca63decbbdfd4d5513

											
										
										
											2016-03-04 17:48:22 -05:00
+								<link rel="import" href="gr-diff-comment-thread.html">
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
-												Collection of prospective test flake fixes

Potentially related:
https://github.com/Polymer/web-component-tester/issues/505

Bug: Issue 5792
Change-Id: I9ab6e8e40d9811dd52906335426764c052907609

											
										
										
											2017-03-28 17:02:44 -07:00
+								<script>void(0);</script>
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								<test-fixture id="basic">
 								  <template>
 								    <gr-diff-comment-thread></gr-diff-comment-thread>
 								  </template>
 								</test-fixture>
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								<test-fixture id="withComment">
 								  <template>
 								    <gr-diff-comment-thread></gr-diff-comment-thread>
 								  </template>
 								</test-fixture>
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								<script>
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								  suite('gr-diff-comment-thread tests', () => {
 								    let element;
 								    let sandbox;
-												Expand unresolved comment threads in diff view by default

This change leverages the unresolved flag to automatically expand only
the last UNRESOLVED_EXPAND_COUNT comments in unresolved threads.

Feature: Issue 4752
Change-Id: Ia23920e1a210246838645d56a6bc81d0dff7da07

											
										
										
											2017-01-06 11:33:42 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    setup(() => {
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      sandbox = sinon.sandbox.create();
-												Add comments/drafts to gr-new-diff

Change-Id: I8110b521ab83a31be5db7e3d65268186485db04d

											
										
										
											2016-03-20 14:14:20 -04:00
+								      stub('gr-rest-api-interface', {
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								        getLoggedIn() { return Promise.resolve(false); },
-												Add comments/drafts to gr-new-diff

Change-Id: I8110b521ab83a31be5db7e3d65268186485db04d

											
										
										
											2016-03-20 14:14:20 -04:00
+								      });
-												Add null/undefined checks for comment ranges

Change-Id: Ia66529e44b047ca8938708110d75e7bf910e73ae

											
										
										
											2017-02-08 09:41:53 -08:00
+								      sandbox = sinon.sandbox.create();
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								      element = fixture('basic');
 								    });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    teardown(() => {
-												Add null/undefined checks for comment ranges

Change-Id: Ia66529e44b047ca8938708110d75e7bf910e73ae

											
										
										
											2017-02-08 09:41:53 -08:00
+								      sandbox.restore();
 								    });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('comments are sorted correctly', () => {
 								      const comments = [
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								        {
 								          message: 'i like you, too',
 								          in_reply_to: 'sallys_confession',
-												Fix draft comment in wrong spot

There was an issue with the sort function that returned 0 sometimes when
it should not have. This change adds an additional condition so that the
correct comparison is made.

Bug: Issue 7813
Change-Id: I5b405ae431edc0b37cef09c53a2e8bb786fdeeed

											
										
										
											2017-11-27 16:30:56 -08:00
+								          __date: new Date('2015-12-25'),
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
+								        }, {
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								          id: 'sallys_confession',
 								          message: 'i like you, jack',
 								          updated: '2015-12-24 15:00:20.396000000',
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
+								        }, {
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								          id: 'sally_to_dr_finklestein',
 								          message: 'i’m running away',
 								          updated: '2015-10-31 09:00:20.396000000',
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
+								        }, {
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								          id: 'sallys_defiance',
 								          in_reply_to: 'sally_to_dr_finklestein',
 								          message: 'i will poison you so i can get away',
 								          updated: '2015-10-31 15:00:20.396000000',
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
+								        }, {
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								          id: 'dr_finklesteins_response',
 								          in_reply_to: 'sally_to_dr_finklestein',
 								          message: 'no i will pull a thread and your arm will fall off',
-												Remove threading in comment UI

Sort inline comments in the order that the comments were written.
Formerly comments were sorted in tree order so that reply comments would
appear after their parent. However, this sorting could be confusing
because there would be no other indication that the comments were
associated to a parent. When comments are sorted chronologically, they
appear in the thread position a user would expect.

Change-Id: I4d0722e4511eb53b9b8ab1d61a922d1b142e09ad

											
										
										
											2016-12-15 10:42:43 -08:00
+								          updated: '2015-10-31 11:00:20.396000000',
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
+								        }, {
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								          id: 'sallys_mission',
 								          message: 'i have to find santa',
-												Remove threading in comment UI

Sort inline comments in the order that the comments were written.
Formerly comments were sorted in tree order so that reply comments would
appear after their parent. However, this sorting could be confusing
because there would be no other indication that the comments were
associated to a parent. When comments are sorted chronologically, they
appear in the thread position a user would expect.

Change-Id: I4d0722e4511eb53b9b8ab1d61a922d1b142e09ad

											
										
										
											2016-12-15 10:42:43 -08:00
+								          updated: '2015-12-24 15:00:20.396000000',
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								        },
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								      ];
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const results = element._sortedComments(comments);
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								      assert.deepEqual(results, [
 								        {
 								          id: 'sally_to_dr_finklestein',
 								          message: 'i’m running away',
 								          updated: '2015-10-31 09:00:20.396000000',
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
+								        }, {
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								          id: 'dr_finklesteins_response',
 								          in_reply_to: 'sally_to_dr_finklestein',
 								          message: 'no i will pull a thread and your arm will fall off',
-												Remove threading in comment UI

Sort inline comments in the order that the comments were written.
Formerly comments were sorted in tree order so that reply comments would
appear after their parent. However, this sorting could be confusing
because there would be no other indication that the comments were
associated to a parent. When comments are sorted chronologically, they
appear in the thread position a user would expect.

Change-Id: I4d0722e4511eb53b9b8ab1d61a922d1b142e09ad

											
										
										
											2016-12-15 10:42:43 -08:00
+								          updated: '2015-10-31 11:00:20.396000000',
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
+								        }, {
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								          id: 'sallys_defiance',
 								          in_reply_to: 'sally_to_dr_finklestein',
 								          message: 'i will poison you so i can get away',
 								          updated: '2015-10-31 15:00:20.396000000',
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
+								        }, {
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								          id: 'sallys_confession',
 								          message: 'i like you, jack',
 								          updated: '2015-12-24 15:00:20.396000000',
-												Remove threading in comment UI

Sort inline comments in the order that the comments were written.
Formerly comments were sorted in tree order so that reply comments would
appear after their parent. However, this sorting could be confusing
because there would be no other indication that the comments were
associated to a parent. When comments are sorted chronologically, they
appear in the thread position a user would expect.

Change-Id: I4d0722e4511eb53b9b8ab1d61a922d1b142e09ad

											
										
										
											2016-12-15 10:42:43 -08:00
+								        }, {
 								          id: 'sallys_mission',
 								          message: 'i have to find santa',
 								          updated: '2015-12-24 15:00:20.396000000',
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
+								        }, {
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								          message: 'i like you, too',
 								          in_reply_to: 'sallys_confession',
-												Fix draft comment in wrong spot

There was an issue with the sort function that returned 0 sometimes when
it should not have. This change adds an additional condition so that the
correct comparison is made.

Bug: Issue 7813
Change-Id: I5b405ae431edc0b37cef09c53a2e8bb786fdeeed

											
										
										
											2017-11-27 16:30:56 -08:00
+								          __date: new Date('2015-12-25'),
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								        },
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								      ]);
 								    });
-												Add null/undefined checks for comment ranges

Change-Id: Ia66529e44b047ca8938708110d75e7bf910e73ae

											
										
										
											2017-02-08 09:41:53 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('addOrEditDraft w/ edit draft', () => {
-												Add null/undefined checks for comment ranges

Change-Id: Ia66529e44b047ca8938708110d75e7bf910e73ae

											
										
										
											2017-02-08 09:41:53 -08:00
+								      element.comments = [{
 								        id: 'jacks_reply',
 								        message: 'i like you, too',
 								        in_reply_to: 'sallys_confession',
 								        updated: '2015-12-25 15:00:20.396000000',
 								        __draft: true,
 								      }];
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const commentElStub = sandbox.stub(element, '_commentElWithDraftID',
 								          () => { return {}; });
 								      const addDraftStub = sandbox.stub(element, 'addDraft');
-												Add null/undefined checks for comment ranges

Change-Id: Ia66529e44b047ca8938708110d75e7bf910e73ae

											
										
										
											2017-02-08 09:41:53 -08:00
 								      element.addOrEditDraft(123);
 								      assert.isTrue(commentElStub.called);
 								      assert.isFalse(addDraftStub.called);
 								    });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('addOrEditDraft w/o edit draft', () => {
-												Add null/undefined checks for comment ranges

Change-Id: Ia66529e44b047ca8938708110d75e7bf910e73ae

											
										
										
											2017-02-08 09:41:53 -08:00
+								      element.comments = [];
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const commentElStub = sandbox.stub(element, '_commentElWithDraftID',
 								          () => { return {}; });
 								      const addDraftStub = sandbox.stub(element, 'addDraft');
-												Add null/undefined checks for comment ranges

Change-Id: Ia66529e44b047ca8938708110d75e7bf910e73ae

											
										
										
											2017-02-08 09:41:53 -08:00
 								      element.addOrEditDraft(123);
 								      assert.isFalse(commentElStub.called);
 								      assert.isTrue(addDraftStub.called);
 								    });
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('_hideActions', () => {
 								      let showActions = true;
 								      const lastComment = {};
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      assert.equal(element._hideActions(showActions, lastComment), false);
 								      showActions = false;
 								      assert.equal(element._hideActions(showActions, lastComment), true);
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      showActions = true;
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      lastComment.__draft = true;
 								      assert.equal(element._hideActions(showActions, lastComment), true);
 								    });
-												Harden gr-formatted-text agains slow/failed project configs

Formerly, if a formatted text component tried to render without the
project config (used by inner linked text components) it would
temporarily fall-back to rendering the unformatted (and un-linkified)
text via `.textContent` -- mirroring the behavior of gr-linked-text.

The result is formatted text elements (when rendered without a project
config) appear as one long line of text. Unlike linkification, however,
text can be accurately formatted with or without the project config --
so this disruptive, poor UX is unnecessary.

The formatted text component is updated to format text when the project
config has not provided, and to re-render when the config has been
provided.

In order to propagate project config loads to the formatted text
components hosted by diff comments, the REST calls must be made by the
diff thread component. To make this call, the thread must have the
project's name, so gr-diff-builder is updated to provide this name to
thread components.

Bug: Issue 6686
Change-Id: I8d09c740930500e99cb5f87b92f4d72f3f50a9ce

											
										
										
											2017-07-31 14:33:16 -07:00
 								    test('setting project name loads the project config', done => {
 								      const projectName = 'foo/bar/baz';
 								      const getProjectStub = sandbox.stub(element.$.restAPI, 'getProjectConfig')
 								          .returns(Promise.resolve({}));
 								      element.projectName = projectName;
 								      flush(() => {
 								        assert.isTrue(getProjectStub.calledWithExactly(projectName));
 								        done();
 								      });
 								    });
-												Add optional file link to gr-comment-thread

This will be used by gr-thread-view so that comment threads can have
context. In order to generate URLs, comment threads will also need a
line and change property.

Change-Id: I35d405c8af9f10b4e0c89dd5fcb9e48b7b373534

											
										
										
											2018-02-23 12:07:39 -08:00
 								    test('optionally show file path', () => {
 								      // Path info doesn't exist when showFilePath is false. Because it's in a
 								      // dom-if it is not yet in the dom.
 								      assert.isNotOk(element.$$('.pathInfo'));
 								      sandbox.stub(Gerrit.Nav, 'getUrlForDiffById');
 								      element.changeNum = 123;
 								      element.projectName = 'test project';
 								      element.path = 'path/to/file';
 								      element.patchNum = 3;
 								      element.lineNum = 5;
 								      element.showFilePath = true;
 								      flushAsynchronousOperations();
 								      assert.isOk(element.$$('.pathInfo'));
 								      assert.notEqual(getComputedStyle(element.$$('.pathInfo')).display,
 								          'none');
 								      assert.isTrue(Gerrit.Nav.getUrlForDiffById.lastCall.calledWithExactly(
 								          element.changeNum, element.projectName, element.path,
 								          element.patchNum, null, element.lineNum));
 								    });
 								    test('_computeDisplayPath', () => {
 								      const path = 'path/to/file';
 								      assert.equal(element._computeDisplayPath(path), 'path/to/file');
 								      element.lineNum = 5;
 								      assert.equal(element._computeDisplayPath(path), 'path/to/file#5');
 								    });
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								  });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								  suite('comment action tests', () => {
 								    let element;
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								    let sandbox;
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    setup(() => {
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								      sandbox = sinon.sandbox.create();
-												Add comments/drafts to gr-new-diff

Change-Id: I8110b521ab83a31be5db7e3d65268186485db04d

											
										
										
											2016-03-20 14:14:20 -04:00
+								      stub('gr-rest-api-interface', {
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								        getLoggedIn() { return Promise.resolve(false); },
 								        saveDiffDraft() {
-												Fix issues detected by 'JSHint' and 'JSCS'

Change-Id: Ic1437333fcf82473ac57f8bdea25ee8188ddbfee

											
										
										
											2016-07-13 21:06:03 +02:00
+								          return Promise.resolve({
 								            ok: true,
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								            text() {
 								              return Promise.resolve(')]}\'\n' +
 								                  JSON.stringify({
 								                    id: '7afa4931_de3d65bd',
 								                    path: '/path/to/file.txt',
 								                    line: 5,
 								                    in_reply_to: 'baf0414d_60047215',
 								                    updated: '2015-12-21 02:01:10.850000000',
 								                    message: 'Done',
 								                  }));
-												Fix issues detected by 'JSHint' and 'JSCS'

Change-Id: Ic1437333fcf82473ac57f8bdea25ee8188ddbfee

											
										
										
											2016-07-13 21:06:03 +02:00
+								            },
 								          });
 								        },
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								        deleteDiffDraft() { return Promise.resolve({ok: true}); },
-												Add comments/drafts to gr-new-diff

Change-Id: I8110b521ab83a31be5db7e3d65268186485db04d

											
										
										
											2016-03-20 14:14:20 -04:00
+								      });
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      element = fixture('withComment');
 								      element.comments = [{
 								        author: {
 								          name: 'Mr. Peanutbutter',
 								          email: 'tenn1sballchaser@aol.com',
 								        },
 								        id: 'baf0414d_60047215',
 								        line: 5,
 								        message: 'is this a crossover episode!?',
 								        updated: '2015-12-08 19:48:33.843000000',
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								        path: '/path/to/file.txt',
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      }];
 								      flushAsynchronousOperations();
 								    });
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								    teardown(() => {
 								      sandbox.restore();
 								    });
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								    test('reply', () => {
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const commentEl = element.$$('gr-diff-comment');
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								      const reportStub = sandbox.stub(element.$.reporting,
 								          'recordDraftInteraction');
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      assert.ok(commentEl);
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const replyBtn = element.$.replyBtn;
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      MockInteractions.tap(replyBtn);
 								      flushAsynchronousOperations();
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const drafts = element._orderedComments.filter(c => {
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								        return c.__draft == true;
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      });
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      assert.equal(drafts.length, 1);
 								      assert.notOk(drafts[0].message, 'message should be empty');
 								      assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								      assert.isTrue(reportStub.calledOnce);
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								    });
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								    test('quote reply', () => {
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const commentEl = element.$$('gr-diff-comment');
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								      const reportStub = sandbox.stub(element.$.reporting,
 								          'recordDraftInteraction');
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								      assert.ok(commentEl);
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const quoteBtn = element.$.quoteBtn;
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      MockInteractions.tap(quoteBtn);
 								      flushAsynchronousOperations();
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const drafts = element._orderedComments.filter(c => {
 								        return c.__draft == true;
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								      });
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      assert.equal(drafts.length, 1);
 								      assert.equal(drafts[0].message, '> is this a crossover episode!?\n\n');
 								      assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								      assert.isTrue(reportStub.calledOnce);
-												Add robot comments to PolyGerrit

This change adds an API request to get robot comments for displaying
inline in the diff view. They are styled in a different color, contain
build and robotId information, and a "please fix" action rather than the
standard set of actions.

Feature: Issue 5089
Change-Id: I1f5954a2ed01920bb7c3dc897e3285687ff7d3ca

											
										
										
											2016-12-07 13:36:49 -08:00
+								    });
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								    test('quote reply multiline', () => {
 								      const reportStub = sandbox.stub(element.$.reporting,
 								          'recordDraftInteraction');
-												Add robot comments to PolyGerrit

This change adds an API request to get robot comments for displaying
inline in the diff view. They are styled in a different color, contain
build and robotId information, and a "please fix" action rather than the
standard set of actions.

Feature: Issue 5089
Change-Id: I1f5954a2ed01920bb7c3dc897e3285687ff7d3ca

											
										
										
											2016-12-07 13:36:49 -08:00
+								      element.comments = [{
 								        author: {
 								          name: 'Mr. Peanutbutter',
 								          email: 'tenn1sballchaser@aol.com',
 								        },
 								        id: 'baf0414d_60047215',
 								        line: 5,
 								        message: 'is this a crossover episode!?\nIt might be!',
 								        updated: '2015-12-08 19:48:33.843000000',
 								      }];
 								      flushAsynchronousOperations();
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const commentEl = element.$$('gr-diff-comment');
-												Add robot comments to PolyGerrit

This change adds an API request to get robot comments for displaying
inline in the diff view. They are styled in a different color, contain
build and robotId information, and a "please fix" action rather than the
standard set of actions.

Feature: Issue 5089
Change-Id: I1f5954a2ed01920bb7c3dc897e3285687ff7d3ca

											
										
										
											2016-12-07 13:36:49 -08:00
+								      assert.ok(commentEl);
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const quoteBtn = element.$.quoteBtn;
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      MockInteractions.tap(quoteBtn);
 								      flushAsynchronousOperations();
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const drafts = element._orderedComments.filter(c => {
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								        return c.__draft == true;
-												Add robot comments to PolyGerrit

This change adds an API request to get robot comments for displaying
inline in the diff view. They are styled in a different color, contain
build and robotId information, and a "please fix" action rather than the
standard set of actions.

Feature: Issue 5089
Change-Id: I1f5954a2ed01920bb7c3dc897e3285687ff7d3ca

											
										
										
											2016-12-07 13:36:49 -08:00
+								      });
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      assert.equal(drafts.length, 1);
 								      assert.equal(drafts[0].message,
 								          '> is this a crossover episode!?\n> It might be!\n\n');
 								      assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								      assert.isTrue(reportStub.calledOnce);
-												Implement 'Quote' button on diff comments

Also
+ Cleans up a TODO for a bug that isn’t existent anymore.
+ Doesn’t show cancel button unless editing a draft that has already
  been saved once.

Bug: Issue 3783
Change-Id: I102d598f64e4f37eca41ff428b574e8230e298cf

											
										
										
											2016-01-28 18:07:26 -05:00
+								    });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('ack', done => {
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								      const reportStub = sandbox.stub(element.$.reporting,
 								          'recordDraftInteraction');
-												Add an 'Ack' button next to the 'Done' button

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=622838
Change-Id: Ie7db71615e2c657bbf24847cd8e6e2fc7606f5a9

											
										
										
											2016-11-29 16:46:12 -08:00
+								      element.changeNum = '42';
 								      element.patchNum = '1';
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const commentEl = element.$$('gr-diff-comment');
-												Add an 'Ack' button next to the 'Done' button

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=622838
Change-Id: Ie7db71615e2c657bbf24847cd8e6e2fc7606f5a9

											
										
										
											2016-11-29 16:46:12 -08:00
+								      assert.ok(commentEl);
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const ackBtn = element.$.ackBtn;
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      MockInteractions.tap(ackBtn);
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      flush(() => {
 								        const drafts = element.comments.filter(c => {
-												Add an 'Ack' button next to the 'Done' button

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=622838
Change-Id: Ie7db71615e2c657bbf24847cd8e6e2fc7606f5a9

											
										
										
											2016-11-29 16:46:12 -08:00
+								          return c.__draft == true;
 								        });
 								        assert.equal(drafts.length, 1);
 								        assert.equal(drafts[0].message, 'Ack');
 								        assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
-												Make 'Ack' mark thread as resolved

Bug: Issue 5568
Change-Id: Id8dba066766b5cc8d943bcb5df877c6b66b73ec1

											
										
										
											2017-02-16 11:05:30 -08:00
+								        assert.equal(drafts[0].unresolved, false);
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								        assert.isTrue(reportStub.calledOnce);
-												Add an 'Ack' button next to the 'Done' button

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=622838
Change-Id: Ie7db71615e2c657bbf24847cd8e6e2fc7606f5a9

											
										
										
											2016-11-29 16:46:12 -08:00
+								        done();
 								      });
 								    });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('done', done => {
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								      const reportStub = sandbox.stub(element.$.reporting,
 								          'recordDraftInteraction');
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      element.changeNum = '42';
 								      element.patchNum = '1';
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const commentEl = element.$$('gr-diff-comment');
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      assert.ok(commentEl);
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const doneBtn = element.$.doneBtn;
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      MockInteractions.tap(doneBtn);
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      flush(() => {
 								        const drafts = element.comments.filter(c => {
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								          return c.__draft == true;
 								        });
 								        assert.equal(drafts.length, 1);
 								        assert.equal(drafts[0].message, 'Done');
 								        assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
-												Display comment resolve state

This change tracks and exposes the resolved state of a comment thread
without exposing the UI for modifying that state. This enables features
to be built out while the API request does not exist in the backend.

Feature: Issue 4879
Change-Id: If002035024920a7762519cedf5a869221bbbc3c8

											
										
										
											2017-01-04 16:45:21 -08:00
+								        assert.isFalse(drafts[0].unresolved);
-												Report time between draft comment actions

Report the time between create, update or discard flows are initiated on
diff draft comments.

Change-Id: I71b2f955bfa65dde57307d67fda45069bffa02c0

											
										
										
											2018-06-19 17:03:43 -07:00
+								        assert.isTrue(reportStub.calledOnce);
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								        done();
 								      });
-												Add robot comments to PolyGerrit

This change adds an API request to get robot comments for displaying
inline in the diff view. They are styled in a different color, contain
build and robotId information, and a "please fix" action rather than the
standard set of actions.

Feature: Issue 5089
Change-Id: I1f5954a2ed01920bb7c3dc897e3285687ff7d3ca

											
										
										
											2016-12-07 13:36:49 -08:00
+								    });
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								    test('save', done => {
 								      element.changeNum = '42';
 								      element.patchNum = '1';
 								      element.path = '/path/to/file.txt';
 								      const commentEl = element.$$('gr-diff-comment');
 								      assert.ok(commentEl);
 								      const saveOrDiscardStub = sandbox.stub();
 								      element.addEventListener('thread-changed', saveOrDiscardStub);
 								      element.$$('gr-diff-comment')._fireSave();
 								      flush(() => {
 								        assert.isTrue(saveOrDiscardStub.called);
 								        assert.equal(saveOrDiscardStub.lastCall.args[0].detail.rootId,
 								            'baf0414d_60047215');
 								        assert.equal(element.rootId, 'baf0414d_60047215');
 								        assert.equal(saveOrDiscardStub.lastCall.args[0].detail.path,
 								            '/path/to/file.txt');
 								        done();
 								      });
 								    });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('please fix', done => {
-												Add robot comments to PolyGerrit

This change adds an API request to get robot comments for displaying
inline in the diff view. They are styled in a different color, contain
build and robotId information, and a "please fix" action rather than the
standard set of actions.

Feature: Issue 5089
Change-Id: I1f5954a2ed01920bb7c3dc897e3285687ff7d3ca

											
										
										
											2016-12-07 13:36:49 -08:00
+								      element.changeNum = '42';
 								      element.patchNum = '1';
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const commentEl = element.$$('gr-diff-comment');
-												Add robot comments to PolyGerrit

This change adds an API request to get robot comments for displaying
inline in the diff view. They are styled in a different color, contain
build and robotId information, and a "please fix" action rather than the
standard set of actions.

Feature: Issue 5089
Change-Id: I1f5954a2ed01920bb7c3dc897e3285687ff7d3ca

											
										
										
											2016-12-07 13:36:49 -08:00
+								      assert.ok(commentEl);
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      commentEl.addEventListener('create-fix-comment', () => {
 								        const drafts = element._orderedComments.filter(c => {
-												Add robot comments to PolyGerrit

This change adds an API request to get robot comments for displaying
inline in the diff view. They are styled in a different color, contain
build and robotId information, and a "please fix" action rather than the
standard set of actions.

Feature: Issue 5089
Change-Id: I1f5954a2ed01920bb7c3dc897e3285687ff7d3ca

											
										
										
											2016-12-07 13:36:49 -08:00
+								          return c.__draft == true;
 								        });
 								        assert.equal(drafts.length, 1);
 								        assert.equal(
 								            drafts[0].message, '> is this a crossover episode!?\n\nPlease Fix');
 								        assert.equal(drafts[0].in_reply_to, 'baf0414d_60047215');
-												Display comment resolve state

This change tracks and exposes the resolved state of a comment thread
without exposing the UI for modifying that state. This enables features
to be built out while the API request does not exist in the backend.

Feature: Issue 4879
Change-Id: If002035024920a7762519cedf5a869221bbbc3c8

											
										
										
											2017-01-04 16:45:21 -08:00
+								        assert.isTrue(drafts[0].unresolved);
-												Add robot comments to PolyGerrit

This change adds an API request to get robot comments for displaying
inline in the diff view. They are styled in a different color, contain
build and robotId information, and a "please fix" action rather than the
standard set of actions.

Feature: Issue 5089
Change-Id: I1f5954a2ed01920bb7c3dc897e3285687ff7d3ca

											
										
										
											2016-12-07 13:36:49 -08:00
+								        done();
 								      });
 								      commentEl.fire('create-fix-comment', {comment: commentEl.comment},
 								          {bubbles: false});
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								    });
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('discard', done => {
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      element.changeNum = '42';
 								      element.patchNum = '1';
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								      element.path = '/path/to/file.txt';
-												Fix issue where Reply/Done were not having any effect

+ This was an issue with not using proper array observation
  technique [1].

[1]: https://www.polymer-project.org/1.0/docs/devguide/properties.html#array-observation

Change-Id: I79ef82636d16b3afb3bec42beeb04a8c4e5ab21f

											
										
										
											2016-01-07 13:11:04 -05:00
+								      element.push('comments', element._newReply(
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								          element.comments[0].id,
 								          element.comments[0].line,
 								          element.comments[0].path,
 								          'it’s pronouced jiff, not giff'));
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								      flushAsynchronousOperations();
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								      const saveOrDiscardStub = sandbox.stub();
 								      element.addEventListener('thread-changed', saveOrDiscardStub);
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const draftEl =
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								          Polymer.dom(element.root).querySelectorAll('gr-diff-comment')[1];
 								      assert.ok(draftEl);
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      draftEl.addEventListener('comment-discard', () => {
 								        const drafts = element.comments.filter(c => {
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								          return c.__draft == true;
 								        });
 								        assert.equal(drafts.length, 0);
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								        assert.isTrue(saveOrDiscardStub.called);
 								        assert.equal(saveOrDiscardStub.lastCall.args[0].detail.rootId,
 								            element.rootId);
 								        assert.equal(saveOrDiscardStub.lastCall.args[0].detail.path,
 								            element.path);
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								        done();
 								      });
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								      draftEl.fire('comment-discard', {comment: draftEl.comment},
 								          {bubbles: false});
-												Implement comment display/draft authoring

Some additional cleanup of event names and fixing of the bubbles
property not being placed in the right place.

TODO in a follow-up change:
+ Comments are not considered in context, yet. So if there is a
  comment made in a span of common lines that are hidden, it will
  be there underneath the context control but wont show the code.

Feature: Issue 3649
Change-Id: I8117b243a7d8d529e0c1cea155a4b6b436c0c768

											
										
										
											2015-12-20 19:13:45 -05:00
+								    });
-												Update comment thread model on comment update

Update comments collection in gr-diff-comment-thread when its child
comment changes. Child comment is expected to send comment-update
event.

Change-Id: I8116820679b29b7511719f95ae73b48e2345102c

											
										
										
											2016-06-14 16:57:23 -07:00
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								    test('discard with a single comment still fires event with previous rootId',
 								        done => {
 								          element.changeNum = '42';
 								          element.patchNum = '1';
 								          element.path = '/path/to/file.txt';
 								          element.comments = [];
 								          element.addOrEditDraft('1');
 								          flushAsynchronousOperations();
 								          const rootId = element.rootId;
 								          assert.isOk(rootId);
 								          const saveOrDiscardStub = sandbox.stub();
 								          element.addEventListener('thread-changed', saveOrDiscardStub);
 								          const draftEl =
 								          Polymer.dom(element.root).querySelectorAll('gr-diff-comment')[0];
 								          assert.ok(draftEl);
 								          draftEl.addEventListener('comment-discard', () => {
 								            assert.equal(element.comments.length, 0);
 								            assert.isTrue(saveOrDiscardStub.called);
 								            assert.equal(saveOrDiscardStub.lastCall.args[0].detail.rootId,
 								                rootId);
 								            assert.equal(saveOrDiscardStub.lastCall.args[0].detail.path,
 								                element.path);
 								            done();
 								          });
 								          draftEl.fire('comment-discard', {comment: draftEl.comment},
 								          {bubbles: false});
 								        });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('first editing comment does not add __otherEditing attribute', () => {
-												Fixes comment issues with multiple editing comments

This change addresses a few issues that existed due to multiple comments
in an editing state at the same time.

1) Fixes issue where if you create two replies and add text to the
second reply, then delete the first one, the text in the second textarea
gets removed.

2) Fixes issue where if you reply and add text, then reply again with
the first draft still editing, the second draft gets populated with the
message from the first comment.

3) Fixes issue where if you have multiple replies and delete one of
them, local storage gets erased. This change sets local storage to the
value of the first editing message found after deleting the other one
(if it exists).

Bug: Issue 4409
Change-Id: Ib5913a34a79783a4a87b4a298e25b02fc587b8dd

											
										
										
											2016-12-22 15:04:11 -08:00
+								      element.comments = [{
 								        author: {
 								          name: 'Mr. Peanutbutter',
 								          email: 'tenn1sballchaser@aol.com',
 								        },
 								        id: 'baf0414d_60047215',
 								        line: 5,
 								        message: 'is this a crossover episode!?',
 								        updated: '2015-12-08 19:48:33.843000000',
 								        __draft: true,
 								      }];
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const replyBtn = element.$.replyBtn;
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      MockInteractions.tap(replyBtn);
-												Fixes comment issues with multiple editing comments

This change addresses a few issues that existed due to multiple comments
in an editing state at the same time.

1) Fixes issue where if you create two replies and add text to the
second reply, then delete the first one, the text in the second textarea
gets removed.

2) Fixes issue where if you reply and add text, then reply again with
the first draft still editing, the second draft gets populated with the
message from the first comment.

3) Fixes issue where if you have multiple replies and delete one of
them, local storage gets erased. This change sets local storage to the
value of the first editing message found after deleting the other one
(if it exists).

Bug: Issue 4409
Change-Id: Ib5913a34a79783a4a87b4a298e25b02fc587b8dd

											
										
										
											2016-12-22 15:04:11 -08:00
+								      flushAsynchronousOperations();
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const editing = element._orderedComments.filter(c => {
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								        return c.__editing == true;
-												Fixes comment issues with multiple editing comments

This change addresses a few issues that existed due to multiple comments
in an editing state at the same time.

1) Fixes issue where if you create two replies and add text to the
second reply, then delete the first one, the text in the second textarea
gets removed.

2) Fixes issue where if you reply and add text, then reply again with
the first draft still editing, the second draft gets populated with the
message from the first comment.

3) Fixes issue where if you have multiple replies and delete one of
them, local storage gets erased. This change sets local storage to the
value of the first editing message found after deleting the other one
(if it exists).

Bug: Issue 4409
Change-Id: Ib5913a34a79783a4a87b4a298e25b02fc587b8dd

											
										
										
											2016-12-22 15:04:11 -08:00
+								      });
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      assert.equal(editing.length, 1);
 								      assert.equal(!!editing[0].__otherEditing, false);
-												Fixes comment issues with multiple editing comments

This change addresses a few issues that existed due to multiple comments
in an editing state at the same time.

1) Fixes issue where if you create two replies and add text to the
second reply, then delete the first one, the text in the second textarea
gets removed.

2) Fixes issue where if you reply and add text, then reply again with
the first draft still editing, the second draft gets populated with the
message from the first comment.

3) Fixes issue where if you have multiple replies and delete one of
them, local storage gets erased. This change sets local storage to the
value of the first editing message found after deleting the other one
(if it exists).

Bug: Issue 4409
Change-Id: Ib5913a34a79783a4a87b4a298e25b02fc587b8dd

											
										
										
											2016-12-22 15:04:11 -08:00
+								    });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('When not editing other comments, local storage not set' +
 								        ' after discard', done => {
-												Fixes comment issues with multiple editing comments

This change addresses a few issues that existed due to multiple comments
in an editing state at the same time.

1) Fixes issue where if you create two replies and add text to the
second reply, then delete the first one, the text in the second textarea
gets removed.

2) Fixes issue where if you reply and add text, then reply again with
the first draft still editing, the second draft gets populated with the
message from the first comment.

3) Fixes issue where if you have multiple replies and delete one of
them, local storage gets erased. This change sets local storage to the
value of the first editing message found after deleting the other one
(if it exists).

Bug: Issue 4409
Change-Id: Ib5913a34a79783a4a87b4a298e25b02fc587b8dd

											
										
										
											2016-12-22 15:04:11 -08:00
+								      element.changeNum = '42';
 								      element.patchNum = '1';
 								      element.comments = [{
 								        author: {
 								          name: 'Mr. Peanutbutter',
 								          email: 'tenn1sballchaser@aol.com',
 								        },
 								        id: 'baf0414d_60047215',
 								        line: 5,
 								        message: 'is this a crossover episode!?',
 								        updated: '2015-12-08 19:48:31.843000000',
 								      },
 								      {
 								        author: {
 								          name: 'Mr. Peanutbutter',
 								          email: 'tenn1sballchaser@aol.com',
 								        },
 								        __draftID: '1',
 								        in_reply_to: 'baf0414d_60047215',
 								        line: 5,
 								        message: 'yes',
 								        updated: '2015-12-08 19:48:32.843000000',
 								        __draft: true,
 								        __editing: true,
 								      },
 								      {
 								        author: {
 								          name: 'Mr. Peanutbutter',
 								          email: 'tenn1sballchaser@aol.com',
 								        },
 								        __draftID: '2',
 								        in_reply_to: 'baf0414d_60047215',
 								        line: 5,
 								        message: 'no',
 								        updated: '2015-12-08 19:48:33.843000000',
 								        __draft: true,
 								      }];
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const storageStub = sinon.stub(element.$.storage, 'setDraftComment');
-												Fixes comment issues with multiple editing comments

This change addresses a few issues that existed due to multiple comments
in an editing state at the same time.

1) Fixes issue where if you create two replies and add text to the
second reply, then delete the first one, the text in the second textarea
gets removed.

2) Fixes issue where if you reply and add text, then reply again with
the first draft still editing, the second draft gets populated with the
message from the first comment.

3) Fixes issue where if you have multiple replies and delete one of
them, local storage gets erased. This change sets local storage to the
value of the first editing message found after deleting the other one
(if it exists).

Bug: Issue 4409
Change-Id: Ib5913a34a79783a4a87b4a298e25b02fc587b8dd

											
										
										
											2016-12-22 15:04:11 -08:00
+								      flushAsynchronousOperations();
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const draftEl =
 								      Polymer.dom(element.root).querySelectorAll('gr-diff-comment')[1];
-												Fixes comment issues with multiple editing comments

This change addresses a few issues that existed due to multiple comments
in an editing state at the same time.

1) Fixes issue where if you create two replies and add text to the
second reply, then delete the first one, the text in the second textarea
gets removed.

2) Fixes issue where if you reply and add text, then reply again with
the first draft still editing, the second draft gets populated with the
message from the first comment.

3) Fixes issue where if you have multiple replies and delete one of
them, local storage gets erased. This change sets local storage to the
value of the first editing message found after deleting the other one
(if it exists).

Bug: Issue 4409
Change-Id: Ib5913a34a79783a4a87b4a298e25b02fc587b8dd

											
										
										
											2016-12-22 15:04:11 -08:00
+								      assert.ok(draftEl);
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      draftEl.addEventListener('comment-discard', () => {
-												Fixes comment issues with multiple editing comments

This change addresses a few issues that existed due to multiple comments
in an editing state at the same time.

1) Fixes issue where if you create two replies and add text to the
second reply, then delete the first one, the text in the second textarea
gets removed.

2) Fixes issue where if you reply and add text, then reply again with
the first draft still editing, the second draft gets populated with the
message from the first comment.

3) Fixes issue where if you have multiple replies and delete one of
them, local storage gets erased. This change sets local storage to the
value of the first editing message found after deleting the other one
(if it exists).

Bug: Issue 4409
Change-Id: Ib5913a34a79783a4a87b4a298e25b02fc587b8dd

											
										
										
											2016-12-22 15:04:11 -08:00
+								        assert.isFalse(storageStub.called);
 								        storageStub.restore();
 								        done();
 								      });
-												Add events to thread list and diff view

Whenever a comment changes in either the thread view or the diff view,
the other view will need to be notified of the change in order to
re-render its comments, since they do not share a common data source
(The diff view's comments are added manually when the diff is rendered
via the diff builder).

Because the gr-diff-comment-thread is common to both uses, it can fire
events to be consumed in both cases.

From there, gr-diff and gr-list-view each fire a separate event, which
is listened for on the change view (common ancestor). The change view
will then trigger reloading of comments for the element that needs

Change-Id: Ia31c0ef512af408c4d099667558a32f86ed43152

											
										
										
											2018-03-08 13:45:28 -08:00
+								      draftEl.fire('comment-discard', {comment: draftEl.comment},
 								          {bubbles: false});
-												Fixes comment issues with multiple editing comments

This change addresses a few issues that existed due to multiple comments
in an editing state at the same time.

1) Fixes issue where if you create two replies and add text to the
second reply, then delete the first one, the text in the second textarea
gets removed.

2) Fixes issue where if you reply and add text, then reply again with
the first draft still editing, the second draft gets populated with the
message from the first comment.

3) Fixes issue where if you have multiple replies and delete one of
them, local storage gets erased. This change sets local storage to the
value of the first editing message found after deleting the other one
(if it exists).

Bug: Issue 4409
Change-Id: Ib5913a34a79783a4a87b4a298e25b02fc587b8dd

											
										
										
											2016-12-22 15:04:11 -08:00
+								    });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('comment-update', () => {
 								      const commentEl = element.$$('gr-diff-comment');
 								      const updatedComment = {
-												Update comment thread model on comment update

Update comments collection in gr-diff-comment-thread when its child
comment changes. Child comment is expected to send comment-update
event.

Change-Id: I8116820679b29b7511719f95ae73b48e2345102c

											
										
										
											2016-06-14 16:57:23 -07:00
+								        id: element.comments[0].id,
 								        foo: 'bar',
 								      };
 								      commentEl.fire('comment-update', {comment: updatedComment});
 								      assert.strictEqual(element.comments[0], updatedComment);
 								    });
-												Add orphan comments as top-level comments

Add comments that are replies to ones missing from comment thread as
top-level comments to the thread instead of discarding.

Change-Id: Ib93fa1c74f1ca004ee2361e017dc1210c42ec399

											
										
										
											2016-06-15 16:05:14 -07:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    suite('jack and sally comment data test consolidation', () => {
 								      setup(() => {
-												Display comment resolve state

This change tracks and exposes the resolved state of a comment thread
without exposing the UI for modifying that state. This enables features
to be built out while the API request does not exist in the backend.

Feature: Issue 4879
Change-Id: If002035024920a7762519cedf5a869221bbbc3c8

											
										
										
											2017-01-04 16:45:21 -08:00
+								        element.comments = [
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								          {
 								            id: 'jacks_reply',
 								            message: 'i like you, too',
 								            in_reply_to: 'sallys_confession',
 								            updated: '2015-12-25 15:00:20.396000000',
 								            unresolved: false,
 								          }, {
 								            id: 'sallys_confession',
 								            in_reply_to: 'nonexistent_comment',
 								            message: 'i like you, jack',
 								            updated: '2015-12-24 15:00:20.396000000',
 								          }, {
 								            id: 'sally_to_dr_finklestein',
 								            in_reply_to: 'nonexistent_comment',
 								            message: 'i’m running away',
 								            updated: '2015-10-31 09:00:20.396000000',
 								          }, {
 								            id: 'sallys_defiance',
 								            message: 'i will poison you so i can get away',
 								            updated: '2015-10-31 15:00:20.396000000',
 								          }];
-												Display comment resolve state

This change tracks and exposes the resolved state of a comment thread
without exposing the UI for modifying that state. This enables features
to be built out while the API request does not exist in the backend.

Feature: Issue 4879
Change-Id: If002035024920a7762519cedf5a869221bbbc3c8

											
										
										
											2017-01-04 16:45:21 -08:00
+								      });
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      test('orphan replies', () => {
-												Display comment resolve state

This change tracks and exposes the resolved state of a comment thread
without exposing the UI for modifying that state. This enables features
to be built out while the API request does not exist in the backend.

Feature: Issue 4879
Change-Id: If002035024920a7762519cedf5a869221bbbc3c8

											
										
										
											2017-01-04 16:45:21 -08:00
+								        assert.equal(4, element._orderedComments.length);
 								      });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      test('keyboard shortcuts', () => {
 								        const expandCollapseStub =
 								            sinon.stub(element, '_expandCollapseComments');
-												Display comment resolve state

This change tracks and exposes the resolved state of a comment thread
without exposing the UI for modifying that state. This enables features
to be built out while the API request does not exist in the backend.

Feature: Issue 4879
Change-Id: If002035024920a7762519cedf5a869221bbbc3c8

											
										
										
											2017-01-04 16:45:21 -08:00
+								        MockInteractions.pressAndReleaseKeyOn(element, 69, null, 'e');
 								        assert.isTrue(expandCollapseStub.lastCall.calledWith(false));
 								        MockInteractions.pressAndReleaseKeyOn(element, 69, 'shift', 'e');
 								        assert.isTrue(expandCollapseStub.lastCall.calledWith(true));
 								      });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      test('comment in_reply_to is either null or most recent comment', () => {
-												Display comment resolve state

This change tracks and exposes the resolved state of a comment thread
without exposing the UI for modifying that state. This enables features
to be built out while the API request does not exist in the backend.

Feature: Issue 4879
Change-Id: If002035024920a7762519cedf5a869221bbbc3c8

											
										
										
											2017-01-04 16:45:21 -08:00
+								        element._createReplyComment(element.comments[3], 'dummy', true);
 								        flushAsynchronousOperations();
 								        assert.equal(element._orderedComments.length, 5);
 								        assert.equal(element._orderedComments[4].in_reply_to, 'jacks_reply');
 								      });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      test('resolvable comments', () => {
-												Prepare gr-diff-comment-thread for use in comment thread view

- Updaotes the unresolved property to be public, and reflects the
  attribute. This will be used for the toggle to show unresolved threads
  or all threads.
- Update logic to always show drafts at the end of sorted comments.
  Without this, the thread could get in a weird state where you can
  still add another draft, but since they are not threaded, and once the
  comment is published, its date changes to the published date anyway,
  so its ordering will be at the end.
- This change also adds the __draft attribute in gr-diff-comment-api so
  that draft comments will render correctly in the new view.

Change-Id: Icacc46ab5fd643b061ecfac8dcd313f815d17199

											
										
										
											2018-02-05 17:16:30 -08:00
+								        assert.isFalse(element.unresolved);
-												Display comment resolve state

This change tracks and exposes the resolved state of a comment thread
without exposing the UI for modifying that state. This enables features
to be built out while the API request does not exist in the backend.

Feature: Issue 4879
Change-Id: If002035024920a7762519cedf5a869221bbbc3c8

											
										
										
											2017-01-04 16:45:21 -08:00
+								        element._createReplyComment(element.comments[3], 'dummy', true, true);
 								        flushAsynchronousOperations();
-												Prepare gr-diff-comment-thread for use in comment thread view

- Updaotes the unresolved property to be public, and reflects the
  attribute. This will be used for the toggle to show unresolved threads
  or all threads.
- Update logic to always show drafts at the end of sorted comments.
  Without this, the thread could get in a weird state where you can
  still add another draft, but since they are not threaded, and once the
  comment is published, its date changes to the published date anyway,
  so its ordering will be at the end.
- This change also adds the __draft attribute in gr-diff-comment-api so
  that draft comments will render correctly in the new view.

Change-Id: Icacc46ab5fd643b061ecfac8dcd313f815d17199

											
										
										
											2018-02-05 17:16:30 -08:00
+								        assert.isTrue(element.unresolved);
-												Display comment resolve state

This change tracks and exposes the resolved state of a comment thread
without exposing the UI for modifying that state. This enables features
to be built out while the API request does not exist in the backend.

Feature: Issue 4879
Change-Id: If002035024920a7762519cedf5a869221bbbc3c8

											
										
										
											2017-01-04 16:45:21 -08:00
+								      });
-												Expand unresolved comment threads in diff view by default

This change leverages the unresolved flag to automatically expand only
the last UNRESOLVED_EXPAND_COUNT comments in unresolved threads.

Feature: Issue 4752
Change-Id: Ia23920e1a210246838645d56a6bc81d0dff7da07

											
										
										
											2017-01-06 11:33:42 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      test('_setInitialExpandedState', () => {
-												Prepare gr-diff-comment-thread for use in comment thread view

- Updaotes the unresolved property to be public, and reflects the
  attribute. This will be used for the toggle to show unresolved threads
  or all threads.
- Update logic to always show drafts at the end of sorted comments.
  Without this, the thread could get in a weird state where you can
  still add another draft, but since they are not threaded, and once the
  comment is published, its date changes to the published date anyway,
  so its ordering will be at the end.
- This change also adds the __draft attribute in gr-diff-comment-api so
  that draft comments will render correctly in the new view.

Change-Id: Icacc46ab5fd643b061ecfac8dcd313f815d17199

											
										
										
											2018-02-05 17:16:30 -08:00
+								        element.unresolved = true;
-												Expand unresolved comment threads in diff view by default

This change leverages the unresolved flag to automatically expand only
the last UNRESOLVED_EXPAND_COUNT comments in unresolved threads.

Feature: Issue 4752
Change-Id: Ia23920e1a210246838645d56a6bc81d0dff7da07

											
										
										
											2017-01-06 11:33:42 -08:00
+								        element._setInitialExpandedState();
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								        for (let i = 0; i < element.comments.length; i++) {
-												Expand unresolved comment threads in diff view by default

This change leverages the unresolved flag to automatically expand only
the last UNRESOLVED_EXPAND_COUNT comments in unresolved threads.

Feature: Issue 4752
Change-Id: Ia23920e1a210246838645d56a6bc81d0dff7da07

											
										
										
											2017-01-06 11:33:42 -08:00
+								          assert.isFalse(element.comments[i].collapsed);
 								        }
-												Prepare gr-diff-comment-thread for use in comment thread view

- Updaotes the unresolved property to be public, and reflects the
  attribute. This will be used for the toggle to show unresolved threads
  or all threads.
- Update logic to always show drafts at the end of sorted comments.
  Without this, the thread could get in a weird state where you can
  still add another draft, but since they are not threaded, and once the
  comment is published, its date changes to the published date anyway,
  so its ordering will be at the end.
- This change also adds the __draft attribute in gr-diff-comment-api so
  that draft comments will render correctly in the new view.

Change-Id: Icacc46ab5fd643b061ecfac8dcd313f815d17199

											
										
										
											2018-02-05 17:16:30 -08:00
+								        element.unresolved = false;
-												Expand unresolved comment threads in diff view by default

This change leverages the unresolved flag to automatically expand only
the last UNRESOLVED_EXPAND_COUNT comments in unresolved threads.

Feature: Issue 4752
Change-Id: Ia23920e1a210246838645d56a6bc81d0dff7da07

											
										
										
											2017-01-06 11:33:42 -08:00
+								        element._setInitialExpandedState();
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								        for (let i = 0; i < element.comments.length; i++) {
-												Expand unresolved comment threads in diff view by default

This change leverages the unresolved flag to automatically expand only
the last UNRESOLVED_EXPAND_COUNT comments in unresolved threads.

Feature: Issue 4752
Change-Id: Ia23920e1a210246838645d56a6bc81d0dff7da07

											
										
										
											2017-01-06 11:33:42 -08:00
+								          assert.isTrue(element.comments[i].collapsed);
 								        }
-												Expand robot comments by default

Change-Id: I6c55c0dad4cc0bd96013c77ad75b3cd6c6d34cdd

											
										
										
											2017-12-08 11:01:26 -08:00
+								        for (let i = 0; i < element.comments.length; i++) {
 								          element.comments[i].robot_id = 123;
 								        }
 								        element._setInitialExpandedState();
 								        for (let i = 0; i < element.comments.length; i++) {
 								          assert.isFalse(element.comments[i].collapsed);
 								        }
-												Expand unresolved comment threads in diff view by default

This change leverages the unresolved flag to automatically expand only
the last UNRESOLVED_EXPAND_COUNT comments in unresolved threads.

Feature: Issue 4752
Change-Id: Ia23920e1a210246838645d56a6bc81d0dff7da07

											
										
										
											2017-01-06 11:33:42 -08:00
+								      });
-												Keyboard shortcuts to expand and collapse all comments

This change adds keyboard shortcuts to the "gr-diff-comment-thread"
expand all comments when 'e' is pressed and collapse all comments when
'shift + e' is pressed. Note that the keyboard event is detected on the
thread instead of the comment to minimize the number of events getting
triggered.

Feature: Issue 4738
Change-Id: Iab77349bd1527d7af5e05a827919a78a86909835

											
										
										
											2016-10-10 17:31:56 -07:00
+								    });
-												Populate in_reply_to field with most recent comment

This change fully removes threading from the PG UI's comments. This is
a side effect of the implementation of resolvable comments.

Change-Id: I67e2a8f896726787857c35552fa8c0a9f629c2ba

											
										
										
											2016-12-27 17:48:38 -05:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('_computeHostClass', () => {
-												Display comment resolve state

This change tracks and exposes the resolved state of a comment thread
without exposing the UI for modifying that state. This enables features
to be built out while the API request does not exist in the backend.

Feature: Issue 4879
Change-Id: If002035024920a7762519cedf5a869221bbbc3c8

											
										
										
											2017-01-04 16:45:21 -08:00
+								      assert.equal(element._computeHostClass(true), 'unresolved');
 								      assert.equal(element._computeHostClass(false), '');
-												Populate in_reply_to field with most recent comment

This change fully removes threading from the PG UI's comments. This is
a side effect of the implementation of resolvable comments.

Change-Id: I67e2a8f896726787857c35552fa8c0a9f629c2ba

											
										
										
											2016-12-27 17:48:38 -05:00
+								    });
-												Don't merge threads on same line left/right

Goes along with c/95273/. Adds commentSide attribute to comments to see
which side of the diff view they belong on. This is also used as part
of the locationRange for the gr-diff-comment-thread-group, so that two
thread groups can be on the same line or range for the unified group (
one for the right, one for the left).

Note: there is already a 'side' attribute on the gr-diff-comment, which
is confusing. This side actually references 'PARENT' or 'REVISION', to
identify whether the comment belongs to the parent or any revision. On
diffs where two revisions are compared to each other, this cannot be
used to determine left/right. However, because 'side' is part of
the CommentInfo entity[1], it is difficult to change the name and make
more sense out of that.

[1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#comment-info

Bug: Issue 5114
Change-Id: I5cc4c17d4bb134e31e5cc07ff9b08ed349488c97

											
										
										
											2017-01-30 12:03:13 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('addDraft sets unresolved state correctly', () => {
 								      let unresolved = true;
-												Get unresolved state from thread when it exists for new reply

Currently, when a response is created via keyboard shortcut 'c' or
clicking a line number, the comment is not created with the unresolved
state of the last comment in the thread.

This change checks for the previous state and adds that to the new
draft.

Bug: Issue 5408
Change-Id: I20eb039864120d5175cc016bfc695da564bc174d

											
										
										
											2017-02-09 08:00:24 -08:00
+								      element.comments = [];
 								      element.addDraft(null, null, unresolved);
 								      assert.equal(element.comments[0].unresolved, true);
 								      unresolved = false; // comment should get added as actually resolved.
 								      element.comments = [];
 								      element.addDraft(null, null, unresolved);
 								      assert.equal(element.comments[0].unresolved, false);
 								      element.comments = [];
 								      element.addDraft();
 								      assert.equal(element.comments[0].unresolved, true);
 								    });
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('_newDraft', () => {
-												Don't merge threads on same line left/right

Goes along with c/95273/. Adds commentSide attribute to comments to see
which side of the diff view they belong on. This is also used as part
of the locationRange for the gr-diff-comment-thread-group, so that two
thread groups can be on the same line or range for the unified group (
one for the right, one for the left).

Note: there is already a 'side' attribute on the gr-diff-comment, which
is confusing. This side actually references 'PARENT' or 'REVISION', to
identify whether the comment belongs to the parent or any revision. On
diffs where two revisions are compared to each other, this cannot be
used to determine left/right. However, because 'side' is part of
the CommentInfo entity[1], it is difficult to change the name and make
more sense out of that.

[1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#comment-info

Bug: Issue 5114
Change-Id: I5cc4c17d4bb134e31e5cc07ff9b08ed349488c97

											
										
										
											2017-01-30 12:03:13 -08:00
+								      element.commentSide = 'left';
-												Fix corner case where storage gets duplicated for patchsets

Previously, there was an issue where if you create a draft comment in
side by side view and switch to unified view, the comment thinks it's in
the later patch set rather than the earlier one and a second copy gets
added to local storage with the later patchset as a component of the
key.

This was because the the thread group assumed all threads inside of it
had the same patch number. This change fixes that, so in the event that
a user switches from side by side to unified, the patch number will get
taken from the comment rather than the thread group.

Bug: Issue 5493
Change-Id: I7f00997bcb2e6f1001a5d58ac206acf5af3367d2

											
										
										
											2017-02-09 07:34:23 -08:00
+								      element.patchNum = 3;
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								      const draft = element._newDraft();
-												Don't merge threads on same line left/right

Goes along with c/95273/. Adds commentSide attribute to comments to see
which side of the diff view they belong on. This is also used as part
of the locationRange for the gr-diff-comment-thread-group, so that two
thread groups can be on the same line or range for the unified group (
one for the right, one for the left).

Note: there is already a 'side' attribute on the gr-diff-comment, which
is confusing. This side actually references 'PARENT' or 'REVISION', to
identify whether the comment belongs to the parent or any revision. On
diffs where two revisions are compared to each other, this cannot be
used to determine left/right. However, because 'side' is part of
the CommentInfo entity[1], it is difficult to change the name and make
more sense out of that.

[1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#comment-info

Bug: Issue 5114
Change-Id: I5cc4c17d4bb134e31e5cc07ff9b08ed349488c97

											
										
										
											2017-01-30 12:03:13 -08:00
+								      assert.equal(draft.__commentSide, 'left');
-												Fix corner case where storage gets duplicated for patchsets

Previously, there was an issue where if you create a draft comment in
side by side view and switch to unified view, the comment thinks it's in
the later patch set rather than the earlier one and a second copy gets
added to local storage with the later patchset as a component of the
key.

This was because the the thread group assumed all threads inside of it
had the same patch number. This change fixes that, so in the event that
a user switches from side by side to unified, the patch number will get
taken from the comment rather than the thread group.

Bug: Issue 5493
Change-Id: I7f00997bcb2e6f1001a5d58ac206acf5af3367d2

											
										
										
											2017-02-09 07:34:23 -08:00
+								      assert.equal(draft.patchNum, 3);
-												Don't merge threads on same line left/right

Goes along with c/95273/. Adds commentSide attribute to comments to see
which side of the diff view they belong on. This is also used as part
of the locationRange for the gr-diff-comment-thread-group, so that two
thread groups can be on the same line or range for the unified group (
one for the right, one for the left).

Note: there is already a 'side' attribute on the gr-diff-comment, which
is confusing. This side actually references 'PARENT' or 'REVISION', to
identify whether the comment belongs to the parent or any revision. On
diffs where two revisions are compared to each other, this cannot be
used to determine left/right. However, because 'side' is part of
the CommentInfo entity[1], it is difficult to change the name and make
more sense out of that.

[1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#comment-info

Bug: Issue 5114
Change-Id: I5cc4c17d4bb134e31e5cc07ff9b08ed349488c97

											
										
										
											2017-01-30 12:03:13 -08:00
+								    });
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('new comment gets created', () => {
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      element.comments = [];
 								      element.addOrEditDraft(1);
 								      assert.equal(element.comments.length, 1);
 								      // Mock a submitted comment.
 								      element.comments[0].id = element.comments[0].__draftID;
-												Fix corner case where storage gets duplicated for patchsets

Previously, there was an issue where if you create a draft comment in
side by side view and switch to unified view, the comment thinks it's in
the later patch set rather than the earlier one and a second copy gets
added to local storage with the later patchset as a component of the
key.

This was because the the thread group assumed all threads inside of it
had the same patch number. This change fixes that, so in the event that
a user switches from side by side to unified, the patch number will get
taken from the comment rather than the thread group.

Bug: Issue 5493
Change-Id: I7f00997bcb2e6f1001a5d58ac206acf5af3367d2

											
										
										
											2017-02-09 07:34:23 -08:00
+								      element.comments[0].__draft = false;
-												Move reply buttons to comment thread

Move all buttons that generate a reply of some sort (done, ack, reply,
quote) to the comment thread instead of the comment [1].

When there is a draft for a particular comment thread, all reply buttons
are hidden [2].  For example, if you click reply, you cannot click done
on the same thread, unless you remove the draft.

Each thread can have up to 1 draft. It's also worth noting that if a
thread has a draft, and the user clicks on the line or 'c' at the same
range, the existing draft will switch to 'editing' form.

[1] With the exception of "please fix" for robot comments.
[2] In this case, The please fix button will be disabled when other
reply buttons are hidden.

Feature: Issue 5410
Change-Id: Id847ee0cba0d0ce4e5b6476f58141866d41ffdad

											
										
										
											2017-02-09 16:07:32 -08:00
+								      element.addOrEditDraft(1);
 								      assert.equal(element.comments.length, 2);
 								    });
-												Label resolved state in comment threads

Unresolved state is only shown when the comment actions (reply/Ack/etc)
are shown AND when the thread is unresolved.

Feature: Issue 5442
Change-Id: I7e0859530198fa17172e9f9efa73a20c7aa03975

											
										
										
											2017-02-03 10:50:28 -08:00
-												ES6ify /gr-diff-comment-thread/*

Bug: Issue 6179
Change-Id: Ib850e99830ff4a750a57e404d069d7bf364469fe

											
										
										
											2017-05-16 13:56:20 -07:00
+								    test('unresolved label', () => {
-												Prepare gr-diff-comment-thread for use in comment thread view

- Updaotes the unresolved property to be public, and reflects the
  attribute. This will be used for the toggle to show unresolved threads
  or all threads.
- Update logic to always show drafts at the end of sorted comments.
  Without this, the thread could get in a weird state where you can
  still add another draft, but since they are not threaded, and once the
  comment is published, its date changes to the published date anyway,
  so its ordering will be at the end.
- This change also adds the __draft attribute in gr-diff-comment-api so
  that draft comments will render correctly in the new view.

Change-Id: Icacc46ab5fd643b061ecfac8dcd313f815d17199

											
										
										
											2018-02-05 17:16:30 -08:00
+								      element.unresolved = false;
-												Label resolved state in comment threads

Unresolved state is only shown when the comment actions (reply/Ack/etc)
are shown AND when the thread is unresolved.

Feature: Issue 5442
Change-Id: I7e0859530198fa17172e9f9efa73a20c7aa03975

											
										
										
											2017-02-03 10:50:28 -08:00
+								      assert.isTrue(element.$.unresolvedLabel.hasAttribute('hidden'));
-												Prepare gr-diff-comment-thread for use in comment thread view

- Updaotes the unresolved property to be public, and reflects the
  attribute. This will be used for the toggle to show unresolved threads
  or all threads.
- Update logic to always show drafts at the end of sorted comments.
  Without this, the thread could get in a weird state where you can
  still add another draft, but since they are not threaded, and once the
  comment is published, its date changes to the published date anyway,
  so its ordering will be at the end.
- This change also adds the __draft attribute in gr-diff-comment-api so
  that draft comments will render correctly in the new view.

Change-Id: Icacc46ab5fd643b061ecfac8dcd313f815d17199

											
										
										
											2018-02-05 17:16:30 -08:00
+								      element.unresolved = true;
-												Label resolved state in comment threads

Unresolved state is only shown when the comment actions (reply/Ack/etc)
are shown AND when the thread is unresolved.

Feature: Issue 5442
Change-Id: I7e0859530198fa17172e9f9efa73a20c7aa03975

											
										
										
											2017-02-03 10:50:28 -08:00
+								      assert.isFalse(element.$.unresolvedLabel.hasAttribute('hidden'));
 								    });
-												Prepare gr-diff-comment-thread for use in comment thread view

- Updaotes the unresolved property to be public, and reflects the
  attribute. This will be used for the toggle to show unresolved threads
  or all threads.
- Update logic to always show drafts at the end of sorted comments.
  Without this, the thread could get in a weird state where you can
  still add another draft, but since they are not threaded, and once the
  comment is published, its date changes to the published date anyway,
  so its ordering will be at the end.
- This change also adds the __draft attribute in gr-diff-comment-api so
  that draft comments will render correctly in the new view.

Change-Id: Icacc46ab5fd643b061ecfac8dcd313f815d17199

											
										
										
											2018-02-05 17:16:30 -08:00
 								    test('draft comments are at the end of orderedComments', () => {
 								      element.comments = [{
 								        author: {
 								          name: 'Mr. Peanutbutter',
 								          email: 'tenn1sballchaser@aol.com',
 								        },
 								        id: 2,
 								        line: 5,
 								        message: 'Earlier draft',
 								        updated: '2015-12-08 19:48:33.843000000',
 								        __draft: true,
 								      },
 								      {
 								        author: {
 								          name: 'Mr. Peanutbutter2',
 								          email: 'tenn1sballchaser@aol.com',
 								        },
 								        id: 1,
 								        line: 5,
 								        message: 'This comment was left last but is not a draft',
 								        updated: '2015-12-10 19:48:33.843000000',
 								      },
 								      {
 								        author: {
 								          name: 'Mr. Peanutbutter2',
 								          email: 'tenn1sballchaser@aol.com',
 								        },
 								        id: 3,
 								        line: 5,
 								        message: 'Later draft',
 								        updated: '2015-12-09 19:48:33.843000000',
 								        __draft: true,
 								      }];
 								      assert.equal(element._orderedComments[0].id, '1');
 								      assert.equal(element._orderedComments[1].id, '2');
 								      assert.equal(element._orderedComments[2].id, '3');
 								    });
-												[PolyGerrit] Render (read-only) comments and column width ruler.

Also some small additional changes as well:
+ Correct some :host selectors that were causing issues when Shadow DOM
  was used instead of Shady DOM.
+ Two of the same revisions should not be shown in side-by-side view.
  When two are specified via the url as /N..N/ redirect to /N/.
+ Added header to the diff view to give context and allow the user to
  go back to the top-level change.

Feature: Issue 3676
Feature: Issue 3648
Feature: Issue 3649
Change-Id: Ib39bb7cb2eab26740f80971d4e00d579a2e08b0b

											
										
										
											2015-11-18 16:31:18 -05:00
+								  });
 								</script>