opendev/gerrit
Code Issues Proposed changes

Remove 'send email' checkbox from reply box on change screen

Browse Source 
When replying to a change the 'send email' checkbox allowed to control
if the change update should trigger email notifications for other
users. This behaviour is bad for people who want to rely on email
notifications since it depends on the replying users whether they get
an email notification or not. By removing the 'send email' checkbox
people are again in control about their own email notifications, e.g.
by the watch settings they can configure which emails they want to
receive. Still suppressing email notifications via the REST API is
possible (and wanted, e.g. for CI jobs).

Change-Id: If11863da6020a1d5b7edc1ae1a1a60399b197267
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin 2014-07-16 13:56:17 +02:00
parent c1c2b10adf
commit 00aa3bfb97
4 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
Documentation/images/user-review-ui-change-screen-replying.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 55 KiB

After

Width:  |  Height:  |  Size: 54 KiB

5
Documentation/user-review-ui.txt
View File

@ -602,11 +602,6 @@ comment needs to be edited.
The `Post` button publishes the comments and the votes.
The `send email` checkbox controls whether the reply should trigger
email notifications for other users. Deselecting the checkbox means
that there will be no email notification about the change update to the
change author, the reviewers or any other user.
image::images/user-review-ui-change-screen-replying.png[width=800, link="images/user-review-ui-change-screen-replying.png"]
If a user can approve a label that is still required, a quick approve

10
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java
View File

@ -99,7 +99,6 @@ class ReplyBox extends Composite {
@UiField Element labelsParent;
@UiField Grid labelsTable;
@UiField Button post;
@UiField CheckBox email;
@UiField Button cancel;
@UiField ScrollPanel commentsPanel;
@UiField FlowPanel comments;
@ -188,15 +187,6 @@ class ReplyBox extends Composite {
}
}
@UiHandler("email")
void onEmail(ValueChangeEvent<Boolean> e) {
if (e.getValue()) {
in.notify(ReviewInput.NotifyHandling.ALL);
} else {
in.notify(ReviewInput.NotifyHandling.NONE);
}
}
@UiHandler("post")
void onPost(ClickEvent e) {
postReview();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.ui.xml
View File

@ -68,7 +68,7 @@ limitations under the License.
styleName='{res.style.button}'>
<ui:attribute name='title'/>
<div>Post</div>
</g:Button> and <g:CheckBox ui:field='email' value='true'>send email</g:CheckBox></ui:msg>
</g:Button></ui:msg>
<g:Button ui:field='cancel'
title='Close reply form (Shortcut: Esc)'