opendev/gerrit
Code Issues Proposed changes

Fix eclipse classpath generation

Browse Source 
//proto/testing:test_java_proto dependency has to be built for the
eclipse classpath generation to work properly.

Test Plan:

1. Make sure the final artifact is removed (or not built):

  $ rm bazel-out/darwin-fastbuild/bin/proto/testing/libtest_proto-speed.jar

2. Generate eclipse classpath:

  $ ./tools/eclipse/project.py

3. Confirm that the generated artifact is created as expected:

  $ ls bazel-out/darwin-fastbuild/bin/proto/testing/libtest_proto-speed.jar

Change-Id: I19562383d99728030a2205aff9a31060409b2860
This commit is contained in:
David Ostrovsky
2019-04-12 14:48:17 -07:00
committed by David Ostrovsky
parent 3ccbf4fdc5
commit 0497b39d4c
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tools/eclipse/BUILD
View File

@@ -10,6 +10,9 @@ load(
TEST_DEPS = [
"//javatests/com/google/gerrit/elasticsearch:elasticsearch_test_utils",
"//javatests/com/google/gerrit/server:server_tests",
]
TEST_DEPS_GENERATED = [
"//proto/testing:test_java_proto",
]
@@ -27,13 +30,13 @@ DEPS = [
java_library(
name = "classpath",
testonly = True,
runtime_deps = LIBS + PGMLIBS + DEPS,
runtime_deps = LIBS + PGMLIBS + DEPS + TEST_DEPS_GENERATED,
)
classpath_collector(
name = "main_classpath_collect",
testonly = True,
deps = LIBS + PGMLIBS + DEPS + TEST_DEPS +
deps = LIBS + PGMLIBS + DEPS + TEST_DEPS + TEST_DEPS_GENERATED +
["//plugins/%s:%s__plugin" % (n, n) for n in CORE_PLUGINS + CUSTOM_PLUGINS] +
["//plugins/%s:%s__plugin_test_deps" % (n, n) for n in CUSTOM_PLUGINS_TEST_DEPS],
)