opendev/gerrit
Code Issues Proposed changes

CommitValidators: Fix repeated "Change-Id" in error message

Browse Source 
If a change is pushed without a Change-Id footer, but with a potential
Change-Id line somewhere else in the body of the commit message, the
error message says:

    Hint: A potential Change-IdChange-Id was found, but it was not
    in the footer (last paragraph) of the commit message.

i.e. with repeated "Change-Id" in the first line.

Change-Id: I035e20b72b0b48b090a9183310f3460f97755d00
This commit is contained in:
David Pursehouse
2018-07-06 16:15:50 +09:00
parent e0c059c242
commit 049ea3935d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java
View File

@@ -295,7 +295,7 @@ public class CommitValidators {
sb.append('\n');
sb.append("Hint: A potential ");
sb.append(FooterConstants.CHANGE_ID.getName());
sb.append("Change-Id was found, but it was not in the ");
sb.append(" was found, but it was not in the ");
sb.append("footer (last paragraph) of the commit message.");
}
}