Use sentence case for names of options

Continue to use title case for titles/section titles.

Bug: Issue 5685
Change-Id: I848a3277f80d9959ff1cbbe78b2368d1e3c87e0f
This commit is contained in:
Becky Siegel
2017-03-13 14:23:48 -07:00
parent 92e4362613
commit 07c8a169d6
7 changed files with 57 additions and 57 deletions

View File

@@ -87,7 +87,7 @@ limitations under the License.
</select>
</div>
<div class="pref">
<label for="lineWrappingInput">Fit to Screen</label>
<label for="lineWrappingInput">Fit to screen</label>
<input
is="iron-input"
type="checkbox"
@@ -95,7 +95,7 @@ limitations under the License.
on-tap="_handlelineWrappingTap">
</div>
<div class="pref" id="columnsPref" hidden$="[[_newPrefs.line_wrapping]]">
<label for="columnsInput">Diff Width</label>
<label for="columnsInput">Diff width</label>
<input is="iron-input" type="number" id="columnsInput"
prevent-invalid-input
allowed-pattern="[0-9]"
@@ -109,7 +109,7 @@ limitations under the License.
bind-value="{{_newPrefs.tab_size}}">
</div>
<div class="pref" hidden$="[[!_newPrefs.font_size]]">
<label for="fontSizeInput">Font Size</label>
<label for="fontSizeInput">Font size</label>
<input is="iron-input" type="number" id="fontSizeInput"
prevent-invalid-input
allowed-pattern="[0-9]"
@@ -121,7 +121,7 @@ limitations under the License.
on-tap="_handleShowTabsTap">
</div>
<div class="pref">
<label for="showTrailingWhitespaceInput">Show Trailing Whitespace</label>
<label for="showTrailingWhitespaceInput">Show trailing whitespace</label>
<input is="iron-input" type="checkbox" id="showTrailingWhitespaceInput"
on-tap="_handleShowTrailingWhitespaceTap">
</div>

View File

@@ -46,7 +46,7 @@ limitations under the License.
<span class="value">[[_account.username]]</span>
</section>
<section id="nameSection">
<span class="title">Full Name</span>
<span class="title">Full name</span>
<span
hidden$="[[mutable]]"
class="value">[[_account.name]]</span>

View File

@@ -39,7 +39,7 @@ limitations under the License.
<tr>
<th class="nameHeader">Name</th>
<th class="descriptionHeader">Description</th>
<th>Visible to All</th>
<th>Visible to all</th>
</tr>
</thead>
<tbody>

View File

@@ -54,7 +54,7 @@ limitations under the License.
</section>
<gr-button
id="generateButton"
on-tap="_handleGenerateTap">Generate New Password</gr-button>
on-tap="_handleGenerateTap">Generate new password</gr-button>
</div>
<gr-overlay
id="generatedPasswordOverlay"

View File

@@ -123,14 +123,14 @@ limitations under the License.
<gr-button
on-tap="_handleSaveAccountInfo"
hidden$="[[!_accountInfoMutable]]"
disabled="[[!_accountInfoChanged]]">Save Changes</gr-button>
disabled="[[!_accountInfoChanged]]">Save changes</gr-button>
</fieldset>
<h2
id="Preferences"
class$="[[_computeHeaderClass(_prefsChanged)]]">Preferences</h2>
<fieldset id="preferences">
<section>
<span class="title">Changes Per Page</span>
<span class="title">Changes per page</span>
<span class="value">
<select
is="gr-select"
@@ -143,7 +143,7 @@ limitations under the License.
</span>
</section>
<section>
<span class="title">Date/Time Format</span>
<span class="title">Date/time format</span>
<span class="value">
<select
is="gr-select"
@@ -163,41 +163,41 @@ limitations under the License.
</span>
</section>
<section>
<span class="title">Email Notifications</span>
<span class="title">Email notifications</span>
<span class="value">
<select
is="gr-select"
bind-value="{{_localPrefs.email_strategy}}">
<option value="CC_ON_OWN_COMMENTS">Every Comment</option>
<option value="ENABLED">Only Comments Left By Others</option>
<option value="CC_ON_OWN_COMMENTS">Every comment</option>
<option value="ENABLED">Only comments left by others</option>
<option value="DISABLED">None</option>
</select>
</span>
</section>
<section hidden$="[[!_localPrefs.email_format]]">
<span class="title">Email Format</span>
<span class="title">Email format</span>
<span class="value">
<select
is="gr-select"
bind-value="{{_localPrefs.email_format}}">
<option value="HTML_PLAINTEXT">HTML and Plaintext</option>
<option value="PLAINTEXT">Plaintext Only</option>
<option value="HTML_PLAINTEXT">HTML and plaintext</option>
<option value="PLAINTEXT">Plaintext only</option>
</select>
</span>
</section>
<section>
<span class="title">Diff View</span>
<span class="title">Diff view</span>
<span class="value">
<select
is="gr-select"
bind-value="{{_localPrefs.diff_view}}">
<option value="SIDE_BY_SIDE">Side by Side</option>
<option value="UNIFIED_DIFF">Unified Diff</option>
<option value="SIDE_BY_SIDE">Side by side</option>
<option value="UNIFIED_DIFF">Unified diff</option>
</select>
</span>
</section>
<section>
<span class="title">Expand Inline Diffs</span>
<span class="title">Expand inline diffs</span>
<span class="value">
<input
id="expandInlineDiffs"
@@ -209,7 +209,7 @@ limitations under the License.
<gr-button
id="savePrefs"
on-tap="_handleSavePreferences"
disabled="[[!_prefsChanged]]">Save Changes</gr-button>
disabled="[[!_prefsChanged]]">Save changes</gr-button>
</fieldset>
<h2
id="DiffPreferences"
@@ -234,7 +234,7 @@ limitations under the License.
</span>
</section>
<section>
<span class="title">Fit to Screen</span>
<span class="title">Fit to screen</span>
<span class="value">
<input
id="lineWrapping"
@@ -244,7 +244,7 @@ limitations under the License.
</span>
</section>
<section id="columnsPref" hidden$="[[_diffPrefs.line_wrapping]]">
<span class="title">Diff Width</span>
<span class="title">Diff width</span>
<span class="value">
<input
is="iron-input"
@@ -255,7 +255,7 @@ limitations under the License.
</span>
</section>
<section>
<span class="title">Tab Width</span>
<span class="title">Tab width</span>
<span class="value">
<input
is="iron-input"
@@ -266,7 +266,7 @@ limitations under the License.
</span>
</section>
<section hidden$="[[!_diffPrefs.font_size]]">
<span class="title">Font Size</span>
<span class="title">Font size</span>
<span class="value">
<input
is="iron-input"
@@ -277,7 +277,7 @@ limitations under the License.
</span>
</section>
<section>
<span class="title">Show Tabs</span>
<span class="title">Show tabs</span>
<span class="value">
<input
id="showTabs"
@@ -287,7 +287,7 @@ limitations under the License.
</span>
</section>
<section>
<span class="title">Show Trailing Whitespace</span>
<span class="title">Show trailing whitespace</span>
<span class="value">
<input
id="showTrailingWhitespace"
@@ -297,7 +297,7 @@ limitations under the License.
</span>
</section>
<section>
<span class="title">Syntax Highlighting</span>
<span class="title">Syntax highlighting</span>
<span class="value">
<input
id="syntaxHighlighting"
@@ -309,7 +309,7 @@ limitations under the License.
<gr-button
id="saveDiffPrefs"
on-tap="_handleSaveDiffPreferences"
disabled$="[[!_diffPrefsChanged]]">Save Changes</gr-button>
disabled$="[[!_diffPrefsChanged]]">Save changes</gr-button>
</fieldset>
<h2 id="Menu" class$="[[_computeHeaderClass(_menuChanged)]]">Menu</h2>
<fieldset id="menu">
@@ -317,7 +317,7 @@ limitations under the License.
<gr-button
id="saveMenu"
on-tap="_handleSaveMenu"
disabled="[[!_menuChanged]]">Save Changes</gr-button>
disabled="[[!_menuChanged]]">Save changes</gr-button>
</fieldset>
<h2 id="ChangeTableColumns"
class$="[[_computeHeaderClass(_changeTableChanged)]]">
@@ -330,7 +330,7 @@ limitations under the License.
<gr-button
id="saveChangeTable"
on-tap="_handleSaveChangeTable"
disabled="[[!_changeTableChanged]]">Save Changes</gr-button>
disabled="[[!_changeTableChanged]]">Save changes</gr-button>
</fieldset>
<h2
id="Notifications"
@@ -344,7 +344,7 @@ limitations under the License.
<gr-button
on-tap="_handleSaveWatchedProjects"
disabled$="[[!_watchedProjectsChanged]]"
id="_handleSaveWatchedProjects">Save Changes</gr-button>
id="_handleSaveWatchedProjects">Save changes</gr-button>
</fieldset>
<h2
id="EmailAddresses"
@@ -357,11 +357,11 @@ limitations under the License.
has-unsaved-changes="{{_emailsChanged}}"></gr-email-editor>
<gr-button
on-tap="_handleSaveEmails"
disabled$="[[!_emailsChanged]]">Save Changes</gr-button>
disabled$="[[!_emailsChanged]]">Save changes</gr-button>
</fieldset>
<fieldset id="newEmail">
<section>
<span class="title">New Email Address</span>
<span class="title">New email address</span>
<span class="value">
<input
id="newEmailInput"
@@ -383,7 +383,7 @@ limitations under the License.
</section>
<gr-button
disabled="[[!_computeAddEmailButtonEnabled(_newEmail, _addingEmail)]]"
on-tap="_handleAddEmailButton">Send Verification</gr-button>
on-tap="_handleAddEmailButton">Send verification</gr-button>
</fieldset>
<h2 id="HTTPCredentials">HTTP Credentials</h2>
<fieldset>
@@ -392,7 +392,7 @@ limitations under the License.
<div hidden$="[[!_serverConfig.sshd]]">
<h2
id="SSHKeys"
class$="[[_computeHeaderClass(_keysChanged)]]">SSH Keys</h2>
class$="[[_computeHeaderClass(_keysChanged)]]">SSH keys</h2>
<gr-ssh-editor
id="sshEditor"
has-unsaved-changes="{{_keysChanged}}"></gr-ssh-editor>

View File

@@ -155,30 +155,30 @@ limitations under the License.
test('user preferences', function(done) {
// Rendered with the expected preferences selected.
assert.equal(valueOf('Changes Per Page', 'preferences')
assert.equal(valueOf('Changes per page', 'preferences')
.firstElementChild.bindValue, preferences.changes_per_page);
assert.equal(valueOf('Date/Time Format', 'preferences')
assert.equal(valueOf('Date/time format', 'preferences')
.firstElementChild.bindValue, preferences.date_format);
assert.equal(valueOf('Date/Time Format', 'preferences')
assert.equal(valueOf('Date/time format', 'preferences')
.lastElementChild.bindValue, preferences.time_format);
assert.equal(valueOf('Email Notifications', 'preferences')
assert.equal(valueOf('Email notifications', 'preferences')
.firstElementChild.bindValue, preferences.email_strategy);
assert.equal(valueOf('Email Format', 'preferences')
assert.equal(valueOf('Email format', 'preferences')
.firstElementChild.bindValue, preferences.email_format);
assert.equal(valueOf('Diff View', 'preferences')
assert.equal(valueOf('Diff view', 'preferences')
.firstElementChild.bindValue, preferences.diff_view);
assert.equal(valueOf('Expand Inline Diffs', 'preferences')
assert.equal(valueOf('Expand inline diffs', 'preferences')
.firstElementChild.checked, false);
assert.isFalse(element._prefsChanged);
assert.isFalse(element._menuChanged);
// Change the diff view element.
var diffSelect = valueOf('Diff View', 'preferences').firstElementChild;
var diffSelect = valueOf('Diff view', 'preferences').firstElementChild;
diffSelect.bindValue = 'SIDE_BY_SIDE';
var expandInlineDiffs =
valueOf('Expand Inline Diffs', 'preferences').firstElementChild;
valueOf('Expand inline diffs', 'preferences').firstElementChild;
diffSelect.fire('change');
MockInteractions.tap(expandInlineDiffs);
@@ -207,22 +207,22 @@ limitations under the License.
// Rendered with the expected preferences selected.
assert.equal(valueOf('Context', 'diffPreferences')
.firstElementChild.bindValue, diffPreferences.context);
assert.equal(valueOf('Diff Width', 'diffPreferences')
assert.equal(valueOf('Diff width', 'diffPreferences')
.firstElementChild.bindValue, diffPreferences.line_length);
assert.equal(valueOf('Tab Width', 'diffPreferences')
assert.equal(valueOf('Tab width', 'diffPreferences')
.firstElementChild.bindValue, diffPreferences.tab_size);
assert.equal(valueOf('Font Size', 'diffPreferences')
assert.equal(valueOf('Font size', 'diffPreferences')
.firstElementChild.bindValue, diffPreferences.font_size);
assert.equal(valueOf('Show Tabs', 'diffPreferences')
assert.equal(valueOf('Show tabs', 'diffPreferences')
.firstElementChild.checked, diffPreferences.show_tabs);
assert.equal(valueOf('Show Trailing Whitespace', 'diffPreferences')
assert.equal(valueOf('Show trailing whitespace', 'diffPreferences')
.firstElementChild.checked, diffPreferences.show_whitespace_errors);
assert.equal(valueOf('Fit to Screen', 'diffPreferences')
assert.equal(valueOf('Fit to screen', 'diffPreferences')
.firstElementChild.checked, diffPreferences.line_wrapping);
assert.isFalse(element._diffPrefsChanged);
var showTabsCheckbox = valueOf('Show Tabs', 'diffPreferences')
var showTabsCheckbox = valueOf('Show tabs', 'diffPreferences')
.firstElementChild;
showTabsCheckbox.checked = false;
element._handleShowTabsChanged();

View File

@@ -57,7 +57,7 @@ limitations under the License.
<tr>
<th class="commentHeader">Comment</th>
<th class="statusHeader">Status</th>
<th class="keyHeader">Public Key</th>
<th class="keyHeader">Public key</th>
</tr>
</thead>
<tbody>
@@ -87,7 +87,7 @@ limitations under the License.
<span class="value">[[_keyToView.algorithm]]</span>
</section>
<section>
<span class="title">Public Key</span>
<span class="title">Public key</span>
<span class="value publicKey">[[_keyToView.encoded_key]]</span>
</section>
<section>
@@ -101,11 +101,11 @@ limitations under the License.
</gr-overlay>
<gr-button
on-tap="save"
disabled$="[[!hasUnsavedChanges]]">Save Changes</gr-button>
disabled$="[[!hasUnsavedChanges]]">Save changes</gr-button>
</fieldset>
<fieldset>
<section>
<span class="title">New SSH Key</span>
<span class="title">New SSH key</span>
<span class="value">
<iron-autogrow-textarea
id="newKey"
@@ -117,7 +117,7 @@ limitations under the License.
<gr-button
id="addButton"
disabled$="[[_computeAddButtonDisabled(_newKey)]]"
on-tap="_handleAddKey">Add New SSH Key</gr-button>
on-tap="_handleAddKey">Add new SSH key</gr-button>
</fieldset>
</div>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>