opendev/gerrit
Code Issues Proposed changes

Create profiles for fast single-browser builds

Browse Source 
Support fast dev cycle through maven profiles that build GWT for specific
browser user agents.

To build for only webkit based browsers you can now do:
mvn package -Psafari

Change-Id: I1d7ca64413cb6e2d937e2a3a09f53bf1a9e2ffbc
This commit is contained in:
Nasser Grainawi
2011-05-17 13:14:21 -07:00
parent 6b14d92374
commit 0908bff975
3 changed files with 69 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
gerrit-gwtui/pom.xml
View File

@@ -137,17 +137,45 @@ limitations under the License.
</dependency>
</dependencies>
<profiles>
<profile>
<id>all</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<properties>
<GerritGwtUI.browserType>com.google.gerrit.GerritGwtUI</GerritGwtUI.browserType>
<GerritGwtUI.draftCompile>false</GerritGwtUI.draftCompile>
</properties>
</profile>
<profile>
<id>safari</id>
<properties>
<GerritGwtUI.browserType>com.google.gerrit.GerritGwtUIsafari</GerritGwtUI.browserType>
<GerritGwtUI.draftCompile>true</GerritGwtUI.draftCompile>
</properties>
</profile>
<profile>
<id>gecko1_8</id>
<properties>
<GerritGwtUI.browserType>com.google.gerrit.GerritGwtUIgecko1_8</GerritGwtUI.browserType>
<GerritGwtUI.draftCompile>true</GerritGwtUI.draftCompile>
</properties>
</profile>
</profiles>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>gwt-maven-plugin</artifactId>
<configuration>
<module>com.google.gerrit.GerritGwtUI</module>
<module>${GerritGwtUI.browserType}</module>
<extraJvmArgs>-Xmx512m</extraJvmArgs>
<compileReport>${gwt.compileReport}</compileReport>
<disableClassMetadata>true</disableClassMetadata>
<disableCastChecking>true</disableCastChecking>
<draftCompile>${GerritGwtUI.draftCompile}</draftCompile>
</configuration>
<executions>
<execution>

20
gerrit-gwtui/src/main/java/com/google/gerrit/GerritGwtUIgecko1_8.gwt.xml Normal file
View File

@@ -0,0 +1,20 @@
<!--
Copyright (C) 2011 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<module rename-to="gerrit">
<inherits name='com.google.gerrit.GerritGwtUI'/>
<set-property name="user.agent" value="gecko1_8" />
<set-property name="locale" value="default" />
</module>

20
gerrit-gwtui/src/main/java/com/google/gerrit/GerritGwtUIsafari.gwt.xml Normal file
View File

@@ -0,0 +1,20 @@
<!--
Copyright (C) 2011 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<module rename-to="gerrit">
<inherits name='com.google.gerrit.GerritGwtUI'/>
<set-property name="user.agent" value="safari" />
<set-property name="locale" value="default" />
</module>