opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-2.14'

Browse Source 
* stable-2.14:
  EditPreferencesBox: Format with google-java-format
  Add missing exception declarations on methods in NotImplemented

Change-Id: I418aaba62ca0c00410efc6782602d0194a5eafde
This commit is contained in:
David Pursehouse
2017-07-03 10:49:56 +09:00
parent ca3da60f42 d9d3135df9
commit 0a451e88e2
3 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ChangeEditApi.java
View File

@@ -156,67 +156,67 @@ public interface ChangeEditApi {
*/ */
class NotImplemented implements ChangeEditApi { class NotImplemented implements ChangeEditApi {
@Override @Override
public Optional<EditInfo> get() { public Optional<EditInfo> get() throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public void create() { public void create() throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public void delete() { public void delete() throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public void rebase() { public void rebase() throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public void publish() { public void publish() throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public void publish(PublishChangeEditInput publishChangeEditInput) { public void publish(PublishChangeEditInput publishChangeEditInput) throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public Optional<BinaryResult> getFile(String filePath) { public Optional<BinaryResult> getFile(String filePath) throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public void renameFile(String oldFilePath, String newFilePath) { public void renameFile(String oldFilePath, String newFilePath) throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public void restoreFile(String filePath) { public void restoreFile(String filePath) throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public void modifyFile(String filePath, RawInput newContent) { public void modifyFile(String filePath, RawInput newContent) throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public void deleteFile(String filePath) { public void deleteFile(String filePath) throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public String getCommitMessage() { public String getCommitMessage() throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
@Override @Override
public void modifyCommitMessage(String newCommitMessage) { public void modifyCommitMessage(String newCommitMessage) throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }
} }

2
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/ProjectApi.java
View File

@@ -193,7 +193,7 @@ public interface ProjectApi {
} }
@Override @Override
public List<ProjectInfo> children() { public List<ProjectInfo> children() throws RestApiException {
throw new NotImplementedException(); throw new NotImplementedException();
} }

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditPreferencesBox.java
View File

@@ -225,7 +225,6 @@ public class EditPreferencesBox extends Composite {
} }
} }
@UiHandler("autoCloseBrackets") @UiHandler("autoCloseBrackets")
void onCloseBrackets(ValueChangeEvent<Boolean> e) { void onCloseBrackets(ValueChangeEvent<Boolean> e) {
prefs.autoCloseBrackets(e.getValue()); prefs.autoCloseBrackets(e.getValue());