opendev/gerrit
Code Issues Proposed changes

Merge "ChangeInserter: fix comparison of Change.Id to Change.Key" into stable-2.9

Browse Source
This commit is contained in:
Edwin Kempin
2014-06-30 09:38:15 +00:00
committed by Gerrit Code Review
parent 5f10081645 8babe2be7f
commit 0b6e03f6be
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeInserter.java
View File

@@ -214,8 +214,12 @@ public class ChangeInserter {
}
private boolean messageIsForChange() {
return changeMessage != null
&& changeMessage.getKey().getParentKey().equals(change.getKey());
if (changeMessage == null) {
return false;
}
Change.Id id = change.getId();
Change.Id msgId = changeMessage.getKey().getParentKey();
return msgId.equals(id);
}
private void insertMessage(ReviewDb db) throws OrmException {