opendev/gerrit
Code Issues Proposed changes

Return only project description on PUT on '/projects/*/description'

Browse Source 
In a REST API the result of PUT on a URL should generally be the same
as the result of a GET on the URL after the PUT was completed.

Since GET on '/projects/*/description' returns only the project
description, PUT on '/projects/*/description' should also only return
the project description.

Change-Id: I3a12e94435e8618ef5f6486ec8e6891294f08159
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-01-29 13:21:14 +01:00
parent a0610125bd
commit 0b97f267e8
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-server/src/main/java/com/google/gerrit/server/project/SetDescription.java
View File

@@ -54,7 +54,7 @@ class SetDescription implements RestModifyView<ProjectResource, Input> {
}
@Override
public Object apply(ProjectResource resource, Input input)
public String apply(ProjectResource resource, Input input)
throws AuthException, BadRequestException, ResourceConflictException,
Exception {
if (input == null) {
@@ -88,11 +88,7 @@ class SetDescription implements RestModifyView<ProjectResource, Input> {
resource.getNameKey(),
project.getDescription());
ListProjects.ProjectInfo info = new ListProjects.ProjectInfo();
info.setName(resource.getName());
info.parent = project.getParentName();
info.description = project.getDescription();
return info;
return project.getDescription();
} finally {
md.close();
}