opendev/gerrit
Code Issues Proposed changes

Remove unnecessary type cast

Browse Source 
Change-Id: I1a2f25032a829ac7721a1689398cf1490ac60801
This commit is contained in:
alex.ryazantsev 2013-11-15 00:36:14 +04:00
parent 5cf89bc928
commit 0d7a9e0875
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SidePanel.java
View File

@ -114,7 +114,7 @@ class SidePanel extends Composite {
Label gutter = wrapper.gutter;
final double height = cm.heightAtLine(line, "local");
final double scrollbarHeight = cmB.getScrollbarV().getClientHeight();
double top = height / (double) cmB.getSizer().getClientHeight() *
double top = height / cmB.getSizer().getClientHeight() *
scrollbarHeight +
cmB.getScrollbarV().getAbsoluteTop();
if (top == 0) {

2
gerrit-server/src/main/java/com/google/gerrit/server/git/RebaseSorter.java
View File

@ -64,7 +64,7 @@ class RebaseSorter {
n.statusCode = CommitMergeStatus.MISSING_DEPENDENCY;
n.missing = new ArrayList<CodeReviewCommit>();
}
n.missing.add((CodeReviewCommit) c);
n.missing.add(c);
} else {
contents.add(c);
}

2
gerrit-server/src/main/java/com/google/gerrit/server/query/change/IsVisibleToPredicate.java
View File

@ -30,7 +30,7 @@ class IsVisibleToPredicate extends OperatorPredicate<ChangeData> {
return ((IdentifiedUser) user).getAccountId().toString();
}
if (user instanceof SingleGroupUser) {
return "group:" + ((SingleGroupUser) user).getEffectiveGroups().getKnownGroups() //
return "group:" + user.getEffectiveGroups().getKnownGroups() //
.iterator().next().toString();
}
return user.toString();

4
gerrit-sshd/src/main/java/com/google/gerrit/sshd/CommandModule.java
View File

@ -72,7 +72,7 @@ public abstract class CommandModule extends LifecycleModule {
*/
protected void command(final CommandName parent,
final Class<? extends BaseCommand> clazz) {
CommandMetaData meta = (CommandMetaData)clazz.getAnnotation(CommandMetaData.class);
CommandMetaData meta = clazz.getAnnotation(CommandMetaData.class);
if (meta == null) {
throw new IllegalStateException("no CommandMetaData annotation found");
}
@ -91,7 +91,7 @@ public abstract class CommandModule extends LifecycleModule {
*/
protected void alias(final CommandName parent, final String name,
final Class<? extends BaseCommand> clazz) {
CommandMetaData meta = (CommandMetaData)clazz.getAnnotation(CommandMetaData.class);
CommandMetaData meta = clazz.getAnnotation(CommandMetaData.class);
if (meta == null) {
throw new IllegalStateException("no CommandMetaData annotation found");
}