opendev/gerrit
Code Issues Proposed changes

AbstractQueryChangesTest: Make dashboard constants final

Browse Source 
The field names are CONSTANT_CASE, but the fields were not static and
final.

Change-Id: If7b6171b11caf0249d91f52465444d7b981ea13d
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2017-12-11 10:48:45 +01:00
parent e4a2817509
commit 0ef04fcf7a
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java
View File

@@ -188,11 +188,12 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests {
// These queries must be kept in sync with PolyGerrit:
// polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js
protected static String DASHBOARD_WORK_IN_PROGRESS_QUERY = "is:open owner:${user} is:wip";
protected static String DASHBOARD_OUTGOING_QUERY = "is:open owner:${user} -is:wip -is:ignored";
protected static String DASHBOARD_INCOMING_QUERY =
protected static final String DASHBOARD_WORK_IN_PROGRESS_QUERY = "is:open owner:${user} is:wip";
protected static final String DASHBOARD_OUTGOING_QUERY =
"is:open owner:${user} -is:wip -is:ignored";
protected static final String DASHBOARD_INCOMING_QUERY =
"is:open -owner:${user} -is:wip -is:ignored (reviewer:${user} OR assignee:${user})";
protected static String DASHBOARD_RECENTLY_CLOSED_QUERY =
protected static final String DASHBOARD_RECENTLY_CLOSED_QUERY =
"is:closed -is:ignored (-is:wip OR owner:self) "
+ "(owner:${user} OR reviewer:${user} OR assignee:${user})";