opendev/gerrit
Code Issues Proposed changes

Fix: select doesn't work in gr-autocomplete

Browse Source 
In Polymer 2 selectAll doesn't work, because inputElement
is not a native input. nativeInput is a replacement for Polymer 2.

Bug: Issue 11585
Change-Id: Ib22164cc33d387013b10d6c679626b3825030002
This commit is contained in:
Dmitrii Filippov
2019-09-24 17:55:31 +02:00
parent 80bb5260e9
commit 11250c3293
2 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.js
View File

@@ -177,6 +177,11 @@
'_updateSuggestions(text, threshold, noDebounce)',
],
get _nativeInput() {
// In Polymer 2 inputElement isn't nativeInput anymore
return this.$.input.$.nativeInput || this.$.input.inputElement;
},
attached() {
this.listen(document.body, 'tap', '_handleBodyTap');
},
@@ -195,7 +200,7 @@
},
selectAll() {
const nativeInputElement = this.$.input.inputElement;
const nativeInputElement = this._nativeInput;
if (!this.$.input.value) { return; }
nativeInputElement.setSelectionRange(0, this.$.input.value.length);
},

19
polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete_test.html
View File

@@ -82,16 +82,19 @@ limitations under the License.
});
});
test('selectAll', () => {
const nativeInput = element.$.input.inputElement;
const selectionStub = sandbox.stub(nativeInput, 'setSelectionRange');
test('selectAll', done => {
flush(() => {
const nativeInput = element._nativeInput;
const selectionStub = sandbox.stub(nativeInput, 'setSelectionRange');
element.selectAll();
assert.isFalse(selectionStub.called);
element.selectAll();
assert.isFalse(selectionStub.called);
element.$.input.value = 'test';
element.selectAll();
assert.isTrue(selectionStub.called);
element.$.input.value = 'test';
element.selectAll();
assert.isTrue(selectionStub.called);
done();
});
});
test('esc key behavior', done => {