opendev/gerrit
Code Issues Proposed changes

Fix pure_revert prolog recipes.

Browse Source 
U /= 1 is invalid prolog. I believe a backslash was intended:
U \= 1 is valid prolog.
However, according to prolog-change-facts.txt, U is always either
1 or 0, so we can just replace U with 0.

Change-Id: I2234a9c825648d0c5dee9e304e66132e238384cf
This commit is contained in:
Gary Miguel 2019-02-07 09:39:37 -08:00 committed by David Pursehouse
parent cbbdb7108d
commit 141022f70c
1 changed files with 13 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
Documentation/prolog-cookbook.txt
View File

@ -1044,10 +1044,7 @@ submit_rule(submit(R)) :-
gerrit:uploader(U),
R = label('Is-Pure-Revert', ok(U)).
submit_rule(submit(R)) :-
gerrit:pure_revert(U),
U /= 1,
R = label('Is-Pure-Revert', need(_)).
submit_rule(submit(label('Is-Pure-Revert', need(_)))).
----
Suppose currently a change is submittable if it gets `+2` for `Code-Review`
@ -1058,21 +1055,20 @@ follows:
[source,prolog]
----
submit_rule(submit(CR, V, R)) :-
base(CR, V),
gerrit:pure_revert(1),
!,
gerrit:uploader(U),
R = label('Is-Pure-Revert', ok(U)).
submit_rule(submit(CR, V, R)) :-
base(CR, V),
gerrit:pure_revert(U),
U /= 1,
R = label('Is-Pure-Revert', need(_)).
base(CR, V),
set_pure_revert_label(R).
base(CR, V) :-
gerrit:max_with_block(-2, 2, 'Code-Review', CR),
gerrit:max_with_block(-1, 1, 'Verified', V).
gerrit:max_with_block(-2, 2, 'Code-Review', CR),
gerrit:max_with_block(-1, 1, 'Verified', V).
set_pure_revert_label(R) :-
gerrit:pure_revert(1),
!,
gerrit:uploader(U),
R = label('Is-Pure-Revert', ok(U)).
set_pure_revert_label(label('Is-Pure-Revert', need(_))).
----
Note that a new label as `Is-Pure-Revert` should not be configured.