Isolate httpd:war-init rule in httpd/init package

Change-Id: If1a29e9c7ee7529cb54d63ecb16d8e16c86644b2

java/com/google/gerrit/httpd/BUILD

@@ -1,62 +1,19 @@
-# TODO(davido): Consider to isolate war specific sources in its own package
-WAR_SRCS = [
-    "ReviewDbDataSourceProvider.java",
-    "SiteInitializer.java",
-    "SitePathFromSystemConfigProvider.java",
-    "UnzippedDistribution.java",
-    "WebAppInitializer.java",
-]
-
-DEPS = [
-    "//gerrit-server:receive",
-    "//gerrit-server:server",
-    "//java/com/google/gerrit/extensions:api",
-    "//java/com/google/gerrit/lifecycle",
-    "//java/com/google/gerrit/reviewdb:server",
-    "//lib:guava",
-    "//lib:gwtorm",
-    "//lib/guice",
-    "//lib/guice:guice-servlet",
-    "//lib/jgit/org.eclipse.jgit:jgit",
-    "//lib/log:api",
-]
-
-java_library(
-    name = "war-init",
-    srcs = WAR_SRCS,
-    visibility = ["//visibility:public"],
-    deps = DEPS + [
-        ":httpd",
-        "//gerrit-server:module",
-        "//java/com/google/gerrit/elasticsearch",
-        "//java/com/google/gerrit/gpg",
-        "//java/com/google/gerrit/httpd/auth/oauth",
-        "//java/com/google/gerrit/httpd/auth/openid",
-        "//java/com/google/gerrit/lucene",
-        "//java/com/google/gerrit/metrics/dropwizard",
-        "//java/com/google/gerrit/pgm/init",
-        "//java/com/google/gerrit/pgm/util",
-        "//java/com/google/gerrit/server/cache/h2",
-        "//java/com/google/gerrit/sshd",
-        "//lib:servlet-api-3_1",
-        "//prolog:gerrit-prolog-common",
-    ],
-)
-
 java_library(
     name = "httpd",
-    srcs = glob(
-        ["**/*.java"],
-        exclude = WAR_SRCS,
-    ),
+    srcs = glob(["**/*.java"]),
     resource_strip_prefix = "resources",
     resources = ["//resources/com/google/gerrit/httpd"],
     visibility = ["//visibility:public"],
-    deps = DEPS + [
+    deps = [
+        "//gerrit-server:receive",
+        "//gerrit-server:server",
         "//java/com/google/gerrit/common:annotations",
         "//java/com/google/gerrit/common:server",
+        "//java/com/google/gerrit/extensions:api",
         "//java/com/google/gerrit/launcher",
+        "//java/com/google/gerrit/lifecycle",
         "//java/com/google/gerrit/metrics",
+        "//java/com/google/gerrit/reviewdb:server",
         "//java/com/google/gerrit/util/cli",
         "//java/com/google/gerrit/util/http",
         "//java/com/google/gwtexpui/linker:server",
@@ -64,13 +21,19 @@ java_library(
         "//java/org/eclipse/jgit:server",
         "//lib:args4j",
         "//lib:gson",
+        "//lib:guava",
         "//lib:gwtjsonrpc",
+        "//lib:gwtorm",
         "//lib:jsch",
         "//lib:servlet-api-3_1",
         "//lib:soy",
         "//lib/auto:auto-value",
         "//lib/commons:codec",
+        "//lib/guice",
         "//lib/guice:guice-assistedinject",
+        "//lib/guice:guice-servlet",
         "//lib/jgit/org.eclipse.jgit.http.server:jgit-servlet",
+        "//lib/jgit/org.eclipse.jgit:jgit",
+        "//lib/log:api",
     ],
 )

java/com/google/gerrit/httpd/init/BUILD

@@ -0,0 +1,32 @@
+java_library(
+    name = "init",
+    srcs = glob(["**/*.java"]),
+    visibility = ["//visibility:public"],
+    deps = [
+        "//gerrit-server:module",
+        "//gerrit-server:receive",
+        "//gerrit-server:server",
+        "//java/com/google/gerrit/elasticsearch",
+        "//java/com/google/gerrit/extensions:api",
+        "//java/com/google/gerrit/gpg",
+        "//java/com/google/gerrit/httpd",
+        "//java/com/google/gerrit/httpd/auth/oauth",
+        "//java/com/google/gerrit/httpd/auth/openid",
+        "//java/com/google/gerrit/lifecycle",
+        "//java/com/google/gerrit/lucene",
+        "//java/com/google/gerrit/metrics/dropwizard",
+        "//java/com/google/gerrit/pgm/init",
+        "//java/com/google/gerrit/pgm/util",
+        "//java/com/google/gerrit/reviewdb:server",
+        "//java/com/google/gerrit/server/cache/h2",
+        "//java/com/google/gerrit/sshd",
+        "//lib:guava",
+        "//lib:gwtorm",
+        "//lib:servlet-api-3_1",
+        "//lib/guice",
+        "//lib/guice:guice-servlet",
+        "//lib/jgit/org.eclipse.jgit:jgit",
+        "//lib/log:api",
+        "//prolog:gerrit-prolog-common",
+    ],
+)

java/com/google/gerrit/httpd/init/ReviewDbDataSourceProvider.java

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package com.google.gerrit.httpd;
+package com.google.gerrit.httpd.init;
 
 import com.google.gerrit.extensions.events.LifecycleListener;
 import com.google.inject.Provider;

java/com/google/gerrit/httpd/init/SiteInitializer.java

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package com.google.gerrit.httpd;
+package com.google.gerrit.httpd.init;
 
 import com.google.gerrit.pgm.init.BaseInit;
 import com.google.gerrit.pgm.init.PluginsDistribution;

java/com/google/gerrit/httpd/init/SitePathFromSystemConfigProvider.java

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package com.google.gerrit.httpd;
+package com.google.gerrit.httpd.init;
 
 import com.google.gerrit.reviewdb.client.SystemConfig;
 import com.google.gerrit.reviewdb.server.ReviewDb;

java/com/google/gerrit/httpd/init/UnzippedDistribution.java

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package com.google.gerrit.httpd;
+package com.google.gerrit.httpd.init;
 
 import static com.google.gerrit.pgm.init.InitPlugins.JAR;
 import static com.google.gerrit.pgm.init.InitPlugins.PLUGIN_DIR;

java/com/google/gerrit/httpd/init/WebAppInitializer.java

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package com.google.gerrit.httpd;
+package com.google.gerrit.httpd.init;
 
 import static com.google.inject.Scopes.SINGLETON;
 import static com.google.inject.Stage.PRODUCTION;
@@ -22,6 +22,16 @@ import com.google.gerrit.common.EventBroker;
 import com.google.gerrit.elasticsearch.ElasticIndexModule;
 import com.google.gerrit.extensions.client.AuthType;
 import com.google.gerrit.gpg.GpgModule;
+import com.google.gerrit.httpd.AllRequestFilter;
+import com.google.gerrit.httpd.GetUserFilter;
+import com.google.gerrit.httpd.GitOverHttpModule;
+import com.google.gerrit.httpd.H2CacheBasedWebSession;
+import com.google.gerrit.httpd.HttpCanonicalWebUrlProvider;
+import com.google.gerrit.httpd.RequestContextFilter;
+import com.google.gerrit.httpd.RequestMetricsFilter;
+import com.google.gerrit.httpd.RequireSslFilter;
+import com.google.gerrit.httpd.WebModule;
+import com.google.gerrit.httpd.WebSshGlueModule;
 import com.google.gerrit.httpd.auth.oauth.OAuthModule;
 import com.google.gerrit.httpd.auth.openid.OpenIdModule;
 import com.google.gerrit.httpd.plugins.HttpPluginModule;

tools/bzl/pkg_war.bzl

@@ -18,7 +18,7 @@ jar_filetype = FileType([".jar"])
 
 LIBS = [
     "//java/com/google/gerrit/common:version",
-    "//java/com/google/gerrit/httpd:war-init",
+    "//java/com/google/gerrit/httpd/init",
     "//lib:postgresql",
     "//lib/bouncycastle:bcpkix",
     "//lib/bouncycastle:bcprov",