opendev/gerrit
Code Issues Proposed changes

Deprecate group owner in API

Browse Source 
With groups in NoteDb, we moved the explicit owner group of a group to
be reflected using permissions. With that, there can be multiple owners
of a group and the single owner attribute is no longer applicable.

Additionally, resolving from permissions to an 'owner' capability can be
hard due to the usage of ref patterns and permission inheritance.

Change-Id: I09fc04cbdf0d6e25def21e3a23bf6e35d44e912f
This commit is contained in:
Patrick Hiesel
2017-11-08 13:22:53 +01:00
parent b4a4c58120
commit 1f2c29fd1c
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Documentation/rest-api-groups.txt
View File

@@ -1516,8 +1516,8 @@ permits users to apply to join the group, or manage their membership.
|`options` ||link:#group-options-info[Options of the group]
|`description` |only for internal groups|The description of the group.
|`group_id` |only for internal groups|The numeric ID of the group.
|`owner` |only for internal groups|The name of the owner group.
|`owner_id` |only for internal groups|The URL encoded UUID of the owner group.
|`owner` |deprecated, only for internal groups|The name of the owner group.
|`owner_id` |deprecated, only for internal groups|The URL encoded UUID of the owner group.
|`created_on` |only for internal groups|The
link:rest-api.html#timestamp[timestamp] of when the group was created.
|`_more_groups`|optional, only for internal groups, not set if `false`|

4
java/com/google/gerrit/extensions/common/GroupInfo.java
View File

@@ -24,8 +24,8 @@ public class GroupInfo extends GroupBaseInfo {
// These fields are only supplied for internal groups.
public String description;
public Integer groupId;
public String owner;
public String ownerId;
@Deprecated public String owner;
@Deprecated public String ownerId;
public Timestamp createdOn;
public Boolean _moreGroups;