opendev/gerrit
Code Issues Proposed changes

GerritLauncher: Fix ClassNewInstance warning flagged by error prone

Browse Source 
The following warning is issued on the base version by error prone:

warning: [ClassNewInstance] Class.newInstance() bypasses exception
checking; prefer getConstructor().newInstance()
        res = main.invoke(clazz.newInstance(), new Object[] {argv});
                                           ^
    (see http://errorprone.info/bugpattern/ClassNewInstance)
  Did you mean 'res = main.invoke(clazz.getConstructor().newInstance(),
new Object[] {argv});'?

Change-Id: I669f2c58ef60257d1b10dca294cc14d5c60e6171
This commit is contained in:
David Ostrovsky 2017-02-18 12:57:40 +01:00 committed by David Pursehouse
parent a0cb16567a
commit 2634933198
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-launcher/src/main/java/com/google/gerrit/launcher/GerritLauncher.java
View File

@ -200,7 +200,7 @@ public final class GerritLauncher {
if ((main.getModifiers() & Modifier.STATIC) == Modifier.STATIC) {
res = main.invoke(null, new Object[] {argv});
} else {
res = main.invoke(clazz.newInstance(), new Object[] {argv});
res = main.invoke(clazz.getConstructor(new Class[] {}).newInstance(), new Object[] {argv});
}
} catch (InvocationTargetException ite) {
if (ite.getCause() instanceof Exception) {