opendev/gerrit
Code Issues Proposed changes

Actually return failure to clients if new change creation failed

Browse Source 
If a new change creation failed we were overwriting the result
with OK, which was wrong.  The client should know we rejected
the push as something failed our end.

Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-02-13 18:57:07 -08:00
parent 22d14b8885
commit 2761a28d3d
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/com/google/gerrit/server/ssh/Receive.java
View File

@@ -585,9 +585,11 @@ class Receive extends AbstractGitCommand {
} catch (IOException e) { } catch (IOException e) {
log.error("Error computing patch of commit " + c.name(), e); log.error("Error computing patch of commit " + c.name(), e);
reject(newChange, "diff error"); reject(newChange, "diff error");
return;
} catch (OrmException e) { } catch (OrmException e) {
log.error("Error creating change for commit " + c.name(), e); log.error("Error creating change for commit " + c.name(), e);
reject(newChange, "database error"); reject(newChange, "database error");
return;
} }
} }
newChange.setResult(ReceiveCommand.Result.OK); newChange.setResult(ReceiveCommand.Result.OK);