opendev/gerrit
Code Issues Proposed changes

Allow ; and & to seperate parameters in gitweb

Browse Source 
gitweb allows parameters seperated with & and ;
Gerrit fails if parameters are seperated with &
This small patch fixes this issue.

Change-Id: I216164d3bb6df6724c6fe7257a9c1d946a96520a
This commit is contained in:
Markus Heberling
2010-08-23 16:09:31 +02:00
committed by Shawn O. Pearce
parent 0d96f5b5b7
commit 2765ff9e5f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java
View File

@@ -354,7 +354,7 @@ class GitWebServlet extends HttpServlet {
private static Map<String, String> getParameters(final HttpServletRequest req)
throws UnsupportedEncodingException {
final Map<String, String> params = new HashMap<String, String>();
for (final String pair : req.getQueryString().split(";")) {
for (final String pair : req.getQueryString().split("[&;]")) {
final int eq = pair.indexOf('=');
if (0 < eq) {
String name = pair.substring(0, eq);