opendev/gerrit
Code Issues Proposed changes

Rename gr-confirm-dialog to gr-dialog

Browse Source 
The gr-dialog should serve as the basis for most (ideally all) dialogs
moving forward, in an effort to unify styling.

Bug: Issue 9543
Change-Id: If73c3a8f11cbd7a56763ed5b5ae1e9ad8caca730
This commit is contained in:
Kasper Nilsson
2018-08-09 10:19:07 -07:00
parent 11e2d9ca01
commit 2960db0adc
21 changed files with 71 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.html
View File

@@ -22,7 +22,7 @@ limitations under the License.
<link rel="import" href="../../../styles/gr-table-styles.html">
<link rel="import" href="../../../styles/shared-styles.html">
<link rel="import" href="../../core/gr-navigation/gr-navigation.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-list-view/gr-list-view.html">
<link rel="import" href="../../shared/gr-overlay/gr-overlay.html">
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
@@ -64,7 +64,7 @@ limitations under the License.
</table>
</gr-list-view>
<gr-overlay id="createOverlay" with-backdrop>
<gr-confirm-dialog
<gr-dialog
id="createDialog"
class="confirmDialog"
disabled="[[!_hasNewGroupName]]"
@@ -81,7 +81,7 @@ limitations under the License.
params="[[params]]"
id="createNewModal"></gr-create-group-dialog>
</div>
</gr-confirm-dialog>
</gr-dialog>
</gr-overlay>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>

6
polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.html
View File

@@ -16,7 +16,7 @@ limitations under the License.
-->
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../../styles/shared-styles.html">
<dom-module id="gr-confirm-delete-item-dialog">
@@ -27,7 +27,7 @@ limitations under the License.
width: 30em;
}
</style>
<gr-confirm-dialog
<gr-dialog
confirm-label="Delete [[_computeItemName(itemType)]]"
confirm-on-enter
on-confirm="_handleConfirmTap"
@@ -41,7 +41,7 @@ limitations under the License.
[[item]]
</div>
</div>
</gr-confirm-dialog>
</gr-dialog>
</template>
<script src="gr-confirm-delete-item-dialog.js"></script>
</dom-module>

4
polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog_test.html
View File

@@ -50,7 +50,7 @@ limitations under the License.
const confirmHandler = sandbox.stub();
element.addEventListener('confirm', confirmHandler);
sandbox.stub(element, '_handleConfirmTap');
element.$$('gr-confirm-dialog').fire('confirm');
element.$$('gr-dialog').fire('confirm');
assert.isTrue(confirmHandler.called);
assert.isTrue(element._handleConfirmTap.called);
});
@@ -59,7 +59,7 @@ limitations under the License.
const cancelHandler = sandbox.stub();
element.addEventListener('cancel', cancelHandler);
sandbox.stub(element, '_handleCancelTap');
element.$$('gr-confirm-dialog').fire('cancel');
element.$$('gr-dialog').fire('cancel');
assert.isTrue(cancelHandler.called);
assert.isTrue(element._handleCancelTap.called);
});

6
polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.html
View File

@@ -23,7 +23,7 @@ limitations under the License.
<link rel="import" href="../../../styles/shared-styles.html">
<link rel="import" href="../../plugins/gr-endpoint-decorator/gr-endpoint-decorator.html">
<link rel="import" href="../../plugins/gr-endpoint-param/gr-endpoint-param.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-overlay/gr-overlay.html">
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
<link rel="import" href="../gr-create-change-dialog/gr-create-change-dialog.html">
@@ -64,7 +64,7 @@ limitations under the License.
</div>
</main>
<gr-overlay id="createChangeOverlay" with-backdrop>
<gr-confirm-dialog
<gr-dialog
id="createChangeDialog"
confirm-label="Create"
disabled="[[!_canCreate]]"
@@ -79,7 +79,7 @@ limitations under the License.
can-create="{{_canCreate}}"
repo-name="[[repo]]"></gr-create-change-dialog>
</div>
</gr-confirm-dialog>
</gr-dialog>
</gr-overlay>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>

5
polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.html
View File

@@ -25,6 +25,7 @@ limitations under the License.
<link rel="import" href="../../shared/gr-account-link/gr-account-link.html">
<link rel="import" href="../../shared/gr-button/gr-button.html">
<link rel="import" href="../../shared/gr-date-formatter/gr-date-formatter.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-list-view/gr-list-view.html">
<link rel="import" href="../../shared/gr-overlay/gr-overlay.html">
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
@@ -189,7 +190,7 @@ limitations under the License.
</gr-overlay>
</gr-list-view>
<gr-overlay id="createOverlay" with-backdrop>
<gr-confirm-dialog
<gr-dialog
id="createDialog"
disabled="[[!_hasNewItemName]]"
confirm-label="Create"
@@ -206,7 +207,7 @@ limitations under the License.
item-detail="[[detailType]]"
repo-name="[[_repo]]"></gr-create-pointer-dialog>
</div>
</gr-confirm-dialog>
</gr-dialog>
</gr-overlay>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>

6
polygerrit-ui/app/elements/admin/gr-repo-list/gr-repo-list.html
View File

@@ -20,7 +20,7 @@ limitations under the License.
<link rel="import" href="../../../bower_components/iron-input/iron-input.html">
<link rel="import" href="../../../styles/gr-table-styles.html">
<link rel="import" href="../../../styles/shared-styles.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-list-view/gr-list-view.html">
<link rel="import" href="../../shared/gr-overlay/gr-overlay.html">
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
@@ -74,7 +74,7 @@ limitations under the License.
</table>
</gr-list-view>
<gr-overlay id="createOverlay" with-backdrop>
<gr-confirm-dialog
<gr-dialog
id="createDialog"
class="confirmDialog"
disabled="[[!_hasNewRepoName]]"
@@ -90,7 +90,7 @@ limitations under the License.
params="[[params]]"
id="createNewModal"></gr-create-repo-dialog>
</div>
</gr-confirm-dialog>
</gr-dialog>
</gr-overlay>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>

14
polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html
View File

@@ -24,7 +24,7 @@ limitations under the License.
<link rel="import" href="../../core/gr-navigation/gr-navigation.html">
<link rel="import" href="../../core/gr-reporting/gr-reporting.html">
<link rel="import" href="../../shared/gr-button/gr-button.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-dropdown/gr-dropdown.html">
<link rel="import" href="../../shared/gr-icons/gr-icons.html">
<link rel="import" href="../../shared/gr-js-api-interface/gr-js-api-interface.html">
@@ -210,7 +210,7 @@ limitations under the License.
action="[[revisionActions.submit]]"
on-cancel="_handleConfirmDialogCancel"
on-confirm="_handleSubmitConfirm" hidden></gr-confirm-submit-dialog>
<gr-confirm-dialog id="createFollowUpDialog"
<gr-dialog id="createFollowUpDialog"
class="confirmDialog"
confirm-label="Create"
on-confirm="_handleCreateFollowUpChange"
@@ -226,8 +226,8 @@ limitations under the License.
repo-name="[[change.project]]"
private-by-default="[[privateByDefault]]"></gr-create-change-dialog>
</div>
</gr-confirm-dialog>
<gr-confirm-dialog
</gr-dialog>
<gr-dialog
id="confirmDeleteDialog"
class="confirmDialog"
confirm-label="Delete"
@@ -240,8 +240,8 @@ limitations under the License.
<div class="main" slot="main">
Do you really want to delete the change?
</div>
</gr-confirm-dialog>
<gr-confirm-dialog
</gr-dialog>
<gr-dialog
id="confirmDeleteEditDialog"
class="confirmDialog"
confirm-label="Delete"
@@ -254,7 +254,7 @@ limitations under the License.
<div class="main" slot="main">
Do you really want to delete the edit?
</div>
</gr-confirm-dialog>
</gr-dialog>
</gr-overlay>
<gr-js-api-interface id="jsAPI"></gr-js-api-interface>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>

6
polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.html
View File

@@ -17,7 +17,7 @@ limitations under the License.
<link rel="import" href="../../../bower_components/iron-autogrow-textarea/iron-autogrow-textarea.html">
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../../styles/shared-styles.html">
<dom-module id="gr-confirm-abandon-dialog">
@@ -52,7 +52,7 @@ limitations under the License.
}
}
</style>
<gr-confirm-dialog
<gr-dialog
confirm-label="Abandon"
on-confirm="_handleConfirmTap"
on-cancel="_handleCancelTap">
@@ -66,7 +66,7 @@ limitations under the License.
placeholder="<Insert reasoning here>"
bind-value="{{message}}"></iron-autogrow-textarea>
</div>
</gr-confirm-dialog>
</gr-dialog>
</template>
<script src="gr-confirm-abandon-dialog.js"></script>
</dom-module>

4
polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog_test.html
View File

@@ -50,7 +50,7 @@ limitations under the License.
const confirmHandler = sandbox.stub();
element.addEventListener('confirm', confirmHandler);
sandbox.stub(element, '_confirm');
element.$$('gr-confirm-dialog').fire('confirm');
element.$$('gr-dialog').fire('confirm');
assert.isTrue(confirmHandler.called);
assert.isTrue(element._confirm.called);
});
@@ -59,7 +59,7 @@ limitations under the License.
const cancelHandler = sandbox.stub();
element.addEventListener('cancel', cancelHandler);
sandbox.stub(element, '_handleCancelTap');
element.$$('gr-confirm-dialog').fire('cancel');
element.$$('gr-dialog').fire('cancel');
assert.isTrue(cancelHandler.called);
assert.isTrue(element._handleCancelTap.called);
});

6
polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.html
View File

@@ -19,7 +19,7 @@ limitations under the License.
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../../styles/shared-styles.html">
<link rel="import" href="../../shared/gr-autocomplete/gr-autocomplete.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
<dom-module id="gr-confirm-cherrypick-dialog">
@@ -59,7 +59,7 @@ limitations under the License.
};
}
</style>
<gr-confirm-dialog
<gr-dialog
confirm-label="Cherry Pick"
on-confirm="_handleConfirmTap"
on-cancel="_handleCancelTap">
@@ -85,7 +85,7 @@ limitations under the License.
max-rows="15"
bind-value="{{message}}"></iron-autogrow-textarea>
</div>
</gr-confirm-dialog>
</gr-dialog>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>
<script src="gr-confirm-cherrypick-dialog.js"></script>

6
polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.html
View File

@@ -19,7 +19,7 @@ limitations under the License.
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../../styles/shared-styles.html">
<link rel="import" href="../../shared/gr-autocomplete/gr-autocomplete.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
<dom-module id="gr-confirm-move-dialog">
@@ -58,7 +58,7 @@ limitations under the License.
color: var(--error-text-color);
}
</style>
<gr-confirm-dialog
<gr-dialog
confirm-label="Move Change"
on-confirm="_handleConfirmTap"
on-cancel="_handleCancelTap">
@@ -87,7 +87,7 @@ limitations under the License.
max-rows="15"
bind-value="{{message}}"></iron-autogrow-textarea>
</div>
</gr-confirm-dialog>
</gr-dialog>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>
<script src="gr-confirm-move-dialog.js"></script>

6
polygerrit-ui/app/elements/change/gr-confirm-rebase-dialog/gr-confirm-rebase-dialog.html
View File

@@ -17,7 +17,7 @@ limitations under the License.
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../shared/gr-autocomplete/gr-autocomplete.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
<link rel="import" href="../../../styles/shared-styles.html">
@@ -51,7 +51,7 @@ limitations under the License.
margin: .5em 0;
}
</style>
<gr-confirm-dialog
<gr-dialog
id="confirmDialog"
confirm-label="Rebase"
on-confirm="_handleConfirmTap"
@@ -113,7 +113,7 @@ limitations under the License.
</gr-autocomplete>
</div>
</div>
</gr-confirm-dialog>
</gr-dialog>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>
<script src="gr-confirm-rebase-dialog.js"></script>

6
polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.html
View File

@@ -17,7 +17,7 @@ limitations under the License.
<link rel="import" href="../../../bower_components/iron-autogrow-textarea/iron-autogrow-textarea.html">
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../../styles/shared-styles.html">
<dom-module id="gr-confirm-revert-dialog">
@@ -47,7 +47,7 @@ limitations under the License.
}
}
</style>
<gr-confirm-dialog
<gr-dialog
confirm-label="Revert"
on-confirm="_handleConfirmTap"
on-cancel="_handleCancelTap">
@@ -63,7 +63,7 @@ limitations under the License.
max-rows="15"
bind-value="{{message}}"></iron-autogrow-textarea>
</div>
</gr-confirm-dialog>
</gr-dialog>
</template>
<script src="gr-confirm-revert-dialog.js"></script>
</dom-module>

5
polygerrit-ui/app/elements/change/gr-confirm-submit-dialog/gr-confirm-submit-dialog.html
View File

@@ -18,6 +18,7 @@ limitations under the License.
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../core/gr-navigation/gr-navigation.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
<link rel="import" href="../../../styles/shared-styles.html">
@@ -37,7 +38,7 @@ limitations under the License.
}
}
</style>
<gr-confirm-dialog
<gr-dialog
id="dialog"
confirm-label="Continue"
confirm-on-enter
@@ -55,7 +56,7 @@ limitations under the License.
<gr-endpoint-param name="action" value="[[action]]"></gr-endpoint-param>
</gr-endpoint-decorator>
</div>
</gr-confirm-dialog>
</gr-dialog>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>
<script src="gr-confirm-submit-dialog.js"></script>

6
polygerrit-ui/app/elements/diff/gr-confirm-delete-comment-dialog/gr-confirm-delete-comment-dialog.html
View File

@@ -17,7 +17,7 @@ limitations under the License.
<link rel="import" href="../../../bower_components/iron-autogrow-textarea/iron-autogrow-textarea.html">
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../../styles/shared-styles.html">
<dom-module id="gr-confirm-delete-comment-dialog">
@@ -52,7 +52,7 @@ limitations under the License.
}
}
</style>
<gr-confirm-dialog
<gr-dialog
confirm-label="Delete"
on-confirm="_handleConfirmTap"
on-cancel="_handleCancelTap">
@@ -66,7 +66,7 @@ limitations under the License.
placeholder="<Insert reasoning here>"
bind-value="{{message}}"></iron-autogrow-textarea>
</div>
</gr-confirm-dialog>
</gr-dialog>
</template>
<script src="gr-confirm-delete-comment-dialog.js"></script>
</dom-module>

8
polygerrit-ui/app/elements/diff/gr-diff-comment/gr-diff-comment.html
View File

@@ -23,7 +23,7 @@ limitations under the License.
<link rel="import" href="../../plugins/gr-endpoint-decorator/gr-endpoint-decorator.html">
<link rel="import" href="../../plugins/gr-endpoint-param/gr-endpoint-param.html">
<link rel="import" href="../../shared/gr-button/gr-button.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-date-formatter/gr-date-formatter.html">
<link rel="import" href="../../shared/gr-formatted-text/gr-formatted-text.html">
<link rel="import" href="../../shared/gr-icons/gr-icons.html">
@@ -214,7 +214,7 @@ limitations under the License.
.resolve label {
color: var(--comment-text-color);
}
gr-confirm-dialog .main {
gr-dialog .main {
display: flex;
flex-direction: column;
width: 100%;
@@ -366,7 +366,7 @@ limitations under the License.
</gr-confirm-delete-comment-dialog>
</gr-overlay>
<gr-overlay id="confirmDiscardOverlay" with-backdrop>
<gr-confirm-dialog
<gr-dialog
id="confirmDiscardDialog"
confirm-label="Discard"
confirm-on-enter
@@ -378,7 +378,7 @@ limitations under the License.
<div class="main" slot="main">
Are you sure you want to discard this draft comment?
</div>
</gr-confirm-dialog>
</gr-dialog>
</gr-overlay>
</template>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>

24
polygerrit-ui/app/elements/edit/gr-edit-controls/gr-edit-controls.html
View File

@@ -23,7 +23,7 @@ limitations under the License.
<link rel="import" href="../../core/gr-navigation/gr-navigation.html">
<link rel="import" href="../../shared/gr-autocomplete/gr-autocomplete.html">
<link rel="import" href="../../shared/gr-button/gr-button.html">
<link rel="import" href="../../shared/gr-confirm-dialog/gr-confirm-dialog.html">
<link rel="import" href="../../shared/gr-dialog/gr-dialog.html">
<link rel="import" href="../../shared/gr-dropdown/gr-dropdown.html">
<link rel="import" href="../../shared/gr-overlay/gr-overlay.html">
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
@@ -46,10 +46,10 @@ limitations under the License.
margin-left: 1em;
text-decoration: none;
}
gr-confirm-dialog {
gr-dialog {
width: 50em;
}
gr-confirm-dialog .main {
gr-dialog .main {
width: 100%;
}
gr-autocomplete {
@@ -71,7 +71,7 @@ limitations under the License.
width: 100%;
}
@media screen and (max-width: 50em) {
gr-confirm-dialog {
gr-dialog {
width: 100vw;
}
}
@@ -84,7 +84,7 @@ limitations under the License.
on-tap="_handleTap">[[action.label]]</gr-button>
</template>
<gr-overlay id="overlay" with-backdrop>
<gr-confirm-dialog
<gr-dialog
id="openDialog"
class="invisible dialog"
disabled$="[[!_isValidPath(_path)]]"
@@ -101,8 +101,8 @@ limitations under the License.
query="[[_query]]"
text="{{_path}}"></gr-autocomplete>
</div>
</gr-confirm-dialog>
<gr-confirm-dialog
</gr-dialog>
<gr-dialog
id="deleteDialog"
class="invisible dialog"
disabled$="[[!_isValidPath(_path)]]"
@@ -117,8 +117,8 @@ limitations under the License.
query="[[_query]]"
text="{{_path}}"></gr-autocomplete>
</div>
</gr-confirm-dialog>
<gr-confirm-dialog
</gr-dialog>
<gr-dialog
id="renameDialog"
class="invisible dialog"
disabled$="[[!_computeRenameDisabled(_path, _newPath)]]"
@@ -138,8 +138,8 @@ limitations under the License.
bind-value="{{_newPath}}"
placeholder="Enter the new path."/>
</div>
</gr-confirm-dialog>
<gr-confirm-dialog
</gr-dialog>
<gr-dialog
id="restoreDialog"
class="invisible dialog"
confirm-label="Restore"
@@ -153,7 +153,7 @@ limitations under the License.
disabled
bind-value="{{_path}}"/>
</div>
</gr-confirm-dialog>
</gr-dialog>
</gr-overlay>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>

4
polygerrit-ui/app/elements/shared/gr-confirm-dialog/gr-confirm-dialog.html → polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.html
View File

@@ -19,7 +19,7 @@ limitations under the License.
<link rel="import" href="../gr-button/gr-button.html">
<link rel="import" href="../../../styles/shared-styles.html">
<dom-module id="gr-confirm-dialog">
<dom-module id="gr-dialog">
<template>
<style include="shared-styles">
:host {
@@ -67,5 +67,5 @@ limitations under the License.
</footer>
</div>
</template>
<script src="gr-confirm-dialog.js"></script>
<script src="gr-dialog.js"></script>
</dom-module>

2
polygerrit-ui/app/elements/shared/gr-confirm-dialog/gr-confirm-dialog.js → polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.js
View File

@@ -18,7 +18,7 @@
'use strict';
Polymer({
is: 'gr-confirm-dialog',
is: 'gr-dialog',
/**
* Fired when the confirm button is pressed.

8
polygerrit-ui/app/elements/shared/gr-confirm-dialog/gr-confirm-dialog_test.html → polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog_test.html
View File

@@ -17,23 +17,23 @@ limitations under the License.
-->
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
<title>gr-confirm-dialog</title>
<title>gr-dialog</title>
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
<script src="../../../bower_components/web-component-tester/browser.js"></script>
<link rel="import" href="../../../test/common-test-setup.html"/>
<link rel="import" href="gr-confirm-dialog.html">
<link rel="import" href="gr-dialog.html">
<script>void(0);</script>
<test-fixture id="basic">
<template>
<gr-confirm-dialog></gr-confirm-dialog>
<gr-dialog></gr-dialog>
</template>
</test-fixture>
<script>
suite('gr-confirm-dialog tests', () => {
suite('gr-dialog tests', () => {
let element;
let sandbox;

2
polygerrit-ui/app/test/index.html
View File

@@ -151,10 +151,10 @@ limitations under the License.
'shared/gr-button/gr-button_test.html',
'shared/gr-change-star/gr-change-star_test.html',
'shared/gr-change-status/gr-change-status_test.html',
'shared/gr-confirm-dialog/gr-confirm-dialog_test.html',
'shared/gr-copy-clipboard/gr-copy-clipboard_test.html',
'shared/gr-cursor-manager/gr-cursor-manager_test.html',
'shared/gr-date-formatter/gr-date-formatter_test.html',
'shared/gr-dialog/gr-dialog_test.html',
'shared/gr-download-commands/gr-download-commands_test.html',
'shared/gr-dropdown-list/gr-dropdown-list_test.html',
'shared/gr-editable-content/gr-editable-content_test.html',