opendev/gerrit
Code Issues Proposed changes

NoteDbBatchUpdate: Close a new ObjectReader

Browse Source 
Change-Id: I8dd9ec5f71a7790056de0929ca921ea26072ffc8
This commit is contained in:
Dave Borowitz
2017-04-07 11:14:41 -04:00
parent 9184f67cf7
commit 326403d779
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/update/NoteDbBatchUpdate.java
View File

@@ -52,6 +52,7 @@ import java.util.TimeZone;
import java.util.TreeMap;
import org.eclipse.jgit.lib.NullProgressMonitor;
import org.eclipse.jgit.lib.ObjectInserter;
import org.eclipse.jgit.lib.ObjectReader;
import org.eclipse.jgit.lib.PersonIdent;
import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.revwalk.RevWalk;
@@ -377,7 +378,8 @@ class NoteDbBatchUpdate extends BatchUpdate {
// TODO(dborowitz): Teach NoteDbUpdateManager to allow reusing the same inserter and batch ref
// update as in executeUpdateRepo.
try (ObjectInserter ins = repo.newObjectInserter();
RevWalk rw = new RevWalk(ins.newReader());
ObjectReader reader = ins.newReader();
RevWalk rw = new RevWalk(reader);
NoteDbUpdateManager updateManager =
updateManagerFactory
.create(project)