opendev/gerrit
Code Issues Proposed changes

Exclude draft changes from ReindexAfterUpdate

Browse Source 
The draft changes can be deleted but not abandoned so there is no way for
an administrator to get rid of the them on behalf of the users. This can
become a problem when there many draft changes because the mergeability
check can be costly.

No longer reindex draft changes to update mergeability status when tip of
the branch is updated. Mergeability status will be updated when draft
change is published.

Change-Id: I682d5194bbdd372b45c2cb2b66191d5456887c21
This commit is contained in:
Hugo Arès
2016-09-20 16:37:35 +02:00
parent 4734437557
commit 3433f6eec8
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/index/change/ReindexAfterUpdate.java
View File

@@ -127,7 +127,7 @@ public class ReindexAfterUpdate implements GitReferenceUpdatedListener {
if (ref.equals(RefNames.REFS_CONFIG)) {
return asChanges(queryProvider.get().byProjectOpen(project));
}
return asChanges(queryProvider.get().byBranchOpen(
return asChanges(queryProvider.get().byBranchNew(
new Branch.NameKey(project, ref)));
}

8
gerrit-server/src/main/java/com/google/gerrit/server/query/change/InternalChangeQuery.java
View File

@@ -152,6 +152,14 @@ public class InternalChangeQuery extends InternalQuery<ChangeData> {
open()));
}
public List<ChangeData> byBranchNew(Branch.NameKey branch)
throws OrmException {
return query(and(
ref(branch),
project(branch.getParentKey()),
status(Change.Status.NEW)));
}
public Iterable<ChangeData> byCommitsOnBranchNotMerged(Repository repo,
ReviewDb db, Branch.NameKey branch, List<String> hashes)
throws OrmException, IOException {