opendev/gerrit
Code Issues Proposed changes

Update to gwtjsonrpc 1.3

Browse Source 
This also moves some code out of the server CLASSPATH,
fixing build issues in one of my hosting environments.

The change also shrinks the built WAR from 38M to 23M
by excluding the now unnecessary GWT server code.

Change-Id: Id9529f01c4dcf807a1197ac4dccb2a45507fa841
This commit is contained in:
Shawn O. Pearce
2012-04-08 17:37:57 -07:00
parent 78f15571e5
commit 34ab4294cd
75 changed files with 187 additions and 165 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/GerritCallback.java
View File

@@ -24,11 +24,11 @@ import com.google.gerrit.common.errors.NoSuchEntityException;
import com.google.gerrit.common.errors.NoSuchGroupException;
import com.google.gerrit.common.errors.NotSignedInException;
import com.google.gwt.core.client.GWT;
import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.common.AsyncCallback;
import com.google.gwt.user.client.rpc.InvocationException;
import com.google.gwtjsonrpc.client.JsonUtil;
import com.google.gwtjsonrpc.client.RemoteJsonException;
import com.google.gwtjsonrpc.client.ServerUnavailableException;
import com.google.gwtjsonrpc.common.JsonConstants;
/** Abstract callback handling generic error conditions automatically */
public abstract class GerritCallback<T> implements AsyncCallback<T> {
@@ -70,7 +70,7 @@ public abstract class GerritCallback<T> implements AsyncCallback<T> {
private static boolean isInvalidXSRF(final Throwable caught) {
return caught instanceof InvocationException
&& caught.getMessage().equals(JsonUtil.ERROR_INVALID_XSRF);
&& caught.getMessage().equals(JsonConstants.ERROR_INVALID_XSRF);
}
private static boolean isNotSignedIn(final Throwable caught) {