opendev/gerrit
Code Issues Proposed changes

Fix guice creation error during plugin loading

Browse Source 
The loading of of plugin was failing because of double binding of the
ServerInformation, once in the PluginModule and once in the Plugin
class.

Change-Id: I83a2d872814d4b80abb91f2da4e31d3c3f1e7fef
Signed-off-by: Sasa Zivkov <sasa.zivkov@sap.com>
This commit is contained in:
Sasa Zivkov
2012-05-18 15:57:26 +02:00
parent d01e76694f
commit 35b8e533ae
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-server/src/main/java/com/google/gerrit/server/plugins/Plugin.java
View File

@@ -20,7 +20,6 @@ import com.google.gerrit.extensions.annotations.PluginData;
import com.google.gerrit.extensions.annotations.PluginName;
import com.google.gerrit.extensions.registration.RegistrationHandle;
import com.google.gerrit.extensions.registration.ReloadableRegistrationHandle;
import com.google.gerrit.extensions.systemstatus.ServerInformation;
import com.google.gerrit.lifecycle.LifecycleListener;
import com.google.gerrit.lifecycle.LifecycleManager;
import com.google.inject.AbstractModule;
@@ -174,13 +173,6 @@ public class Plugin {
private Injector newRootInjector(PluginGuiceEnvironment env) {
List<Module> modules = Lists.newArrayListWithCapacity(4);
modules.add(env.getSysModule());
final ServerInformation srvInfo = env.getServerInformation();
modules.add(new AbstractModule() {
@Override
protected void configure() {
bind(ServerInformation.class).toInstance(srvInfo);
}
});
modules.add(new AbstractModule() {
@Override
protected void configure() {