opendev/gerrit
Code Issues Proposed changes

Remove check.access POST endpoint

Browse Source 
This endpoint was marked deprecated in the 2.16 release

This change stops binding the API, and removes the documentation.  A
follow up change will merge the code for POST and GET into one class.

Change-Id: Iad4f7c2061a2d6a4d43ec6ffbeca81695e0fde22
This commit is contained in:
Han-Wen Nienhuys
2018-11-05 15:57:42 +01:00
parent 89151b05e9
commit 3989ac9bad
3 changed files with 0 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
Documentation/rest-api-projects.txt
View File

@@ -1358,25 +1358,6 @@ access to at least branch is checked.
Ref(ref)::
The branch for which to check access. This must be given if `perm` is specified.
[[check-access-post]]
=== Check Access (POST)
This endpoint can also be accessed as a POST request (deprecated). In
this case, the input for the access checks must be provided in the
request body inside a link:#access-check-input[AccessCheckInput]
entity.
.Request
----
POST /projects/MyProject/check.access HTTP/1.0
Content-Type: application/json; charset=UTF-8
{
"account": "Kristen.Burns@gerritcodereview.com",
"ref": "refs/heads/secret/bla"
}
----
[[index]]
=== Index project
@@ -2936,21 +2917,6 @@ The `AccessCheckInfo` entity is the result of an access check.
|`message` |optional|A clarifying message if `status` is not 200.
|=========================================
[[access-check-input]]
=== AccessCheckInput
The `AccessCheckInput` entity is either an account or
(account, ref) tuple for which we want to check access.
[options="header",cols="1,^1,5"]
|=========================================
|Field Name ||Description
|`account` ||The account for which to check access
|`ref` |optional|The refname for which to check
access
|`permission` |optional|The ref permission for which to
check. This defaults to `read`. If given, it `ref` must be given too.
|=========================================
[[auto_closeable_changes_check_input]]
=== AutoCloseableChangesCheckInput
The `AutoCloseableChangesCheckInput` entity contains options for running

1
java/com/google/gerrit/server/restapi/project/Module.java
View File

@@ -55,7 +55,6 @@ public class Module extends RestApiModule {
get(PROJECT_KIND, "access").to(GetAccess.class);
post(PROJECT_KIND, "access").to(SetAccess.class);
put(PROJECT_KIND, "access:review").to(CreateAccessChange.class);
post(PROJECT_KIND, "check.access").to(CheckAccess.class);
get(PROJECT_KIND, "check.access").to(CheckAccessReadView.class);
post(PROJECT_KIND, "check").to(Check.class);

1
javatests/com/google/gerrit/acceptance/rest/ProjectsRestApiBindingsIT.java
View File

@@ -60,7 +60,6 @@ public class ProjectsRestApiBindingsIT extends AbstractRestApiBindingsTest {
RestCall.post("/projects/%s/access"),
RestCall.put("/projects/%s/access:review"),
RestCall.get("/projects/%s/check.access"),
RestCall.post("/projects/%s/check.access"),
RestCall.put("/projects/%s/ban"),
RestCall.get("/projects/%s/statistics.git"),
RestCall.post("/projects/%s/index"),