opendev/gerrit
Code Issues Proposed changes

Log all exceptions that occur while replacing a change in the index

Browse Source 
Replacing a change in the Lucene index is done in the background.
Currently only IOExceptions are caught and logged in the Runnable.
RuntimeExceptions are silently ignored, which makes it hard to see
if and why indexing failed, e.g. reindexing changes from the classes
that implement the REST API is currently failing with a
ProvisionException due to a missing requestScopePropagator and this
exception is not visible from the logs.

Change-Id: Ia4ed727a1c38eded514992cbbf739ad52ac10d41
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-06-24 22:02:28 +02:00
committed by Shawn Pearce
parent a44d8396e7
commit 3c4943675d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/index/ChangeIndexerImpl.java
View File

@@ -64,7 +64,7 @@ public class ChangeIndexerImpl implements ChangeIndexer {
}
@Override
public Void call() throws IOException {
public Void call() throws Exception {
index.replace(new ChangeData(change));
return null;
}