Polymer 2: Add _legacyUndefinedCheck

When legacy-data-mixin.html is imported this will tell you on the console which observers need fixing regarding this change of behavior:

https://polymer-library.polymer-project.org/2.0/docs/upgrade#update-observers

This change was created by running this command line:

find polygerrit-ui/app/ -type f | xargs sed -i '/^    is: / a\    _legacyUndefinedCheck: true,'

Once all observers are fixed, this change will be reverted. This is tracked in https://bugs.chromium.org/p/gerrit/issues/detail?id=10723

Change-Id: Icccdfaa52bf77dfb25e949b2aa2402110f6c2276
This commit is contained in:
brohlfs
2019-04-11 10:56:21 +02:00
committed by Ben Rohlfs
parent 6aa82ec016
commit 3e7f5fdd3f
181 changed files with 181 additions and 0 deletions

View File

@@ -52,6 +52,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'test-element',
_legacyUndefinedCheck: true,
behaviors: [
Gerrit.BaseUrlBehavior,
],

View File

@@ -38,6 +38,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'docs-url-behavior-element',
_legacyUndefinedCheck: true,
behaviors: [Gerrit.DocsUrlBehavior],
});
});

View File

@@ -46,6 +46,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'test-element',
_legacyUndefinedCheck: true,
behaviors: [Gerrit.DomUtilBehavior],
});
});

View File

@@ -38,6 +38,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'test-element',
_legacyUndefinedCheck: true,
behaviors: [Gerrit.AccessBehavior],
});
});

View File

@@ -41,6 +41,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'test-element',
_legacyUndefinedCheck: true,
behaviors: [
Gerrit.AdminNavBehavior,
],

View File

@@ -44,6 +44,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'test-element-anon',
_legacyUndefinedCheck: true,
behaviors: [
Gerrit.AnonymousNameBehavior,
],

View File

@@ -48,6 +48,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'test-element',
_legacyUndefinedCheck: true,
behaviors: [Gerrit.ChangeTableBehavior],
});
});

View File

@@ -40,6 +40,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'test-element',
_legacyUndefinedCheck: true,
behaviors: [Gerrit.ListViewBehavior],
});
});

View File

@@ -51,6 +51,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'tooltip-behavior-element',
_legacyUndefinedCheck: true,
behaviors: [Gerrit.TooltipBehavior],
});
});

View File

@@ -40,6 +40,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'test-element',
_legacyUndefinedCheck: true,
behaviors: [Gerrit.URLEncodingBehavior],
});
});

View File

@@ -50,6 +50,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'test-element',
_legacyUndefinedCheck: true,
behaviors: [Gerrit.KeyboardShortcutBehavior],
keyBindings: {
k: '_handleKey',

View File

@@ -54,6 +54,7 @@ limitations under the License.
// Define a Polymer element that uses this behavior.
Polymer({
is: 'test-element',
_legacyUndefinedCheck: true,
behaviors: [
Gerrit.BaseUrlBehavior,
Gerrit.RESTClientBehavior,

View File

@@ -39,6 +39,7 @@ limitations under the License.
suiteSetup(() => {
Polymer({
is: 'safe-types-element',
_legacyUndefinedCheck: true,
behaviors: [Gerrit.SafeTypes],
});
});

View File

@@ -38,6 +38,7 @@
Polymer({
is: 'gr-access-section',
_legacyUndefinedCheck: true,
properties: {
capabilities: Object,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-admin-group-list',
_legacyUndefinedCheck: true,
properties: {
/**

View File

@@ -22,6 +22,7 @@
Polymer({
is: 'gr-admin-view',
_legacyUndefinedCheck: true,
properties: {
/** @type {?} */

View File

@@ -25,6 +25,7 @@
Polymer({
is: 'gr-confirm-delete-item-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the confirm button is pressed.

View File

@@ -22,6 +22,7 @@
Polymer({
is: 'gr-create-change-dialog',
_legacyUndefinedCheck: true,
properties: {
repoName: String,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-create-group-dialog',
_legacyUndefinedCheck: true,
properties: {
params: Object,

View File

@@ -24,6 +24,7 @@
Polymer({
is: 'gr-create-pointer-dialog',
_legacyUndefinedCheck: true,
properties: {
detailType: String,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-create-repo-dialog',
_legacyUndefinedCheck: true,
properties: {
params: Object,

View File

@@ -21,6 +21,7 @@
Polymer({
is: 'gr-group-audit-log',
_legacyUndefinedCheck: true,
properties: {
groupId: String,

View File

@@ -25,6 +25,7 @@
Polymer({
is: 'gr-group-members',
_legacyUndefinedCheck: true,
properties: {
groupId: Number,

View File

@@ -32,6 +32,7 @@
Polymer({
is: 'gr-group',
_legacyUndefinedCheck: true,
/**
* Fired when the group name changes.

View File

@@ -37,6 +37,7 @@
Polymer({
is: 'gr-permission',
_legacyUndefinedCheck: true,
properties: {
labels: Object,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-plugin-list',
_legacyUndefinedCheck: true,
properties: {
/**

View File

@@ -70,6 +70,7 @@
Polymer({
is: 'gr-repo-access',
_legacyUndefinedCheck: true,
properties: {
repo: {

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-repo-command',
_legacyUndefinedCheck: true,
properties: {
title: String,

View File

@@ -28,6 +28,7 @@
Polymer({
is: 'gr-repo-commands',
_legacyUndefinedCheck: true,
properties: {
params: Object,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-repo-dashboards',
_legacyUndefinedCheck: true,
properties: {
repo: {

View File

@@ -26,6 +26,7 @@
Polymer({
is: 'gr-repo-detail-list',
_legacyUndefinedCheck: true,
properties: {
/**

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-repo-list',
_legacyUndefinedCheck: true,
properties: {
/**

View File

@@ -53,6 +53,7 @@
Polymer({
is: 'gr-repo',
_legacyUndefinedCheck: true,
properties: {
params: Object,

View File

@@ -65,6 +65,7 @@
Polymer({
is: 'gr-rule-editor',
_legacyUndefinedCheck: true,
properties: {
hasRange: Boolean,

View File

@@ -26,6 +26,7 @@
Polymer({
is: 'gr-change-list-item',
_legacyUndefinedCheck: true,
properties: {
visibleChangeTableColumns: Array,

View File

@@ -31,6 +31,7 @@
Polymer({
is: 'gr-change-list-view',
_legacyUndefinedCheck: true,
/**
* Fired when the title of the page should change.

View File

@@ -24,6 +24,7 @@
Polymer({
is: 'gr-change-list',
_legacyUndefinedCheck: true,
/**
* Fired when next page key shortcut was pressed.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-create-change-help',
_legacyUndefinedCheck: true,
/**
* Fired when the "Create change" button is tapped.

View File

@@ -25,6 +25,7 @@
Polymer({
is: 'gr-create-commands-dialog',
_legacyUndefinedCheck: true,
properties: {
branch: String,
_createNewCommitCommand: {

View File

@@ -26,6 +26,7 @@
Polymer({
is: 'gr-create-destination-dialog',
_legacyUndefinedCheck: true,
properties: {
_repo: String,
_branch: String,

View File

@@ -21,6 +21,7 @@
Polymer({
is: 'gr-dashboard-view',
_legacyUndefinedCheck: true,
/**
* Fired when the title of the page should change.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-embed-dashboard',
_legacyUndefinedCheck: true,
properties: {
account: Object,
sections: Array,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-repo-header',
_legacyUndefinedCheck: true,
properties: {
/** @type {?String} */
repo: {

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-user-header',
_legacyUndefinedCheck: true,
properties: {
/** @type {?String} */
userId: {

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-account-entry',
_legacyUndefinedCheck: true,
/**
* Fired when an account is entered.

View File

@@ -21,6 +21,7 @@
Polymer({
is: 'gr-account-list',
_legacyUndefinedCheck: true,
/**
* Fired when user inputs an invalid email address.

View File

@@ -193,6 +193,7 @@
Polymer({
is: 'gr-change-actions',
_legacyUndefinedCheck: true,
/**
* Fired when the change should be reloaded.

View File

@@ -61,6 +61,7 @@
Polymer({
is: 'gr-change-metadata',
_legacyUndefinedCheck: true,
/**
* Fired when the change topic is changed.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-change-requirements',
_legacyUndefinedCheck: true,
properties: {
/** @type {?} */

View File

@@ -64,6 +64,7 @@
Polymer({
is: 'gr-change-view',
_legacyUndefinedCheck: true,
/**
* Fired when the title of the page should change.

View File

@@ -18,6 +18,7 @@
'use strict';
Polymer({
is: 'gr-comment-list',
_legacyUndefinedCheck: true,
behaviors: [
Gerrit.BaseUrlBehavior,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-commit-info',
_legacyUndefinedCheck: true,
properties: {
change: Object,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-confirm-abandon-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the confirm button is pressed.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-confirm-cherrypick-conflict-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the confirm button is pressed.

View File

@@ -21,6 +21,7 @@
Polymer({
is: 'gr-confirm-cherrypick-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the confirm button is pressed.

View File

@@ -21,6 +21,7 @@
Polymer({
is: 'gr-confirm-move-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the confirm button is pressed.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-confirm-rebase-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the confirm button is pressed.

View File

@@ -22,6 +22,7 @@
Polymer({
is: 'gr-confirm-revert-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the confirm button is pressed.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-confirm-submit-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the confirm button is pressed.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-download-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the user presses the close button.

View File

@@ -23,6 +23,7 @@
Polymer({
is: 'gr-file-list-header',
_legacyUndefinedCheck: true,
/**
* @event expand-diffs

View File

@@ -63,6 +63,7 @@
Polymer({
is: 'gr-file-list',
_legacyUndefinedCheck: true,
/**
* Fired when a draft refresh should get triggered

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-included-in-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the user presses the close button.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-label-score-row',
_legacyUndefinedCheck: true,
/**
* Fired when any label is changed.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-label-scores',
_legacyUndefinedCheck: true,
properties: {
_labels: {
type: Array,

View File

@@ -22,6 +22,7 @@
Polymer({
is: 'gr-message',
_legacyUndefinedCheck: true,
/**
* Fired when this message's reply link is tapped.

View File

@@ -27,6 +27,7 @@
Polymer({
is: 'gr-messages-list',
_legacyUndefinedCheck: true,
properties: {
changeNum: Number,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-related-changes-list',
_legacyUndefinedCheck: true,
/**
* Fired when a new section is loaded so that the change view can determine

View File

@@ -58,6 +58,7 @@
Polymer({
is: 'gr-reply-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when a reply is successfully sent.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-reviewer-list',
_legacyUndefinedCheck: true,
/**
* Fired when the "Add reviewer..." button is tapped.

View File

@@ -25,6 +25,7 @@
Polymer({
is: 'gr-thread-list',
_legacyUndefinedCheck: true,
properties: {
/** @type {?} */

View File

@@ -29,6 +29,7 @@
Polymer({
is: 'gr-upload-help-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the user presses the close button.

View File

@@ -21,6 +21,7 @@
Polymer({
is: 'gr-account-dropdown',
_legacyUndefinedCheck: true,
properties: {
account: Object,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-error-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the dismiss button is pressed.

View File

@@ -27,6 +27,7 @@
Polymer({
is: 'gr-error-manager',
_legacyUndefinedCheck: true,
behaviors: [
Gerrit.BaseUrlBehavior,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-key-binding-display',
_legacyUndefinedCheck: true,
properties: {
/** @type {Array<string>} */

View File

@@ -21,6 +21,7 @@
Polymer({
is: 'gr-keyboard-shortcuts-dialog',
_legacyUndefinedCheck: true,
/**
* Fired when the user presses the close button.

View File

@@ -71,6 +71,7 @@
Polymer({
is: 'gr-main-header',
_legacyUndefinedCheck: true,
hostAttributes: {
role: 'banner',

View File

@@ -144,6 +144,7 @@
// eslint-disable-next-line prefer-const
let GrReporting = Polymer({
is: 'gr-reporting',
_legacyUndefinedCheck: true,
properties: {
category: String,

View File

@@ -204,6 +204,7 @@
Polymer({
is: 'gr-router',
_legacyUndefinedCheck: true,
properties: {
_app: {

View File

@@ -106,6 +106,7 @@
Polymer({
is: 'gr-search-bar',
_legacyUndefinedCheck: true,
/**
* Fired when a search is committed

View File

@@ -23,6 +23,7 @@
Polymer({
is: 'gr-smart-search',
_legacyUndefinedCheck: true,
properties: {
searchQuery: String,

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'comment-api-mock',
_legacyUndefinedCheck: true,
properties: {
_changeComments: Object,

View File

@@ -482,6 +482,7 @@
Polymer({
is: 'gr-comment-api',
_legacyUndefinedCheck: true,
properties: {
_changeComments: Object,

View File

@@ -65,6 +65,7 @@ limitations under the License.
Polymer({
is: 'gr-diff-builder',
_legacyUndefinedCheck: true,
/**
* Fired when the diff begins rendering.

View File

@@ -37,6 +37,7 @@
Polymer({
is: 'gr-diff-cursor',
_legacyUndefinedCheck: true,
properties: {
/**

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-diff-highlight',
_legacyUndefinedCheck: true,
properties: {
/** @type {!Array<!Gerrit.HoveredRange>} */

View File

@@ -66,6 +66,7 @@
*/
Polymer({
is: 'gr-diff-host',
_legacyUndefinedCheck: true,
/**
* Fired when the user selects a line.

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-diff-mode-selector',
_legacyUndefinedCheck: true,
properties: {
mode: {

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-diff-preferences-dialog',
_legacyUndefinedCheck: true,
properties: {
/** @type {?} */

View File

@@ -60,6 +60,7 @@
*/
Polymer({
is: 'gr-diff-processor',
_legacyUndefinedCheck: true,
properties: {

View File

@@ -32,6 +32,7 @@
Polymer({
is: 'gr-diff-selection',
_legacyUndefinedCheck: true,
properties: {
diff: Object,

View File

@@ -35,6 +35,7 @@
Polymer({
is: 'gr-diff-view',
_legacyUndefinedCheck: true,
/**
* Fired when the title of the page should change.

View File

@@ -106,6 +106,7 @@
Polymer({
is: 'gr-diff',
_legacyUndefinedCheck: true,
/**
* Fired when the user selects a line.

View File

@@ -31,6 +31,7 @@
Polymer({
is: 'gr-patch-range-select',
_legacyUndefinedCheck: true,
properties: {
availablePatches: Array,

View File

@@ -27,6 +27,7 @@
Polymer({
is: 'gr-ranged-comment-layer',
_legacyUndefinedCheck: true,
/**
* Fired when the range in a range comment was malformed and had to be

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-selection-action-box',
_legacyUndefinedCheck: true,
/**
* Fired when the comment creation action was taken (hotkey, click).

View File

@@ -129,6 +129,7 @@
Polymer({
is: 'gr-syntax-layer',
_legacyUndefinedCheck: true,
properties: {
diff: {

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-documentation-search',
_legacyUndefinedCheck: true,
properties: {
/**

View File

@@ -19,6 +19,7 @@
Polymer({
is: 'gr-default-editor',
_legacyUndefinedCheck: true,
/**
* Fired when the content of the editor changes.

Some files were not shown because too many files have changed in this diff Show More