opendev/gerrit
Code Issues Proposed changes

Delete dead old style myDiffPreferences RPC

Browse Source 
This method is not invoked by any UI code. Drop the method.
/accounts/self/preferences.diff provides the same data on
a supported REST API.

Change-Id: If88d8449f48e898fc84fdabad19341bd8063a737
This commit is contained in:
Shawn Pearce
2013-11-20 23:13:09 -08:00
parent bb12a3dec6
commit 3eb9776740
2 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-common/src/main/java/com/google/gerrit/common/data/AccountService.java
View File

@@ -34,9 +34,6 @@ public interface AccountService extends RemoteJsonService {
@SignInRequired
void myAccount(AsyncCallback<Account> callback);
@SignInRequired
void myDiffPreferences(AsyncCallback<AccountDiffPreference> callback);
@Audit
@SignInRequired
void changePreferences(AccountGeneralPreferences pref,

10
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountServiceImpl.java
View File

@@ -72,16 +72,6 @@ class AccountServiceImpl extends BaseServiceImplementation implements
callback.onSuccess(currentUser.get().getAccount());
}
@Override
public void myDiffPreferences(AsyncCallback<AccountDiffPreference> callback) {
run(callback, new Action<AccountDiffPreference>() {
@Override
public AccountDiffPreference run(ReviewDb db) throws OrmException {
return currentUser.get().getAccountDiffPreference();
}
});
}
public void changePreferences(final AccountGeneralPreferences pref,
final AsyncCallback<VoidResult> callback) {
run(callback, new Action<VoidResult>() {