opendev/gerrit
Code Issues Proposed changes

pom.xml: change gerrit-war's dependency on gerrit-main to runtime

Browse Source 
Previously, the dependency was set to 'provided' (meaning required at
compile time but not to be deployed), but the Main class from
gerrit-main is required at runtime because the shipped manifest in the
.war package references Main in its main-class attribute. Also, it
doesn't appear to use Main outside of the manifest, so it's not
actually required at compile time.

This only seems to matter to IntelliJ, since the Main class is
provided to the war via an overlay in gerrit-war/pom.xml

Change-Id: I80598fed0c5e5b5a6e59de6ae7ca5f3669a22cfa
This commit is contained in:
Augie Fackler
2011-11-01 10:47:36 -05:00
parent 4e560dcbc7
commit 3ef55a1472
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-war/pom.xml
View File

@@ -53,7 +53,7 @@ limitations under the License.
<groupId>com.google.gerrit</groupId>
<artifactId>gerrit-main</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
<scope>runtime</scope>
</dependency>
<dependency>