opendev/gerrit
Code Issues Proposed changes

Merge "CreateTag: document why we don't check for visibility"

Browse Source
This commit is contained in:
Han-Wen Nienhuys
2021-01-14 09:31:58 +00:00
committed by Gerrit Code Review
parent 9c6244c48a ba6b6d3f48
commit 469eafcbc5
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/restapi/project/CreateTag.java
View File

@@ -102,6 +102,8 @@ public class CreateTag implements RestCollectionCreateView<ProjectResource, TagR
try (Repository repo = repoManager.openRepository(resource.getNameKey())) { try (Repository repo = repoManager.openRepository(resource.getNameKey())) {
ObjectId revid = RefUtil.parseBaseRevision(repo, resource.getNameKey(), input.revision); ObjectId revid = RefUtil.parseBaseRevision(repo, resource.getNameKey(), input.revision);
RevWalk rw = RefUtil.verifyConnected(repo, revid); RevWalk rw = RefUtil.verifyConnected(repo, revid);
// Reachability through tags does not influence a commit's visibility, so no need to check for
// visibility.
RevObject object = rw.parseAny(revid); RevObject object = rw.parseAny(revid);
rw.reset(); rw.reset();
boolean isAnnotated = Strings.emptyToNull(input.message) != null; boolean isAnnotated = Strings.emptyToNull(input.message) != null;